Hi David, David Bremner <[email protected]> writes:
> Xiyue Deng <[email protected]> writes: >> >> It would be good that dh-elpa can also check that all intended files are >> included in the `elpa' file of all binary packages. Ideally it should >> handle glob, skip hidden files like `.dir-locals.el' and test files by >> default, and provide an option (e.g. `--exclude-el') to optionally skip >> more files as needed. > > I didn't investigate much, but this seems like the job dh_missing is > supposed to do. Why doesn't it work for dh_elpa using packages? The > --fail-missing option is default now (compat 13). > Thanks for the pointer! I took a look and it looks like that in dh_elpa only source files listed in the debian/*elpa files are actually logged in log_installed_file (see [1][2][3]), so this won't check the actual files in the source directory. In that sense, I guess dh_missing is probably used for verifying that all files listed in debian/*{install,elpa} are included in the .deb package. And I feel like this is probably intended, as it makes sense if files are shipped in multiple packages, but I could be missing something. This leaves the question on whether we want to implement this logic separately in dh-elpa, or fix the usage of log_installed_files? For the latter, I also wonder whether dh_missing should be used this way, or IOW whether it is already working as intended. [1] https://salsa.debian.org/emacsen-team/dh-elpa/-/blob/master/dh_elpa?ref_type=heads#L234 [2] https://salsa.debian.org/emacsen-team/dh-elpa/-/blob/master/dh_elpa?ref_type=heads#L274 [3] https://salsa.debian.org/emacsen-team/dh-elpa/-/blob/master/dh_elpa?ref_type=heads#L287 -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
