Hi Sean, Sean Whitton <spwhit...@spwhitton.name> writes:
> Hello, > > On Mon 09 Dec 2024 at 11:02am -08, Xiyue Deng wrote: > >> I would expect that if `foo' depends on `(bar "1.0.0")', then bar with >> `Package-Version: 1.0.0-git' would also satisfy the requirement, like >> saying that bar has added some new interfaces required by foo, and may >> (or may not) add more. Just my 2 cents. >> >> How does Emacs itself handle this kind of version dependencies? > > Take a look at the documentation of `version-to-list'. It implies that > 1.0.0-git would not satisfy 1.0.0. > Thanks for the reference! So we should really only handle pre-release versions by adding "~" and leave the released versions untouched. I'll try to update the patch accordingly. >>> There are already snapshot, -git, .cvs etc. version numbers defined. >>> See `version-to-list'. Maybe dh_elpa could append a tilde in the >>> presence of one of those. >>> >> >> I'm not sure this will help with the dap-mode/emacs-lsp-docker >> situation, as the current Package-Version of emacs-lsp-docker doesn't >> have a suffix :/ > > But you could patch it in for our packaged version. > So it looks like for the case of lsp-docker, if dap-mode depends on `((lsp-docker "1.0.0"))' upstream should really release a tag. I'll contact upstream to follow up. > -- > Sean Whitton -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
