Hiya, Manphiz writes:
> Manphiz <manp...@gmail.com> writes: > >> Another finding is that in 28.x, if the term buffer have any further >> questions to ask, debian-bug seems to consider the process stuck and >> would just ignore everything and proceed. In 29.x however, the term >> buffer seems to be able to accept user input and can process the output >> accordingly - even if the script requires sudo and prompt for password, >> and debian-bug can properly include the output in the generated email >> for bug report. So with the merge request[4] it would instead skip all >> potential additional information unfortunately. >> > > Actually 28.x also works for user inputs if running term-exec without my > problematic hooks so yeah! > >> As we do want to handle process termination better, while trying to keep >> process from failing, I think temporarily disable term-exec-hook when >> processing the output and restore after the report is generated should >> probably work in most cases. Just wondering whether this is acceptable >> in the process of debian-bug? >> > > Forgot to mention that this is implemented as the 2nd commit in the > MR[4] and tested on bookworm and trixie to be working. > >> [4] https://salsa.debian.org/emacsen-team/debian-el/-/merge_requests/11 Thank you for the patch. :-) This seems like a reasonable fix to me, and if David has no comments or objections I'd be happy to merge it in the coming days. Quick request: would you please amend your patch/MR to add a debian/changelog entry for the change(s)? It would be good to do a new upload soon, and it'd be nice to have debian/changelog in tiptop shape for that. Thanks, -a
