Sean Whitton <spwhit...@spwhitton.name> writes: > control: tag -1 + wontfix > > Hello, > > Thank you for these submissions. > > On Sun 23 Jul 2023 at 08:48pm -07, Manphiz wrote: > >> * Sync to latest head version, which basically just incorporated Sean's >> patch upstream so that we don't need to host the patch anymore. > > Patches don't really work for merging new upstream releases -- in this > case, pushing a branch somewhere and inviting me to merge it is better. > For proposed new changes rather than merges, I do indeed prefer patches, > so thank you for preparing those. > > In this case, I would prefer not to merge the new upstream, because it > doesn't actually change the package. It's not a problem carrying the > patch, and I think it's preferable. > > As for your first patch, I don't follow -- I think I already fixed that > a while ago? Indeed, the patch does not apply to our team's repository. > > I would prefer not to apply the final patch until the QA team come and > tell us that we should disable watch files like that.
Hi Sean, Thanks for the comments and I understand your reasons. Actually I am also unsure about how to deal with uscan errors with a watch file that tracks upstream tags that don't exist, and as you and Nicolas both suggest against disabling them, I think I may need to rethink how to approach this. I'll probably ask in emacsen-team@ for comments later. -- Manphiz
