On 2019-02-05 00:52:47, Nicholas D Steeves wrote: > Package: php-elisp > Version: 1.21.0-1 > Severity: normal > > Hi Antoine, > > Thank you for much for sponsoring src:php-elisp! I've created a > tracking bug for these issues, replied inline, and plan to fix them in > the next upload. > > On Sat, Feb 02, 2019 at 12:40:40PM -0500, Antoine Beaupré wrote: >> I uploaded the package, but I'll note some improvements that could be >> done on it: >>
[...] >> 2. very minor, but i like to keep the "transitional package" phrase on >> a separate line in package descriptions so it's more obvious to >> someone looking at the description > > Do you mean like this?: > Short description: transitional package from old-foo to new-foo package > Old-foo description, and why new-foo... > . > This is a transitional dummy package and can be safely removed. Correct. >> 3. why was the php-root self-test disabled? what's the next step for >> that patch? can it be sent upstream or will we have to carry this on >> forever? > > (ert-deftest php-project-root () > (should (string= (abbreviate-file-name default-directory) > (php-project-get-root-dir)))) > > Evals to "/<<PKGBUILDDIR>>/" instead of the real path. It will take > some time to review the changelogs and git history of my other > packages to find the workaround for this sbuild/buildd quirk, because > I didn't write "PKGBUILDDIR" as a keyword the last time I ran into it. > Oops... Thus, I confess to choosing the fastest/easiest path since > the freeze is so close. No problem. It was a bit of a rhetorical question: if you had explained that in the comment of the patch, as per DEP-3, I wouldn't have needed to ask. ;) https://dep-team.pages.debian.net/deps/dep3/ A. -- In serious work commanding and discipline are of little avail. - Peter Kropotkin
