On Sun, Aug 17, 2025 at 02:44:06PM -0700, Otto Kekäläinen wrote:
> In the web interface you can suggest changes that automatically become
> patches on the branch, which the original submitter can easily clean
> up / integrate next time they rebase/refresh the MR.
My point was that it takes a lot more effort, and time, to tell the
submitter what to change, and then (a) wait for them to make the
change, and (b) hope they make the change correctly. If they don't
then you have to repeat, possily multiple times.
You could just make the change yourself, and then do a "git commit
--amend", but then the MR won't get closed automatically, becaue the
forge won't recognize the modified commit. And if you do a "git
commit" instead ofa "git commit --amend", then you break bisectibility
of the git tree.
Yes, you could then close the commit manually, but now it's more work
than the e-mail based workflow.
If you use b4[1] as part of the e-mail based workflow, BTW, and you
modify the patch submitted using "git commit", b4's auto-thankanator
("b4 ty") is smart enough to detect modified commits and associate
them with the acknowledgement. So this is something that github and
Salsa could do better, but right now... they don't.
[1] https://b4.docs.kernel.org/en/latest/
Cheers,
- Ted
