Hello, On Wed, Nov 5, 2014 at 1:09 AM, Cameron Norman <camerontnor...@gmail.com> wrote: > A few notes I have: > > 1. With Jessie and on, with sysvinit /sbin/init //will// be a link, > not the true init file. This would lead to unknowns when the init was > actually sysv.
care to explain a bit better? I just upgraded a Wheezy VM to testing and (except some issues) once I replaced systemd with sysvinit-core /sbin/init *is* a regular file: morph@debian:~$ dpkg -l sysvinit-core | cat Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-============-============-================================= ii sysvinit-core 2.88dsf-53.4 amd64 System-V-like init utilities morph@debian:~$ dpkg -S /sbin/init sysvinit-core: /sbin/init morph@debian:~$ file /sbin/init /sbin/init: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=0b29c65c4ae879649971cfd1d469ca03421714ff, stripped > 2. With Upstart, /sbin/init is not a link, so that third test would > give a false positive for sysvinit when it was actually Upstart > (assuming the Upstart check gave a false negative). it should not be a false negative, do you have a situation in mind where it might happen? > 3. Maybe you should embed the check for Upstart, so that you do not > have to source all of the init functions, and if that file is ever not > available you still get the correct check. lsb init functions are part of lsb-base, a required package > 4. There is a tiny typo in the Upstart check. It needs an extra right > parenthese at the end of the message. I know I know, I should have probably followed up as i noticed 10 seconds after having sent the email and a lot of people pointed it out (more of the people actually running the script and report back the results to me :( ). Cheers -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAB4XWXzYW9+WeiUaVVTM8C3zr7MONEb6qMOBSr7+O1C2=4f...@mail.gmail.com
