On Wed, 16 Apr 2008 18:38:39 +0100, Darren Salt <[EMAIL PROTECTED]> said:
> I demand that Loïc Minier may or may not have written... >> On Wed, Apr 16, 2008, Raphael Hertzog wrote: >>> But I disagree that debian/rules is necessarily the place where it >>> belongs. It looks like cruft/bad design to have the same snippet of >>> code in all packages. >> Perhaps this should be fixed in another way then? For example a >> shared Makefile included by all debian/rules (if they are a makefile >> :) -- ala cdbs, but with a simple documented interface such as >> documenting that this will set *FLAGS based on deb_build_opts. e.g. >> /usr/share/dpkg/flags.mk with: >> CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2) > That looks reasonable to me. Hmm. Smells a lot like: --8<---------------cut here---------------start------------->8--- ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) CFLAGS += -O0 else CFLAGS += -O2 endif --8<---------------cut here---------------end--------------->8--- See §10.1. Binaries. > However, care should be taken to avoid ending up with > cdbs-buildpackage ;-) manoj -- "I'd love to go out with you, but I want to spend more time with my blender." Manoj Srivastava <[EMAIL PROTECTED]> <http://www.debian.org/~srivasta/> 1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]