Your message dated Fri, 27 Apr 2007 13:47:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#397048: fixed in gtk-gnutella 0.96.3-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: gtk-gnutella
Version: 0.96.1svn12109-1
Severity: serious
Tags: patch
Justification: no longer builds from source
Build fails on ARM with STATIC_ASSERT failures. The ARM ABI padds
structudes to 4-byte boundaries by default. The attached patch adds
__attribute__((packed)) to inhibit this on structures that need to be
a funny size.
Paul
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: arm (armv5tejl)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-rc7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
diff -ur gtk-gnutella-clean/src/core/gnutella.h gtk-gnutella-0.96.1svn12109/src/core/gnutella.h
--- gtk-gnutella-clean/src/core/gnutella.h 2006-10-16 00:01:09.000000000 +0100
+++ gtk-gnutella-0.96.1svn12109/src/core/gnutella.h 2006-11-04 15:07:19.000000000 +0000
@@ -48,25 +48,25 @@
struct gnutella_msg_init {
struct gnutella_header header;
/**< GGEP data may follow */
-};
+} __attribute__((packed));
struct gnutella_init_response {
guchar host_port[2];
guchar host_ip[4];
guchar files_count[4];
guchar kbytes_count[4];
-};
+} __attribute__((packed));
struct gnutella_msg_init_response {
struct gnutella_header header;
struct gnutella_init_response response;
/**< GGEP data may follow */
-};
+} __attribute__((packed));
struct gnutella_search {
guchar speed[2];
/**< query string follows */
-};
+} __attribute__((packed));
struct gnutella_search_results {
guchar num_recs;
@@ -76,41 +76,41 @@
/* record data follows */
/* Last 16 bytes = client_id */
-};
+} __attribute__((packed));
struct gnutella_msg_search {
struct gnutella_header header;
struct gnutella_search search;
-};
+} __attribute__((packed));
struct gnutella_push_request {
guchar guid[16];
guchar file_id[4];
guchar host_ip[4];
guchar host_port[2];
-};
+} __attribute__((packed));
struct gnutella_msg_push_request {
struct gnutella_header header;
struct gnutella_push_request request;
/**< GGEP data may follow */
-};
+} __attribute__((packed));
struct gnutella_bye {
guchar code[2];
/**< message string follows */
-};
+} __attribute__((packed));
struct gnutella_qrp_reset {
guchar variant; /**< 0x00 */
guchar table_length[4]; /**< little endian */
guchar infinity;
-};
+} __attribute__((packed));
struct gnutella_msg_qrp_reset {
struct gnutella_header header;
struct gnutella_qrp_reset data;
-};
+} __attribute__((packed));
struct gnutella_qrp_patch {
guchar variant; /**< 0x01 */
@@ -118,29 +118,29 @@
guchar seq_size;
guchar compressor;
guchar entry_bits;
-};
+} __attribute__((packed));
struct gnutella_msg_qrp_patch {
struct gnutella_header header;
struct gnutella_qrp_patch data;
-};
+} __attribute__((packed));
struct gnutella_vendor {
guchar vendor[4]; /**< For example, "GTKG" */
guchar selector_id[2]; /**< Message selector ID, little endian */
guchar version[2]; /**< Message version number, little endian */
/* payload follows */
-};
+} __attribute__((packed));
struct gnutella_msg_vendor {
struct gnutella_header header;
struct gnutella_vendor data;
-};
+} __attribute__((packed));
struct gnutella_msg_hsep_data {
struct gnutella_header header;
guchar triple[3 * sizeof(guint64)];
-};
+} __attribute__((packed));
#endif /* _core_gnutella_h_ */
diff -ur gtk-gnutella-clean/src/core/qhit.c gtk-gnutella-0.96.1svn12109/src/core/qhit.c
--- gtk-gnutella-clean/src/core/qhit.c 2006-10-16 00:01:09.000000000 +0100
+++ gtk-gnutella-0.96.1svn12109/src/core/qhit.c 2006-11-04 16:16:38.000000000 +0000
@@ -677,7 +677,7 @@
struct {
gchar ipv4[4];
gchar port[2];
- } alt;
+ } __attribute__((packed)) alt;
STATIC_ASSERT(sizeof alt == 6);
poke_be32(alt.ipv4, host_addr_ipv4(hvec[i].addr));
diff -ur gtk-gnutella-clean/src/if/core/gnutella.h gtk-gnutella-0.96.1svn12109/src/if/core/gnutella.h
--- gtk-gnutella-clean/src/if/core/gnutella.h 2006-10-16 00:01:09.000000000 +0100
+++ gtk-gnutella-0.96.1svn12109/src/if/core/gnutella.h 2006-11-04 15:03:09.000000000 +0000
@@ -62,7 +62,7 @@
guchar ttl;
guchar hops;
guchar size[4];
-};
+} __attribute__((packed));
#define GTA_HEADER_SIZE sizeof(struct gnutella_header)
--- End Message ---
--- Begin Message ---
Source: gtk-gnutella
Source-Version: 0.96.3-1
We believe that the bug you reported is fixed in the latest version of
gtk-gnutella, which is due to be installed in the Debian FTP archive:
gtk-gnutella_0.96.3-1.diff.gz
to pool/main/g/gtk-gnutella/gtk-gnutella_0.96.3-1.diff.gz
gtk-gnutella_0.96.3-1.dsc
to pool/main/g/gtk-gnutella/gtk-gnutella_0.96.3-1.dsc
gtk-gnutella_0.96.3-1_i386.deb
to pool/main/g/gtk-gnutella/gtk-gnutella_0.96.3-1_i386.deb
gtk-gnutella_0.96.3.orig.tar.gz
to pool/main/g/gtk-gnutella/gtk-gnutella_0.96.3.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Luca Bruno <[EMAIL PROTECTED]> (supplier of updated gtk-gnutella package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 13 Apr 2007 19:01:34 +0200
Source: gtk-gnutella
Binary: gtk-gnutella
Architecture: source i386
Version: 0.96.3-1
Distribution: unstable
Urgency: medium
Maintainer: Luca Bruno <[EMAIL PROTECTED]>
Changed-By: Luca Bruno <[EMAIL PROTECTED]>
Description:
gtk-gnutella - shares files in a peer to peer network
Closes: 396132 397048 418080
Changes:
gtk-gnutella (0.96.3-1) unstable; urgency=medium
.
* New maintainer (Closes: #418080)
* New upstream version (Closes: #396132 and related)
* Starting from rev12147, it should now build also on ARM (Closes: #397048)
Files:
e30e5738d1d609a4d2fa2ba4586ac44f 740 net optional gtk-gnutella_0.96.3-1.dsc
34b4562e2ba0337d161a68cafc658be7 3698305 net optional
gtk-gnutella_0.96.3.orig.tar.gz
f926dc3a23e1865995d31bd6d76cfdbc 1739 net optional
gtk-gnutella_0.96.3-1.diff.gz
fcf64ab298e96f0d5a6f39c4bf605993 2244880 net optional
gtk-gnutella_0.96.3-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGMfyJaGRzDfCV5eQRAkd4AJ4mEPtRfRfn1YLs0FLIbVrb+TNlEgCbBzqB
F0ChTrEYk1FjSoZwf6/lW8Q=
=knNh
-----END PGP SIGNATURE-----
--- End Message ---
