On Fri, Mar 02, 2007 at 12:43:29PM -0300, Gustavo Franco wrote:
> tags 407361 patch
> thanks

> Please consider the following patches to fix this bug that i intent to NMU 
> soon.

> --- libtowitoko2.postrm    2007-03-02 12:30:58.000000000 -0300
> +++ libtowitoko2.postrm 2007-03-02 12:41:02.000000000 -0300
> @@ -23,7 +23,9 @@
>     # restart pcscd (PCSC daemon) if the package is installed
>     # and if pcscd is running
>     if [ -x /etc/init.d/pcscd ]; then
> -      /etc/init.d/pcscd restart-if-running 3>/dev/null || true
> +      if [ `pidof pcscd` ]; then
> +        /etc/init.d/pcscd restart 3>/dev/null || true
> +      fi
>     fi

Please see policy 9.3.3 for an explanation of why this patch is incorrect
(as is the original code).

Also, if using invoke-rc.d as described in policy, you can arguably do
without the pidof check at all, since it's the admin's responsibility to set
a policy for the daemon if they don't want it to be started.  (The most
straightforward way to do that is by turning it off in the relevant
runlevel.)

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to