Hi Frank,

On 2/8/07, Frank Küster <[EMAIL PROTECTED]> wrote:
Ah, you need a sponsor.  My criteria for sponsoring are a bit more
restrictive than for NMUs, and I've had a look at the package, and some
comments:

Thank you for pointing out these things.


- debian/copyright: You (or rather Brian Furry) mixed up license and
  copyright.  After "Copyright", the names of the copyright holders
  should be listed.  Usually these are the authors (but not always,
  sometimes e.g. it's the institution they work for).  Ah I see, the
  copyright holder is again listed below the license text, it's
  Jan-Åke.

  So it should be:

,----
| Copyright: Jan-Åke Larsson <[EMAIL PROTECTED]>
|
| License:
|
| The source files for this package contain license headers like the
| following one taken from dvi.c:
`----

  Furthermore, debian/copyright is inconsistently encoded:  The first Å
  is UTF (at least my non-utf-aware terminal displays two characters),
  the second seems to be iso-whatever.

It is fixed now.

- debian/control:

  The short description isn't good english, the program doesn't "convert
  PNG", but "convert to PNG".  I would suggest "convert DVI files to PNG
  graphics".

Fixed.

It shouldn't be a large problem to fix any of this, and otherwise the
packaging looks very good, and I'm happy to sponsor it.

Could you please check the corrections:
http://varun.travisbsd.org/debian_packages/dvipng/dvipng_1.9-2.dsc

Regards
Varun


--
Varun Hiremath
Undergraduate Student,
Aerospace Engg. Department,
Indian Institute of Technology Madras,
Chennai, India
--------------------------------------------------
Homepage : http://varun.travisbsd.org

Reply via email to