Your message dated Fri, 19 Jan 2007 21:40:08 +0000 with message-id <[EMAIL PROTECTED]> and subject line Closing old reports has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: bugzilla Version: 2.16.7-7sarge1 Priority: critical Tags: patch sarge woody I sent this mail to the security team a while back and forwarded it upstream too. Since this bug is now public (https://bugzilla.mozilla.org/show_bug.cgi?id=305353), I'm opening up a ticket in the BTS for easier tracking of this issue. Notice that a DSA fixing this should also fix #321567. ------------------------------------------------------------------------- Hi there, Bugzilla (bugzilla_2.14.2-0woody4 and bugzilla_2.16.7-7sarge1) contains a script which is used to synchronise the bugzilla user database with the shadow password database called syncshadowdb. This script is intented to be run by the Bug Tracking System. The script uses temporary files in an unsafe way since it selects a name for the file based on PID and does not make any effort to determine if the file exists and if it is a symlink. A local user could use this to direct symlink attacks and overwrite files that the Bug Tracking System has access to. The attached (untested) patch, which uses File::Temp should fix this issue and prevent any symlink attacks. Regards Javier --- bugzilla-2.16.7/syncshadowdb.orig 2005-08-06 10:49:27.000000000 +0200 +++ bugzilla-2.16.7/syncshadowdb 2005-08-06 11:04:22.000000000 +0200 @@ -23,6 +23,7 @@ use diagnostics; use strict; +use File::Temp qw/tempfile/; use lib '/usr/share/bugzilla/lib'; @@ -238,7 +239,7 @@ } Verbose("Locking entire database"); SendSQL($query); - my $tempfile = "$tempdir/tmpsyncshadow.$$"; + my ($tfh, $tempfile) = tempfile("syncshadowdb.XXXXX", DIR => File::Spec->tmpdir, UNLINK => 1); Verbose("Dumping database to a temp file ($tempfile)."); my @ARGS = ("-u", $::db_user); if ($::db_pass) { push @ARGS, "-p$::db_pass" } ----- End forwarded message -----
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---This only affects Woody, which is depreciated. Closing. Neil -- * hermanr feels like a hedgehog having sex...
signature.asc
Description: Digital signature
--- End Message ---