On Tue, 9 Jan 2007, Joey Hess wrote:

David, it seems that there's a bug in the Grep implementation of the
MessageParser that can lead to a hang. See discussion at
http://bugs.debian.org/395268

I've found and fixed the problem. The issue was that Tassilo's test case
assumed that read_next_email would return some false value, when in fact
you are not supposed to call the method if end_of_file is true. i.e. he
did:

  while(my $email = $folder_reader->read_next_email()) {
    print $output $$email;
  }

instead of:

  while(!$folder_reader->end_of_file()) {
    my $email = $folder_reader->read_next_email();
    print $output $$email;
  }

His way seems reasonable, so I added (back in?) support for
it---read_next_email now returns undef on EOF. I'll be releasing 1.5000
very soon.

David

P.S. Please CC me on bug reports as soon as my module is obviously
involved. I probably could have saved several people some debugging
effort. (I've thanked them all in my changelog.)

_____________________________________________________________________
David Coppit                           [EMAIL PROTECTED]
The College of William and Mary        http://coppit.org/

"When the president does it that means that it is not illegal."
- Richard Nixon on domestic surveillance, 5/19/1977
"Do I have the legal authority to do this? And the answer is, absolutely."
- George W. Bush on domestic surveillance, 12/19/2005


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to