On Fri, Dec 15, 2006 at 12:14:02PM +0100, Raphael Hertzog wrote:
> I could reproduce the bug. It's locale-dependent. Using ru_RU.KOI8-R or
> ru_RU.UTF-8 allowed me to reproduce the bug.

Oh, but that makes it rather obvious.

Line 1418, src/workspace.c:

  strcpy(title, scr->workspaces[ws]->name);

title is defined as

  char title[MAX_WORKSPACENAME_WIDTH+1];

with (wmaker/src/wconfig.h)

  #define MAX_WORKSPACENAME_WIDTH  32

The ru_RU string for a new workspace is 'Рабочее пространство 1', which is 41
bytes long in UTF-8. Classic stack smash.

Just increase MAX_WORKSPACENAME_WIDTH, or stop using strcpy; both should fix
the problem.

/* Steinar */
-- 
Homepage: http://www.sesse.net/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to