Your message dated Fri, 08 Dec 2006 06:02:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#402079: fixed in cdck 0.5.2-3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: cdck
Version: 0.5.2-2
Severity: grave
Tags: patch
Justification: renders package unusable
Hi,
the sizes of the cdck 0.5.2-2 packages, as seen on packages.debian.org
[1] are suspiciously small on arm, powerpc and s390. Looking at the
buildd logs, those architectures get this warning during build:
cdck_main.cpp: In function 'int main(int, char**)':
cdck_main.cpp:36: warning: comparison is always true due to limited range of
data type
Line 36 in cdck_main.cpp is the while loop for option parsing:
char ch;
[...]
while ((ch = getopt(argc, argv, "?hivd:po:V"))!=-1) {
I believe that 'char ch' is unsigned rather than signed on the
architectures listed above, and the compiler optimizes away most of the
main program and the libraries because of this. The Arm Linux FAQ seems
to confirm this [2]. Indeed, if I explicitly specify 'unsigned char ch'
and test this on my i386, I get a smaller binary and the expected busy
loop in option parsing.
Based on this, I'm setting the severity to 'grave' although I haven't
been able to test this on arm/powerpc/s390 myself.
Trivial patch attached.
[1] http://packages.debian.org/unstable/utils/cdck
[2] http://www.arm.linux.org.uk/docs/faqs/signedchar.php
Cheers,
--
Niko Tyni [EMAIL PROTECTED]
--- src/cdck_main.cpp 2006/12/07 21:51:56 1.1
+++ src/cdck_main.cpp 2006/12/07 21:53:25
@@ -21,7 +21,7 @@
int main (int argc, char *argv[])
{
- char ch;
+ signed char ch;
char *program_name = (strchr(argv[0], '/') == NULL) ? argv[0] :
(strrchr(argv[0], '/') + 1);
bool verbose = false;
--- End Message ---
--- Begin Message ---
Source: cdck
Source-Version: 0.5.2-3
We believe that the bug you reported is fixed in the latest version of
cdck, which is due to be installed in the Debian FTP archive:
cdck_0.5.2-3.diff.gz
to pool/main/c/cdck/cdck_0.5.2-3.diff.gz
cdck_0.5.2-3.dsc
to pool/main/c/cdck/cdck_0.5.2-3.dsc
cdck_0.5.2-3_i386.deb
to pool/main/c/cdck/cdck_0.5.2-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
tony mancill <[EMAIL PROTECTED]> (supplier of updated cdck package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 7 Dec 2006 21:26:36 -0800
Source: cdck
Binary: cdck
Architecture: source i386
Version: 0.5.2-3
Distribution: unstable
Urgency: medium
Maintainer: gregor herrmann <[EMAIL PROTECTED]>
Changed-By: tony mancill <[EMAIL PROTECTED]>
Description:
cdck - verifies the quality of written CDs/DVDs
Closes: 402079
Changes:
cdck (0.5.2-3) unstable; urgency=medium
.
* apply signed char patch for arm, powerpc, and s390 (closes: #402079)
(thanks to Niko Tyni for supplying the patch)
* upload urgency set to medium due to bug severity on these arches
Files:
c4618a6a43b147bbb3bdaff17798752f 686 utils optional cdck_0.5.2-3.dsc
a84fd72416189d7b7848c7761709fccb 171441 utils optional cdck_0.5.2-3.diff.gz
9a3ad32ecbec88a26d6ce8112af3a4aa 34124 utils optional cdck_0.5.2-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFFePqepdwBkPlyvgMRAgTeAJ91XVuXlZDaiXFVZWvL4zr/Zi01SgCfSVEB
tQY1pvR3PWNqMI1hgY5YLgM=
=l/PU
-----END PGP SIGNATURE-----
--- End Message ---
