Hi Daniel, Daniel Kobras [2006-08-18 19:02 +0200]: > --- imagemagick-6.2.4.5.dfsg1.orig/coders/sgi.c > +++ imagemagick-6.2.4.5.dfsg1/coders/sgi.c > @@ -171,13 +171,13 @@ > q=pixels; > if (bytes_per_pixel == 2) > { > - for (i=0; i < (long) width; ) > + for ( ; ; ) > { > pixel=(unsigned long) (*p++) << 8; > pixel|=(*p++); > count=(ssize_t) (pixel & 0x7f); > i+=count;
BTW, this hunk looks wrong: You removed the initialization 'i=0' without adding a replacement. I'm not intimately familiar with the C specification, is a 'register long i' guaranteed to be initialized to 0? It would surprise me if that was true. For being on the safe side, the 'i=0' should be put back. > @@ -200,13 +200,13 @@ > } > return; > } > - for (i=0; i < (long) width; ) > + for ( ; ; ) > { > pixel=(unsigned long) (*p++); > count=(ssize_t) (pixel & 0x7f); > - if (count == 0) > - break; > i+=count; (same here) Thanks, Martin -- Martin Pitt http://www.piware.de Ubuntu Developer http://www.ubuntu.com Debian Developer http://www.debian.org In a world without walls and fences, who needs Windows and Gates?
signature.asc
Description: Digital signature