Your message dated Wed, 04 Oct 2006 03:44:07 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#387996: fixed in subversion 1.4.0-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: subversion
Version: 1.4.0
Severity: serious
Tags: patch
Justification: no longer builds from source

Hi,

I looked at the failing self tests. The first one is a bug in the
created wrapper. The basic problem is that in
svn_delta.c:_wrap_svn_txdelta_apply_wrapper() the value of temp3 is not
modified by svn_txdelta_apply_wrapper(), so the return is basically
random. In this case the stack is clear and svn_md5_digest_to_cstring()
returns a NULL, which rb_str_new2() doesn't like.
The easiest fix is to change the typemap in svn_types.swg so it can deal
with the NULL pointer. (BTW I tried returning Qnil here, but that
doesn't work well output_helper.)

The other two failures are a bug in the test itself, which simply take a
bit too much time on m68k, so I modified the test a little to accept a
small delay.

bye, Roman

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: m68k
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.4.30
Locale: LANG=de_DE.UTF-8, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
diff -ur subversion-1.4.0.org/subversion/bindings/swig/include/svn_types.swg subversion-1.4.0/subversion/bindings/swig/include/svn_types.swg
--- subversion-1.4.0.org/subversion/bindings/swig/include/svn_types.swg	2006-04-20 04:47:39.000000000 +0200
+++ subversion-1.4.0/subversion/bindings/swig/include/svn_types.swg	2006-09-15 02:41:36.000000000 +0200
@@ -542,7 +542,7 @@
 %typemap(ruby, argout, fragment="output_helper") unsigned char digest[ANY]
 {
   char *digest_string = (char *)svn_md5_digest_to_cstring($1, _global_pool);
-  $result = output_helper($result, rb_str_new2(digest_string));
+  $result = output_helper($result, rb_str_new2(digest_string ? digest_string : ""));
 }
 
 
@@ -554,7 +554,7 @@
 %typemap(ruby, argout, fragment="output_helper") unsigned char **digest
 {
   char *digest_string = (char *)svn_md5_digest_to_cstring(*$1, _global_pool);
-  $result = output_helper($result, rb_str_new2(digest_string));
+  $result = output_helper($result, rb_str_new2(digest_string ? digest_string : ""));
 }
 
 /* svn_md5_* functions takes const ones as input */

diff -ur subversion-1.4.0.org/subversion/bindings/swig/ruby/test/test_ra.rb subversion-1.4.0/subversion/bindings/swig/ruby/test/test_ra.rb
--- subversion-1.4.0.org/subversion/bindings/swig/ruby/test/test_ra.rb	2006-04-17 16:51:04.000000000 +0200
+++ subversion-1.4.0/subversion/bindings/swig/ruby/test/test_ra.rb	2006-09-15 03:06:43.000000000 +0200
@@ -212,10 +212,10 @@
     session = Svn::Ra::Session.open(@repos_uri, config, callbacks)
     result = nil
 
-    expect = [1, Time.now.to_s, @author]
+    expect = [1, Time.now, @author]
     gc_disable do
       editor, baton = session.commit_editor(log) do |rev, date, author|
-        result = [rev, date.to_s, author]
+        result = [rev, date, author]
       end
       editor.baton = baton
 
@@ -225,6 +225,7 @@
         GC.start
         editor.close_edit
       end
+      expect[1] = result[1] if result[1] >= expect[1] && result[1] < expect[1] + 10
       assert_equal(expect, result)
     end
   end
@@ -238,10 +239,10 @@
     session = Svn::Ra::Session.open(@repos_uri, config, callbacks)
     result = nil
 
-    expect = [1, Time.now.to_s, @author]
+    expect = [1, Time.now, @author]
     gc_disable do
       editor = session.commit_editor2(log) do |info|
-        result = [info.revision, info.date.to_s, info.author]
+        result = [info.revision, info.date, info.author]
       end
 
       root = editor.open_root(-1)
@@ -250,6 +251,7 @@
         GC.start
         editor.close_edit
       end
+      expect[1] = result[1] if result[1] >= expect[1] && result[1] < expect[1] + 10
       assert_equal(expect, result)
     end
   end

--- End Message ---
--- Begin Message ---
Source: subversion
Source-Version: 1.4.0-3

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive:

libapache2-svn_1.4.0-3_i386.deb
  to pool/main/s/subversion/libapache2-svn_1.4.0-3_i386.deb
libsvn-dev_1.4.0-3_i386.deb
  to pool/main/s/subversion/libsvn-dev_1.4.0-3_i386.deb
libsvn-doc_1.4.0-3_all.deb
  to pool/main/s/subversion/libsvn-doc_1.4.0-3_all.deb
libsvn-java_1.4.0-3_i386.deb
  to pool/main/s/subversion/libsvn-java_1.4.0-3_i386.deb
libsvn-javahl_1.4.0-3_all.deb
  to pool/main/s/subversion/libsvn-javahl_1.4.0-3_all.deb
libsvn-perl_1.4.0-3_i386.deb
  to pool/main/s/subversion/libsvn-perl_1.4.0-3_i386.deb
libsvn-ruby1.8_1.4.0-3_i386.deb
  to pool/main/s/subversion/libsvn-ruby1.8_1.4.0-3_i386.deb
libsvn-ruby_1.4.0-3_all.deb
  to pool/main/s/subversion/libsvn-ruby_1.4.0-3_all.deb
libsvn1_1.4.0-3_i386.deb
  to pool/main/s/subversion/libsvn1_1.4.0-3_i386.deb
python-subversion_1.4.0-3_i386.deb
  to pool/main/s/subversion/python-subversion_1.4.0-3_i386.deb
subversion-tools_1.4.0-3_all.deb
  to pool/main/s/subversion/subversion-tools_1.4.0-3_all.deb
subversion_1.4.0-3.diff.gz
  to pool/main/s/subversion/subversion_1.4.0-3.diff.gz
subversion_1.4.0-3.dsc
  to pool/main/s/subversion/subversion_1.4.0-3.dsc
subversion_1.4.0-3_i386.deb
  to pool/main/s/subversion/subversion_1.4.0-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Troy Heber <[EMAIL PROTECTED]> (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  3 Oct 2006 07:45:31 -0600
Source: subversion
Binary: libsvn-javahl libsvn1 libsvn-perl libsvn-doc libsvn-dev libsvn-ruby 
libapache2-svn libsvn-ruby1.8 libsvn-java python-subversion subversion-tools 
subversion
Architecture: source all i386
Version: 1.4.0-3
Distribution: unstable
Urgency: low
Maintainer: Peter Samuelson <[EMAIL PROTECTED]>
Changed-By: Troy Heber <[EMAIL PROTECTED]>
Description: 
 libapache2-svn - Subversion server modules for Apache
 libsvn-dev - Development files for Subversion libraries
 libsvn-doc - Developer documentation for libsvn
 libsvn-java - Java bindings for Subversion
 libsvn-javahl - Java bindings for Subversion (dummy package)
 libsvn-perl - Perl bindings for Subversion
 libsvn-ruby - Ruby bindings for Subversion (dummy package)
 libsvn-ruby1.8 - Ruby bindings for Subversion
 libsvn1    - Shared libraries used by Subversion
 python-subversion - Python bindings for Subversion
 subversion - Advanced version control system
 subversion-tools - Assorted tools related to Subversion
Closes: 387396 387901 387996 388733
Changes: 
 subversion (1.4.0-3) unstable; urgency=low
 .
   [ Peter Samuelson ]
   * patches/ruby-test-ra-race: New patch for another testsuite race
     discovered on m68k.
   * patches/ruby-typemap-digest: New patch to fix a m68k failure, quite
     possibly the same failure we've seen sporadically on other arches
     in the past.  Thanks to Roman Zippel.  (Closes: #387996)
   * Tighten libsvn0 -> libapr0 dependency to express the need for
     libaprutil to be linked to libdb4.4.  (Closes: #387396)
   * rules: sed *.la to change internal *.la references to -l form.
     (Closes: #388733)
   * control,rules: Reinstate libsvn-javahl as a dummy package, for
     sarge upgrades.  (Closes: #387901)
   * control,rules: Disable Java on hurd-i386, requested by Cyril Brulebois.
   * Build with apache 2.2 / apr1 / aprutil1 again, now that apache 2.2 is
     going into unstable.
   * libapache2-svn.postinst: Do not enable the dav_fs module: not needed
     for a Subversion server.
 .
   [ Troy Heber ]
   * debian/control clean up of Maintainer and Uploaders fields to reflect the
     current team.
Files: 
 c76a3146adb3cd98cf3742cc3be58055 1224 devel optional subversion_1.4.0-3.dsc
 9c54f8cdd81f4e71078b3bdca1082753 47606 devel optional 
subversion_1.4.0-3.diff.gz
 9314d97679f55ce70cf84ea658109c81 1065414 doc extra libsvn-doc_1.4.0-3_all.deb
 b9fe2a2f59b61262beaec5b172113d93 128902 admin extra 
subversion-tools_1.4.0-3_all.deb
 7f9178b04cd6a60d532f929cda79c179 770 devel optional 
libsvn-javahl_1.4.0-3_all.deb
 e862482defabe44696c9392148e8d1b9 738 devel optional libsvn-ruby_1.4.0-3_all.deb
 f6b4875e758724494ccf3c3e37834461 1012752 devel optional 
subversion_1.4.0-3_i386.deb
 594963e7fa9bb53bf05999e82f1fa61c 583490 libs optional libsvn1_1.4.0-3_i386.deb
 80df935429d0872f441300e395c28cdb 817226 libdevel extra 
libsvn-dev_1.4.0-3_i386.deb
 1641894c8d9b54e85e1468f3f18bd42c 123866 net optional 
libapache2-svn_1.4.0-3_i386.deb
 7506adf7f397b8c8a777508fee6d27a1 492580 python optional 
python-subversion_1.4.0-3_i386.deb
 f041cf01fb5a5bb4df949869367a5686 201318 devel optional 
libsvn-java_1.4.0-3_i386.deb
 f91211e4df68cc2103c92a91dde2ac6d 794924 perl optional 
libsvn-perl_1.4.0-3_i386.deb
 f1e7259e13f6ebf220c673aecb46d274 376230 devel optional 
libsvn-ruby1.8_1.4.0-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFIoLSQOr9C+GfGI4RAozOAKCh3VR+sPOMmCg2RHFh92oMa7B9HgCcCWLT
Fa4JeXFDef1yOhlKdF/ghS0=
=u2I4
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to