On Sat, 14 Jun 2025 14:49:05 +0530 Pirate Praveen <prav...@debian.org>
wrote:
> On Sat, 14 Jun 2025 14:38:06 +0530 Pirate Praveen <prav...@debian.org>
> wrote: > I'm not sure if this will work as expected as it needs to be
> package
> > name.tmpfile I think (so gitaly-installer.tmpfile)
> I can see the package has correctly installed tmpfiles configuration
>
> /usr/lib/tmpfiles.d/gitaly-installer.conf
>
> But this hard codes username, so will break if users select a username
> during installation (usually people prefer git as username instead of
> gitlab).
>
> So we need to read the username value from debconf database and use
> that. See gitlab package for how to do it. Read the debconf manual too.
>

Hey,

I can already see that the variable GITLAB_USER is being replaced by
gitlab_user value from debconf db during installation

vivekdeb@debian-sid $ grep GITLAB_USER debian/*


debian/gitlab-common.postinst:    sed -i "s/GITLAB_USER/${gitlab_user}/"
${gitlab_common_tmpfiles_private}

> Please test it with a different username selected during gitlab-common
> installation and see if the tmpfiles configuration reflects the selected
> username.

I'll have to test it to identify what is going wrong
-- 
Regards,

Vivek K J
Debian Maintainer
---------------------------------------------------------------------------
                                                                 .''`.
Personal Website:  https://vivekkj.in                           : :'  :
GPG Key: D017 9263 E202 0E40 7157  4073 A5FF 4BB3 EA53 C5DF     `. `'`
                                                                  `-

Attachment: OpenPGP_0xA5FF4BB3EA53C5DF.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to