Hi Sean, Sean Whitton <spwhit...@spwhitton.name> writes:
> Hello, > > On Sat 24 May 2025 at 05:53pm -07, Xiyue Deng wrote: > >> Indeed. Policy seems to confirm the assumptions this solution requires. >> >> I have implemented this in this RM[1], and run in my docker instance >> several times to test it and it seems working. Please review. >> >> [1] https://salsa.debian.org/rlb/deb-emacsen-common/-/merge_requests/3 > > We need Rob's review, but a couple of very general comments: > > - maintainer scripts are meant to be idempotent, i.e., if they are > interrupted at any point and restarted, they should still do the right > thing. I think this will be true of your scripts, but did you think > about it? > Yes. My additions to the preinst/postinst are idempotent as long as the emacs-{install,remove} scripts are idempotent, which I think is the case. > - I would suggest using find(1) instead of parsing the output of ls(1). > Ack. I use "$(find "${DIR}" -type f -exec basename "{}" \;)" to get the file names without path which is a bit long. Do let me know if there is a better way. MR updated. PTAL. > -- > Sean Whitton -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
