Hi David, David Bremner <da...@tethera.net> writes:
> Xiyue Deng <manp...@gmail.com> writes:
>
>
>>>> Still, I think it's better to have this fixed so that it works in all
>>>> cases. I have tested a fix in the "bug#1104178" branch to be working.
>>>> The diff can be seen here[1]. Please review.
>
> Is it sufficient to check the top level? what if there is deeper nested
> directories? Apologies if I missed some context.
>
Before 2.1.1, the install script only creates symlinks for everything on
the top level (see code for release 2.1.1[1]). Therefore I think
handling top level should be sufficient.
> I wondered about two slightly more aggressive solutions.
>
> 1) find "${elc_dir}" -type l -delete
>
> 2) rm -rf "${elc_dir}"
>
> Am I wrong in thinking ${elc_dir} only contains artifacts generated by
> maintainer scripts? In that case it should be ok to just blow it away,
> right?
>
I think what you said is true, though that's more like the work of the
remove script, which basically does this already. Wiping everything on
every install/upgrade sounds like an overkill to me. On the other hand,
it doesn't affect correctness, and should still be fast enough as
everything is basically a symlink. I don't have a strong preference.
Let me know what you think.
[1]
https://salsa.debian.org/emacsen-team/dh-elpa/-/blob/debian/2.1.1/helper/install?ref_type=tags#L53
--
Regards,
Xiyue Deng
signature.asc
Description: PGP signature
