On Tue, Apr 22, 2025 at 12:11:27PM +0200, Gregor Riepl wrote:
Those all look like rounding errors (probably due to x87 excess
precision, since they only happen on i386). This suggests that the
appropriate response is either to ignore these tests on i386, or
possibly (the graph object output by gdf_to_nx has (x: float, y:
float) node keys, so rounding issues can potentially break
retrieving individual nodes/edges) to remove this package on i386.
Your assessment of the situation is very likely correct, since the errors are
very small.
The (IMHO) correct fix should be to replace all exact comparisons with
approximative ones. I don't think subtle precision errors warrant removal of
the package on i386, since this a very common and well-known issue of floating
point math.
Agreed.
I proposed https://github.com/pysal/momepy/pull/698 upstream to fix two
out of the three tests, and
https://salsa.debian.org/openstack-team/third-party/python-momepy/-/merge_requests/1
to cherry-pick that patch into Debian and to skip the third test.
Thomas, could you have a look, please?
Thanks,
--
Colin Watson (he/him) [cjwat...@debian.org]
