Your message dated Tue, 15 Apr 2025 18:19:46 +0000
with message-id <e1u4kss-009nfy...@fasolo.debian.org>
and subject line Bug#1103229: fixed in ltt-control 2.13.15-2
has caused the Debian Bug report #1103229,
regarding ltt-control:FTBFS:build failed(error: 'health_state' undeclared)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1103229: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1103229
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: ltt-control
Version: 2.13.15-1
Severity: serious
Tags: FTBFS, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
Dear ltt-control maintainer,
The package ltt-control build failed on riscv.The crucial buildd log below:
```
make[4]: Entering directory
'/build/reproducible-path/ltt-control-2.13.15/src/common/health'
/bin/bash ../../../libtool --tag=CC --mode=compile gcc
-DHAVE_CONFIG_H -I../../../include -I../../../include -I../../../src
-I../../../src -include config.h -I/usr/include/riscv64-linux-gnu
-I/usr/include/riscv64-linux-gnu -Wdate-time -D_FORTIFY_SOURCE=2
-Wall -Wno-incomplete-setjmp-declaration -Wdiscarded-qualifiers
-Wmissing-declarations -Wmissing-prototypes -Wmissing-parameter-type
-Wold-style-definition -Wstrict-prototypes -Wshadow
-fno-strict-aliasing -pthread -g -O2
-Werror=implicit-function-declaration
-ffile-prefix-map=/build/reproducible-path/ltt-control-2.13.15=.
-fstack-protector-strong -Wformat -Werror=format-security -c -o
health.lo health.c
libtool: compile: gcc -DHAVE_CONFIG_H -I../../../include
-I../../../include -I../../../src -I../../../src -include config.h
-I/usr/include/riscv64-linux-gnu -I/usr/include/riscv64-linux-gnu
-Wdate-time -D_FORTIFY_SOURCE=2 -Wall
-Wno-incomplete-setjmp-declaration -Wdiscarded-qualifiers
-Wmissing-declarations -Wmissing-prototypes -Wmissing-parameter-type
-Wold-style-definition -Wstrict-prototypes -Wshadow
-fno-strict-aliasing -pthread -g -O2
-Werror=implicit-function-declaration
-ffile-prefix-map=/build/reproducible-path/ltt-control-2.13.15=.
-fstack-protector-strong -Wformat -Werror=format-security -c health.c
-fPIC -DPIC -o .libs/health.o
health.c: In function 'health_register':
health.c:266:9: error: 'health_state' undeclared (first use in this function)
266 | health_state.last = 0;
| ^~~~~~~~~~~~
health.c:266:9: note: each undeclared identifier is reported only once
for each function it appears in
At top level:
cc1: note: unrecognized command-line option
'-Wno-incomplete-setjmp-declaration' may have been intended to silence
earlier diagnostics
make[4]: *** [Makefile:581: health.lo] Error 1
make[4]: Leaving directory
'/build/reproducible-path/ltt-control-2.13.15/src/common/health'
make[3]: *** [Makefile:1056: all-recursive] Error 1
make[3]: Leaving directory
'/build/reproducible-path/ltt-control-2.13.15/src/common'
make[2]: *** [Makefile:557: all-recursive] Error 1
make[2]: Leaving directory '/build/reproducible-path/ltt-control-2.13.15/src'
make[1]: *** [Makefile:668: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/ltt-control-2.13.15'
dh_auto_build: error: make -j4 returned exit code 2
```
The full buildd log is here:
https://buildd.debian.org/status/fetch.php?pkg=ltt-control&arch=riscv64&ver=2.13.15-1&stamp=1744670366&raw=0
My solution to this issue:
The error occurs specifically in the health_register function where the
code attempts to access this TLS variable directly using its name
(health_state.last = 0; etc.).However, other parts of health.c (e.g., in
health_unregister) and inline functions within <lttng/health-internal.h>
access the same TLS variable using the URCU_TLS(health_state) macro (e.g.,
URCU_TLS(health_state).flags).Accessing the variable through the URCU_TLS()
macro works consistently across the codebase and presumably abstracts away
these architecture-specific details.The fix is to modify the
health_register function in src/common/health/health.c to consistently use
the URCU_TLS() macro for accessing the health_state variable, aligning its
usage with the rest of the code.I have tested this solution locally,and it
works well.The debpatch is in the attachment.Please let me know whether
this solution can be accepted.
Gui-Yue
Best Regards
fix_ltt-control_compile_on_riscv_error.patch
Description: Binary data
--- End Message ---
--- Begin Message ---
Source: ltt-control
Source-Version: 2.13.15-2
Done: Michael Jeanson <mjean...@debian.org>
We believe that the bug you reported is fixed in the latest version of
ltt-control, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1103...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Jeanson <mjean...@debian.org> (supplier of updated ltt-control package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 15 Apr 2025 13:55:11 -0400
Source: ltt-control
Architecture: source
Version: 2.13.15-2
Distribution: unstable
Urgency: medium
Maintainer: Jon Bernard <jbern...@debian.org>
Changed-By: Michael Jeanson <mjean...@debian.org>
Closes: 1103229
Changes:
ltt-control (2.13.15-2) unstable; urgency=medium
.
* [de293ed] Add patch to fix build on riscv64 and m68k (Closes: #1103229)
Checksums-Sha1:
0486154f109ecfd260c51e63172ee76ca5dfabbb 2721 ltt-control_2.13.15-2.dsc
f5979aa10fd295fa21682db02a292a80b52b86c4 1934955
ltt-control_2.13.15.orig.tar.bz2
93aba9dc38b97e9e665112c11f1981f78cccc7f6 833
ltt-control_2.13.15.orig.tar.bz2.asc
9b888a1bec4967ea7bb719219a4186cc786b4ad9 23164
ltt-control_2.13.15-2.debian.tar.xz
c3bb9fbbfa634777c1e56f891df7defc3deb35ac 7840
ltt-control_2.13.15-2_source.buildinfo
Checksums-Sha256:
895504c56b718b5378a5fd74a3287a8fa5764111090ab2505311db6b7abe7675 2721
ltt-control_2.13.15-2.dsc
96ea42351ee112c19dad9fdc7aae93b583d9f1722b2175664a381d2d337703c4 1934955
ltt-control_2.13.15.orig.tar.bz2
0656e055db6bb3c54f15ef2747910beeb3992b3e0f738f02d44b8aed57d5fe7e 833
ltt-control_2.13.15.orig.tar.bz2.asc
4a8062d26f208d6918c2a63525278ae6dea13de1f219b283744f77f57d42ec6f 23164
ltt-control_2.13.15-2.debian.tar.xz
2ae77e8d103a74faad163ad197979970b51f4e2f8174b9001385702126a10d8f 7840
ltt-control_2.13.15-2_source.buildinfo
Files:
b4dc26cc58535d31d4dfe452d90e551b 2721 libs optional ltt-control_2.13.15-2.dsc
77b85bdbaa0ae6ba10cbd9df0f066400 1934955 libs optional
ltt-control_2.13.15.orig.tar.bz2
5e9b8909f0fdc4e9a0dee6a50084221d 833 libs optional
ltt-control_2.13.15.orig.tar.bz2.asc
0930ab2a13bf0c566844a0fe5f0efc9b 23164 libs optional
ltt-control_2.13.15-2.debian.tar.xz
ea8ed960a57e3d1bc3e5e0e77753d998 7840 libs optional
ltt-control_2.13.15-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCgAyFiEEmGYkMkK2Qid54gtihlYfRSGA/P4FAmf+nfYUHG1qZWFuc29u
QGRlYmlhbi5vcmcACgkQhlYfRSGA/P4haw/8DbHFUKVKu74b9DfBmRLZcW50Di8l
770BKueBOCdM9ntlwx+rKuuCsZrXa3IV+gCUArqSUnpWzP7O2DfR68k/7o5j5uDD
qIAdl307IYUrKu4jg/jq3myFaq4ZbHKdtz5C+s8iimeQpFzHygmQ0gWm/8l3PCkM
BbA5T++t45bmpKhStuyfPAi0wcpx4jlLMSP/59pSOtcLlELyi3jZKjaK0D2TYsaQ
bDFcgdRbKr8gayzLeEywWK6E2xHGZmji5hrxs2e4ffYM4WyxuB3HRTHyk6LuYim1
jpbqjWmEtJZeZS4U9PXiyjvzQLB6nDhKgq35f0s4HpaNOdY06IBZdu9QgOdxXt5q
EC1IQZ5XyrxgCjsf3WY4Yw9VcOJu7PHXW0ckR+h7RX8dQURC19tGCjFGDfbtIhh2
pLJKk2No0D8mwckkNmd0UU+TmAcWXKbL/7OlB+OrKQw4EiOXc25iKG3O66hvX7OF
fYfXgcwdbnDMPc4d7vycWCy8W8Yq8E7jFgnq1z7rLBfLB/3JQMC2P12no7CF0b5I
jicmujSf4H00NDXfVWXnI5kHUTqHqQPawI2C2t2QGTsWYySSDMUfZkaaCz6euzH6
wksEOpz0fcqekEU/1tM0WpA/2pyBsA7Gx0X4J3BBHx/uNv94KcSt0JqHKwMkBc3g
GLcx4YigNwolxpc=
=KU8S
-----END PGP SIGNATURE-----
pgpO6btlZ6lZW.pgp
Description: PGP signature
--- End Message ---
