On Thu, Apr 10, 2025 at 07:21:03PM +0200, Paul Gevers wrote:
> On Wed, 06 Dec 2023 02:05:07 +0200 Adrian Bunk <b...@debian.org> wrote:
> > For the usual case where debug symbols are only used
> > when debugging in a debugger this is no problem,
> > but valgrind-dbg is (like libc6-dbg) an exception:
> >
> > Package: valgrind
> > Recommends: valgrind-dbg, gdb
> >
> > https://sources.debian.org/src/valgrind/1%3A3.20.0-2/debian/README.Debian/#L11-L16
> >
> > Debian's valgrind package comes stripped of any debug symbols, which are
> > provided by the valgrind-dbg package. Note that it's recommended to
> > install
> > such package because without those symbols valgrind may generate less
> > helpful error messages in certain situations, or not work at all.
>
> Do you agree with the submitter of this bug that the lack of debug symbols
> available via Recommends is a release critical bug? I'm not an experienced
> valgrind user, but with my Release Team member hat on, this looks a bit
> exaggerated.
(I believe the RC policy includes unavailable packages in
Recommends: ...)
> Hope to hear your opinion.
>
> Without an exception for the freeze policy, fixing this bug by reintroducing
> the valgrind-dbg package is going to be extremely tight, given that it has
> to pass NEW and that the window for new binary packages closes on
> 2025-04-15.
If the debug symbols are as relevant as the README claims, the
obvious solution is to include them in the main package.
Possible debdiff attached.
Chris
diff -Nru valgrind-3.24.0/debian/changelog valgrind-3.24.0/debian/changelog
--- valgrind-3.24.0/debian/changelog 2025-01-22 20:29:49.000000000 +0100
+++ valgrind-3.24.0/debian/changelog 2025-04-13 11:14:03.000000000 +0200
@@ -1,3 +1,12 @@
+valgrind (1:3.24.0-3) unstable; urgency=medium
+
+ * Team upload.
+
+ [ Chris Hofstaedtler ]
+ * Do not strip valgrind
+
+ -- Chris Hofstaedtler <z...@debian.org> Sun, 13 Apr 2025 11:14:03 +0200
+
valgrind (1:3.24.0-2) unstable; urgency=medium
* Remove Emanuele Rocca from Uploaders per request from Emanuele.
diff -Nru valgrind-3.24.0/debian/control valgrind-3.24.0/debian/control
--- valgrind-3.24.0/debian/control 2025-01-22 17:51:48.000000000 +0100
+++ valgrind-3.24.0/debian/control 2025-04-13 11:13:04.000000000 +0200
@@ -22,7 +22,7 @@
Architecture: amd64 arm64 armhf i386 mips mipsel mips64 mips64el powerpc ppc64 ppc64el s390x
Depends: ${misc:Depends}, ${shlibs:Depends}, libc6-dbg
Suggests: valgrind-mpi, kcachegrind
-Recommends: valgrind-dbg, gdb, python3
+Recommends: gdb, python3
Breaks: valgrind-dev
Replaces: valgrind-dev
Description: instrumentation framework for building dynamic analysis tools
diff -Nru valgrind-3.24.0/debian/README.Debian valgrind-3.24.0/debian/README.Debian
--- valgrind-3.24.0/debian/README.Debian 2025-01-21 22:19:10.000000000 +0100
+++ valgrind-3.24.0/debian/README.Debian 2025-04-13 11:12:53.000000000 +0200
@@ -8,13 +8,6 @@
-- Alessandro Ghedini <gh...@debian.org> Sun, 05 Nov 2014 00:00:00 +0100
- Debian's valgrind package comes stripped of any debug symbols, which are
- provided by the valgrind-dbg package. Note that it's recommended to install
- such package because without those symbols valgrind may generate less
- helpful error messages in certain situations, or not work at all.
-
- -- Alessandro Ghedini <gh...@debian.org> Sun, 09 Mar 2014 00:00:00 +0100
-
Debian's valgrind package ships with a suppression file named "debian.supp"
along with upstream's "default.supp", under /usr/lib/valgrind. Note though
that by default, valgrind only loads "default.supp".
diff -Nru valgrind-3.24.0/debian/rules valgrind-3.24.0/debian/rules
--- valgrind-3.24.0/debian/rules 2025-01-21 22:19:10.000000000 +0100
+++ valgrind-3.24.0/debian/rules 2025-04-13 11:12:39.000000000 +0200
@@ -29,7 +29,7 @@
dh_shlibdeps -Xdebian/valgrind/usr/libexec/valgrind/getoff-x86-linux # fixes #762386
override_dh_strip:
- dh_strip --dbgsym-migration='valgrind-dbg (<< 1:3.19.0-2~)'
+ : # valgrind needs its own debug symbols to produce better error messages and/or to work at all
override_dh_dwz:
: # do nothing for now
diff -Nru valgrind-3.24.0/debian/valgrind.lintian-overrides valgrind-3.24.0/debian/valgrind.lintian-overrides
--- valgrind-3.24.0/debian/valgrind.lintian-overrides 2025-01-21 22:19:10.000000000 +0100
+++ valgrind-3.24.0/debian/valgrind.lintian-overrides 2025-04-13 11:14:03.000000000 +0200
@@ -33,3 +33,24 @@
valgrind: shared-library-lacks-prerequisites [usr/libexec/valgrind/vgpreload_massif-x86-linux.so]
valgrind: shared-library-lacks-prerequisites [usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so]
valgrind: shared-library-lacks-prerequisites [usr/libexec/valgrind/vgpreload_memcheck-x86-linux.so]
+valgrind: unstripped-binary-or-object [usr/bin/valgrind-di-server]
+valgrind: unstripped-binary-or-object [usr/bin/valgrind-listener]
+valgrind: unstripped-binary-or-object [usr/bin/valgrind.bin]
+valgrind: unstripped-binary-or-object [usr/bin/vgdb]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/cachegrind-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/callgrind-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/dhat-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/drd-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/exp-bbv-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/getoff-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/helgrind-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/lackey-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/massif-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/memcheck-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/none-arm64-linux]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_core-arm64-linux.so]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_dhat-arm64-linux.so]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_drd-arm64-linux.so]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_helgrind-arm64-linux.so]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_massif-arm64-linux.so]
+valgrind: unstripped-binary-or-object [usr/libexec/valgrind/vgpreload_memcheck-arm64-linux.so]
diff -Nru valgrind-3.24.0/debian/valgrind-mpi.lintian-overrides valgrind-3.24.0/debian/valgrind-mpi.lintian-overrides
--- valgrind-3.24.0/debian/valgrind-mpi.lintian-overrides 1970-01-01 01:00:00.000000000 +0100
+++ valgrind-3.24.0/debian/valgrind-mpi.lintian-overrides 2025-04-13 11:14:03.000000000 +0200
@@ -0,0 +1 @@
+valgrind-mpi: unstripped-binary-or-object [usr/lib/aarch64-linux-gnu/valgrind/libmpiwrap-arm64-linux.so]
