Your message dated Sun, 06 Apr 2025 14:38:55 +0000
with message-id <e1u1r9d-00e23v...@fasolo.debian.org>
and subject line Bug#1084831: fixed in rheolef 7.2-4
has caused the Debian Bug report #1084831,
regarding rheolef FTBFS with MPICH as default
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1084831: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084831
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: rheolef
Version: 7.2-3
Severity: serious
Tags: ftbfs patch

https://buildd.debian.org/status/fetch.php?pkg=rheolef&arch=i386&ver=7.2-3%2Bb4&stamp=1728449821&raw=0

...
checking for mpirun... /usr/bin/mpirun
checking for mpi style... no
checking for mpi includes... 
checking for libmpi... -lmpi
checking for mpi.h... no
checking for boost/mpi.hpp... no
...
In file included from ../../include/rheolef/dis_cpu_time.h:83,
                 from dis_cpu_time.cc:21:
../../include/rheolef/communicator.h:112:25: error: expected initializer before 
'size'
  112 | inline int communicator size() const { return 1; }
      |                         ^~~~
../../include/rheolef/communicator.h:113:25: error: expected initializer before 
'rank'
  113 | inline int communicator rank() const { return 0; }
      |                         ^~~~
make[4]: *** [Makefile:788: dis_cpu_time.lo] Error 1


OpenMPI is no longer available on 32 bit,
32 bit architectures where therefore switched to MPICH.

The attached patch makes the MPICH detection work.

This is a minimal fix, a proper fix would involve
replacing a lot of the manual detection with pkg-config.
Description: HACK: Fix the build with MPICH
 - "mpirun.mpich --help" output no longer contains "MPICH1 compat"
 - use pkg-config to find multiarchheaders
Author: Adrian Bunk <b...@debian.org>

--- rheolef-7.2.orig/config/acinclude.m4
+++ rheolef-7.2/config/acinclude.m4
@@ -1794,7 +1794,7 @@ AC_DEFUN([RHEO_CHECK_MPI],
         if    test `$MPIRUN --allow-run-as-root --help 2>&1 | grep "Open.*MPI" 
| wc -l` -ge 1 \
            || test `$MPIRUN --help --allow-run-as-root 2>&1 | grep "Open.*MPI" 
| wc -l` -ge 1; then
           rheo_recognized_mpi=openmpi
-        elif test `$MPIRUN --help 2>&1 | grep 'MPICH1 compat' | wc -l` -ge 1; 
then
+        elif test `$MPIRUN --help 2>&1 | grep 'MPICH' | wc -l` -ge 1; then
           rheo_recognized_mpi=mpich2
         elif test `$MPIRUN -h 2>&1 | grep 'mpich/bin' | wc -l` -ge 1; then
           rheo_recognized_mpi=mpich1
@@ -1808,8 +1808,9 @@ AC_DEFUN([RHEO_CHECK_MPI],
            LDADD_MPI="-L/usr/lib/mpich/lib -lpmpich++ -lmpich -lpthread -lrt"
            ;;
           mpich2)
-           INCLUDES_MPI="-I/usr/include/mpich2"
-           LDADD_MPI="-lmpichcxx -lmpich -lpthread -lrt"
+           PKG_CHECK_MODULES(MPICH, [mpich])
+           INCLUDES_MPI="$MPICH_CFLAGS"
+           LDADD_MPI="-lmpichcxx $MPICH_LIBS"
            ;;
           openmpi)
             MPIRUN="mpirun --hostfile \${top_builddir}/config/hostfile.txt"

--- End Message ---
--- Begin Message ---
Source: rheolef
Source-Version: 7.2-4
Done: Pierre Saramito <pierre.saram...@imag.fr>

We believe that the bug you reported is fixed in the latest version of
rheolef, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1084...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pierre Saramito <pierre.saram...@imag.fr> (supplier of updated rheolef package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 1 Apr 2025 16:03:04 +0200
Source: rheolef
Architecture: source
Version: 7.2-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<debian-science-maintain...@lists.alioth.debian.org>
Changed-By: Pierre Saramito <pierre.saram...@imag.fr>
Closes: 1041188 1084831
Changes:
 rheolef (7.2-4) unstable; urgency=medium
 .
   [ Pierre Saramito ]
   * d/patches
     - mpich.patch: fix for FTBFS with mpich as default (Closes: #1084831)
       thanks to Adrian Bunk <b...@debian.org>
     - buildflags.patch: configure.ac respects debug and optim CXXFLAGS
     - communicator.patch: c++ typos fix in communicator.h for arch=i386
   * d/rules
     - dpkg-buildflags debug and optim CXXFLAGS are preserved (Closes: #1041188)
   * d/control
     - Build-Depends: gnuplot-nox instead of gnuplot
     - Recommends:    gnuplot-qt  instead of gnuplot
   * d/rheolef.lintian-overrides
     d/librheolef-dev.lintian-overrides
     - attempt to avoid groff artifacts of recent releases
Checksums-Sha1:
 52b11164507a87d7f8ae2d140d03fb3ecf3fc77f 2615 rheolef_7.2-4.dsc
 ed81a90b669467c65dec82009025d5f0ba03613a 11576 rheolef_7.2-4.debian.tar.xz
 2cdad3de8a8b4d167f623ecef56e262f2db37ef0 19865 rheolef_7.2-4_source.buildinfo
Checksums-Sha256:
 02062ba78884c70cb7756cb8280a06024bc3677a7032dc8d7d95b815d6a8b801 2615 
rheolef_7.2-4.dsc
 b391f064e6b02d4fc3c7389c1eed5738fa5bd75fdc14dfe0f437cc67a7cd8f6f 11576 
rheolef_7.2-4.debian.tar.xz
 6fde213eb5d6f9dc6cb5411814484072e7ba3f1dbe0aff0c3b788303f251dcab 19865 
rheolef_7.2-4_source.buildinfo
Files:
 892459789ca6c0403be26424212a7848 2615 math optional rheolef_7.2-4.dsc
 07c227660597e9f73d8ef44669babf81 11576 math optional 
rheolef_7.2-4.debian.tar.xz
 8bb17c6d8ccb96b82c2262a7b3668961 19865 math optional 
rheolef_7.2-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEu71F6oGKuG/2fnKF0+Fzg8+n/wYFAmfykAIACgkQ0+Fzg8+n
/wblxBAAg77LUDdHfnPW0ztEQY/O3MNt2uzCimPwzILI3vHjQN40vQ+kzXfm80pc
hAkIpTyC9YMfQx7NfTdeek2q88XGbgLZYP8ANtYCAcr/KVjc8wg+7lOprmStBTf7
ioL3YEz58rkzjNE1NUG1s5oX8b/aMkmIVdhscJ8AX+EnvJ30lJbKIi4uj73OWuBv
bPF3nE7JuS2sRT9IkFu1QyOig8rcVsGgj64SkehVxmJBKOMq5cCxRbq+M06EdQr2
k+TQB/NgQfZ82gM/ZSyKarmqOZYOMdlN13ugZP3wVVfvaut+UI+SSiqgKvV1wdr1
0XSselo5JB6ximHzX99ruUP0LWdfrh+hNJ0RRARw3SCmrPeDtxxNikzboW3IZS52
1oe/PdoLB1UkyB1pWNhbtG58Db5155/Dh4qzo6OfWGLfPN0E3UHde2ZAfIo+m/BQ
fCj6r7WsWbXc6fRdhvY6Lm6npjymFg+yLHxjGErW1/IB8J3+vFdJ9Z211zniZfl6
+h6+erJNvUZqs0nfFSQLUrLeiLRPOxCql1+MKfhIAR5iwNBtPuAgGvh+sFg2/zjc
7RLqY6u85TKHDhkGUoU3ihKgr5b1XYPYJtxvyXu5g+xcrxgFxFn5VXIg/q3KgnM/
vEa+OQTh7S3QVIxIw/IFbOZdI0TgVIFcFAmiaRaoxQoCHySODyA=
=7d5o
-----END PGP SIGNATURE-----

Attachment: pgpzaDb5KiQlw.pgp
Description: PGP signature


--- End Message ---

Reply via email to