Hi Santiago,
Apologies for not replying earlier. I was busy taking care of
openstructure and its reverse dependencies. I use it in my dayjob, hence
the priority.
On 2025-04-01 13:52, Santiago Vila wrote:
Note: I think autopkgtest is very smart and it would be possible to skip
tests
conditionally with some ifeqs in debian/rules, as autopkgtest reads
debian/rules.
I see you did that in 2.6.1-5 - thanks!
My only concern is that currently it's everything together:
# Skip tests requiring network connection, also flaky tests and ones
requiring GPU
export PYBUILD_TEST_ARGS = -k 'not test_citeseer and not test_enzymes
and not test_mutag and not _on_cora and not test_asap and not
test_feature_store and not test_two_hop and not test_graph_unet and not
test_spspmm and not test_add_metapaths and not test_type_repr'
I would try to split them like this for clarity, but I don't know which
tests belong to which
category:
# network tests
SKIP_TESTS := "not etc"
# flaky tests
SKIP_TESTS += "and not etc"
# GPU tests
SKIP_TESTS += "and not etc"
If you know and tell the categories they belong I could take care of
everything else.
This would be a very elegant solution. Alas, I do not recall the
categories myself. One could un-skip all the tests and check the reasons
for failures to class them, but I do not think I will have time for that
until soft freeze commences.
Thanks a lot for unblocking pytorch-geometric!
Andrius
