Your message dated Mon, 10 Mar 2025 23:06:21 +0000
with message-id <e1trmct-001mql...@fasolo.debian.org>
and subject line Bug#1100050: fixed in osmocom-dahdi-linux 
0.0~git20241003.b2ea348-4
has caused the Debian Bug report #1100050,
regarding osmocom-dahdi-dkms: install fails because of uninterpreted 
#MODULE_VERSION# in dkms.conf
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1100050: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1100050
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: osmocom-dahdi-dkms
Version: 0.0~git20241003.b2ea348-3
Severity: grave
Justification: renders package unusable
X-Debbugs-Cc: gag...@debian.org

Dear Maintainer,

When trying to install the osmocom-dahdi-dkms package on unstable, the
build of the modules fail. This is because the dkms.conf file in not
located in the correct location. The #MODULE_VERSION# string not being
interpreted by dh_dkms:

        $ dpkg -L osmocom-dahdi-dkms
        /.
        /usr
        /usr/share
        /usr/share/doc
        /usr/share/doc/osmocom-dahdi-dkms
        /usr/share/doc/osmocom-dahdi-dkms/LICENSE.firmware
        /usr/share/doc/osmocom-dahdi-dkms/README
        /usr/share/doc/osmocom-dahdi-dkms/changelog.Debian.gz
        /usr/share/doc/osmocom-dahdi-dkms/copyright
        /usr/src
        /usr/src/osmocom-dahdi-#MODULE_VERSION#
        /usr/src/osmocom-dahdi-#MODULE_VERSION#/dkms.conf
        /usr/src/osmocom-dahdi-0.0~git20241003.b2ea348
        /usr/src/osmocom-dahdi-0.0~git20241003.b2ea348/Makefile
        ...

This regression seems to be coming from this commit in the salsa
repository of the source package:

        commit 2b4c1196b441237bb30a469494379076d2980ee5
        Author: Andreas Beckmann <a...@debian.org>
        Date:   Sat Feb 8 00:02:10 2025 +0100

                simplify debian/rules

        ...

        diff --git a/debian/rules b/debian/rules
        index 3382d61..b46c561 100755
        --- a/debian/rules
        +++ b/debian/rules
        @@ -5,28 +5,11 @@

         include /usr/share/dpkg/pkg-info.mk

        -export DEB_BUILD_MAINT_OPTIONS = hardening=+all
        -
         %:
        -       dh $@ --with autoreconf
        -
        -# Don't want to build. Just send source code to
        -# package to be built by DKMS
        -override_dh_auto_build:
        +       dh $@ --buildsystem none

        ...

Switching to the "none" buildsystem seems to prevent dh_dkms from being
run, even if it Build-Depends on dh-sequence-dkms.

One simple solution to this problem that I have experimented locally is
to pass the "--with dkms" option to dh in the debian/rules file:

        diff --git c/debian/rules i/debian/rules
        index b46c561..991f6f0 100755
        --- c/debian/rules
        +++ i/debian/rules
        @@ -6,7 +6,7 @@
         include /usr/share/dpkg/pkg-info.mk

         %:
        -       dh $@ --buildsystem none
        +       dh $@ --buildsystem none --with dkms

Since "dh-sequence-dkms" is broken for this usecase, maybe the
Build-Depends should also be switched from "dh-sequence-dkms" to
"dh-dkms" if it is accepted.

After applying this patch the dkms.conf file is correctly located with
the source files in ./usr/src/osmocom-dahdi-0.0~git20241003.b2ea348/,
showing that dh_dkms was able to substitute the value correctly.

I will attach a patch to this bug, as well as create a merge request on
the salsa repository, as soon as I get back the bug number from the BTS.

Thanks.

--- End Message ---
--- Begin Message ---
Source: osmocom-dahdi-linux
Source-Version: 0.0~git20241003.b2ea348-4
Done: Thorsten Alteholz <deb...@alteholz.de>

We believe that the bug you reported is fixed in the latest version of
osmocom-dahdi-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1100...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Alteholz <deb...@alteholz.de> (supplier of updated osmocom-dahdi-linux 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 10 Mar 2025 23:13:06 +0100
Source: osmocom-dahdi-linux
Architecture: source
Version: 0.0~git20241003.b2ea348-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Mobcom Maintainers 
<debian-mobcom-maintain...@lists.alioth.debian.org>
Changed-By: Thorsten Alteholz <deb...@alteholz.de>
Closes: 1100050
Changes:
 osmocom-dahdi-linux (0.0~git20241003.b2ea348-4) unstable; urgency=medium
 .
   * add dkms patch from Agathe Porte Thanks a lot!
     (Closes: #1100050)
Checksums-Sha1:
 848980a27825ebb1cd8054adcecb5cd8476701cc 2589 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.dsc
 82060ab9e8d760a7e28d768119e0508b852d1b0e 1227080 
osmocom-dahdi-linux_0.0~git20241003.b2ea348.orig.tar.xz
 8e3d2af8fb1271c796820dfb7f50cae4cc048733 7532 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.debian.tar.xz
 082f6fb790d51a0366213ecc06259d48e51acc1d 6732 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4_amd64.buildinfo
Checksums-Sha256:
 d732eb846841bb6963b72ecd11893c87827e29611650a7d90563c2d75c18e3c2 2589 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.dsc
 64efd0a82194e034109a62d40b015831c718b69ca30b7da463bbda30843972a4 1227080 
osmocom-dahdi-linux_0.0~git20241003.b2ea348.orig.tar.xz
 c9ee8d23e53caef85959e08f54dad73346ad1fb3c38ca5bc2184d28cd28c0556 7532 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.debian.tar.xz
 f313255e936a2043b4dadbdd6adfb4e82ac47068b2adfca5e95786ad88a50f56 6732 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4_amd64.buildinfo
Files:
 89f660396c576618c5e897327eddd635 2589 comm optional 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.dsc
 fb95a4185e78b79b6c80d762d9e0f414 1227080 comm optional 
osmocom-dahdi-linux_0.0~git20241003.b2ea348.orig.tar.xz
 964bbce7c1d718d43bbc4e5f19bcfb54 7532 comm optional 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4.debian.tar.xz
 15958c93d28c4ff5f6c0b8dfb6a0662c 6732 comm optional 
osmocom-dahdi-linux_0.0~git20241003.b2ea348-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKnBAEBCgCRFiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAmfPbOZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcTHGRlYmlhbkBh
bHRlaG9sei5kZQAKCRCW/KwNOHtYR1DDEACSIUoXxMyVx0uXZ6Cenyf/yk2CeqyC
JHfGBzqfgOZUlh6KFsSM7xutMK7VGcLIeDdpktFys0z1zxZYisP4cXPAEi1uBpJc
CL+wZAZ7ljrKWM5zD7dsO3/37650AZlGHHx6/1avU/r6sbJjYPmc9UjFoRbDLe85
6XEW84gbObi1WuI7lOym7dcPoLQi2c3MhoAVkqYb1bpqNJueAlrRdmDTw56pYMeQ
mRKMBiLGTQQnUYyX7z6qz8KDPM5GKwSBNNwijBN4P06RUvyQwt+kFpO63j0raBjf
2BlgOvXlLM9BHERKh9EwqCz1wOwarGhqS56Oee7ef9WVwhgypwJAkm/sgDfAaQFx
6OYVSHSdQBV0/DdJERsevuFwiRiGMk3Q+jfDizpHB3b1/URhKECD1Rb7QjOo6gXs
TzU09xMWOIaOqw1PXh5AkC+J3djfFBJNUifq2JgeR8Edl4oyE/J8QFc7F7cFAkJo
Oe4ucXjCmsMhYbzbLFgB5ogPQWYwGzTkN38EifbT1xezkHlL24zhTaAoSWeVAAlj
9Razsj6QFWMBnh/5FdRMpZdy2QxTr6yl4m6NzKsXsh/J9oLjqeAbOX0KyNuAnwp3
BSrCRFD1QPlLFAtAKZaGcFGMQFvzH/bYqfeLKc2hgrKOYg4jyqByNYNCMaKdEKuo
TKjqq9XzyhC7Eg==
=re6H
-----END PGP SIGNATURE-----

Attachment: pgp_rG_O8GZPt.pgp
Description: PGP signature


--- End Message ---

Reply via email to