Your message dated Fri, 07 Mar 2025 13:49:45 +0000
with message-id <e1tqy5b-001r6a...@fasolo.debian.org>
and subject line Bug#1076456: fixed in iptables-netflow 2.6-7.1
has caused the Debian Bug report #1076456,
regarding iptables-netflow-dkms: No more builds on Debian 11 Bullseye since 
kernel linux-image-5.10.0-31-amd64 (5.10.221-1) due to "unexport find_module" 
kernel backport from 5.12
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1076456: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076456
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: iptables-netflow-dkms
Version: 2.5.1-2
Severity: grave
Tags: patch bullseye

Since linux-image-5.10.0-31-amd64/5.10.221-1, ipt_NETFLOW.ko no more
builds on Debian 11 Bullseye:

Citing from /var/lib/dkms/ipt-netflow/2.5.1/build/make.log:

DKMS make.log for ipt-netflow-2.5.1 for kernel 5.10.0-31-amd64 (x86_64)
Tue Jul 16 16:17:06 UTC 2024
./gen_compat_def > compat_def.h
Test symbol xt_family linux/netfilter_ipv4/ip_tables.h
Test struct timeval linux/ktime.h
Test struct proc_ops linux/proc_fs.h
Test symbol synchronize_sched linux/rcupdate.h
Compiling for kernel 5.10.221
make -C /lib/modules/5.10.0-31-amd64/build 
M=/var/lib/dkms/ipt-netflow/2.5.1/build modules CONFIG_DEBUG_INFO
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make 
rule.
make[1]: Entering directory '/usr/src/linux-headers-5.10.0-31-amd64'
  CC [M]  /var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.o
/var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.c: In function 'nf_seq_show':
/var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.c:755:39: warning: format 
'%lu' expects argument of type ' 3 has type 's64' {aka 'long long int'} 
[-Wformat=]
  755 |    seq_printf(seq, " Flows selected %lu, discarded %lu.",
      |                                     ~~^
      |                                       |
      |                                       long unsigned int
      |                                     %llu
/var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.c:755:54: warning: format 
'%lu' expects argument of type ' 4 has type 's64' {aka 'long long int'} 
[-Wformat=]
  755 |    seq_printf(seq, " Flows selected %lu, discarded %lu.",
      |                                                    ~~^
      |                                                      |
      |                                                      long unsigned int
      |                                                    %llu
/var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.c:759:39: warning: format 
'%lu' expects argument of type ' 3 has type 's64' {aka 'long long int'} 
[-Wformat=]
  759 |    seq_printf(seq, " Flows selected %lu.", 
atomic64_read(&flows_selected));
      |                                     ~~^
      |                                       |
      |                                       long unsigned int
      |                                     %llu
  MODPOST /var/lib/dkms/ipt-netflow/2.5.1/build/Module.symvers
ERROR: modpost: "find_module" 
[/var/lib/dkms/ipt-netflow/2.5.1/build/ipt_NETFLOW.ko] undefined!
make[3]: *** 
[/usr/src/linux-headers-5.10.0-31-common/scripts/Makefile.modpost:123: 
/var/lib/dkms/ipt-netfloror 1
make[3]: *** Deleting file 
'/var/lib/dkms/ipt-netflow/2.5.1/build/Module.symvers'
make[2]: *** [/usr/src/linux-headers-5.10.0-31-common/Makefile:1783: modules] 
Error 2
make[1]: *** [/usr/src/linux-headers-5.10.0-31-common/Makefile:192: __sub-make] 
Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.10.0-31-amd64'
make: *** [Makefile:25: ipt_NETFLOW.ko] Error 2

This happens, because upstream kernel 5.10.220 backported this change
from kernel 5.12:

- module: unexport find_module and module_mutex

Backporting upstream commit
https://github.com/aabc/ipt-netflow/commit/5aae3791922bd3df878605b15e83ea48a4bd096c
with updated version constraint fixes the issue:

Index: iptables-netflow-2.5.1/compat.h
===================================================================
--- iptables-netflow-2.5.1.orig/compat.h
+++ iptables-netflow-2.5.1/compat.h
@@ -749,4 +749,29 @@ unsigned long long strtoul(const char *c
        return result;
 }
 
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,12,0) || LINUX_VERSION_CODE >= 
KERNEL_VERSION(5,10,220)
+/*
+ * find_module() is unexported in v5.12:
+ *   089049f6c9956 ("module: unexport find_module and module_mutex")
+ * and module_mutex is replaced with RCU in
+ *   a006050575745 ("module: use RCU to synchronize find_module")
+ */
+#include <linux/rcupdate.h>
+struct module *find_module(const char *name)
+{
+       struct module *mod;
+
+       rcu_read_lock_sched();
+       /* Yes this is crazy, but should work. */
+       list_for_each_entry_rcu(mod, &THIS_MODULE->list, list) {
+               if (!strcmp(mod->name, name)) {
+                       rcu_read_unlock_sched();
+                       return mod;
+               }
+       }
+       rcu_read_unlock_sched();
+       return NULL;
+}
+#endif
+
 #endif /* COMPAT_NETFLOW_H */

I intend to do a bullseye-proposed-stable upload for that.

--- End Message ---
--- Begin Message ---
Source: iptables-netflow
Source-Version: 2.6-7.1
Done: Andreas Beckmann <a...@debian.org>

We believe that the bug you reported is fixed in the latest version of
iptables-netflow, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1076...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <a...@debian.org> (supplier of updated iptables-netflow 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 07 Mar 2025 14:32:07 +0100
Source: iptables-netflow
Architecture: source
Version: 2.6-7.1
Distribution: unstable
Urgency: medium
Maintainer: Axel Beckert <a...@debian.org>
Changed-By: Andreas Beckmann <a...@debian.org>
Closes: 966483 1076456 1081377 1088678 1089498
Changes:
 iptables-netflow (2.6-7.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Use debhelper-compat (= 13) substitution instead of dh-exec.
   * Remove useless pushd/popd from dkms.conf.  (Closes: #966483)
   * Dump the generated compat_def.h.
   * Update from upstream Git.
   * Fix dkms status invocation.
   * Avoid dkms recursion.
   * dkms.conf: Declare BUILD_EXCLUSIVE_KERNEL_MIN="3".
   * Fix module build for Linux v4.3.
   * Unexporting find_module() has been backported to Linux v5.10.220.
     (Closes: #1076456, #1088678)
   * Fix module build for Linux v6.11.  (Closes: #1081377)
   * Fix module build for Linux v6.12.  (Closes: #1089498)
   * Work around physindev in nf_bridge_info being replaced by physinif to fix
     module build for Linux v6.8, v6.7.2, v6.6.14, v6.1.75.
Checksums-Sha1:
 debac79247e1a63712dca1f87889b57003bc175e 2072 iptables-netflow_2.6-7.1.dsc
 a5378367542d380d30038b56b09326b0c1a47bf3 24532 
iptables-netflow_2.6-7.1.debian.tar.xz
 f983844090fd071e1b87c221772f05b961b50353 5537 
iptables-netflow_2.6-7.1_source.buildinfo
Checksums-Sha256:
 27a175fbe9c0a4b7f63e02266f8bf213c23aceec9f8f87e433eff99a5c28aad7 2072 
iptables-netflow_2.6-7.1.dsc
 a308af75736268c51f8a2601c33b325a7fbdcb11e40d76eeaedae1b4c8d8524e 24532 
iptables-netflow_2.6-7.1.debian.tar.xz
 754fc2f623fb069d33b90a75d93de6db989346c3c6e241030b4322eafc815c3d 5537 
iptables-netflow_2.6-7.1_source.buildinfo
Files:
 38c3007cf7d42662e00d90f46f3e5c0e 2072 kernel optional 
iptables-netflow_2.6-7.1.dsc
 ba031506e779c6e966faf788d9951eca 24532 kernel optional 
iptables-netflow_2.6-7.1.debian.tar.xz
 d5b223bafe5ba3a3580709b9e76e4eb8 5537 kernel optional 
iptables-netflow_2.6-7.1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmfK9o8QHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCLLuD/wMxKeaqPdPfbSC5HupVX9Py7EODSxSR3Q5
ZKPyq31lVwqIomBXMjNrGadYl21WbeKXKPNWzibjRenv8/8hzEyAaFhFjlIEmPJ8
6Obn5bJTbAUO0MHj6EFPJE+XYTJCp3NYwOx5c0VleGWgzvhSA6jmA7iI2In1ZpT9
/onVBbP+9lhgo9b4jbg/tdnRwAdnBP0zMJT7Qo569SfCvNjVlZqZenS5gbiEKZXe
txL/8lLhEgS0wNaDUVA0tr41MMxkhnM0Mz4sNH6SBCxyuKQ8at7KQwzQWb87pszB
ZX3hvIGeXqoEoNOkXUUckt7QWFKyXTFIECqDcD3Oolu+nVvEiwx4YsvME8+Bg9Nx
zaVRjOwkRIvpdgAz/OERVyyFYrETkAXjZCAGVhldM+mOZf+DqhPQQRnkNBQjDka6
rRI0ZPd0x6IDDUAyAj3T4dlpjSUFr/OjRaCdoODUAxzRfS+TeBmRRUJzWQ4bdEFr
OTFszSNGLcIdmqs+X9M3WIpp4ADzNSNhqO53VurM+nC8yAiTv1uLEdQwQHl3Ioen
JjEsxyqiXm84I96C/pHI9IQDr9KJcRwx0ooiqgb4CqvtGL/sdqXYQMdcr+DpD0Ac
lAGkDjJejNEa5XHdkMIsK3QaZFhIQ4obTLFiWCg77jy4UxCkefTmd7wIGnXKaEH0
JWW+QUPEfw==
=ZoC/
-----END PGP SIGNATURE-----

Attachment: pgpWpRRnK7CzO.pgp
Description: PGP signature


--- End Message ---

Reply via email to