reopen 380520
severity 380520 normal
thanks
[Sorry for the delay, had to learn a bit what's a socket before replying]
Sjoerd Simons a écrit :
On Mon, Sep 04, 2006 at 02:34:10PM -0400, Filipus Klutiero wrote:
I don't want hal depending on acpid. I will patch the hal acpi addon
to not
directly use the proc interface iff /usr/sbin/acpid exists.
The hal ACPI addon already won't directly use the proc interface iff
/usr/sbin/acpid exists and acpid is started. The other case is
/usr/sbin/acpid exists and acpid is not started. Apart from not directly
using the proc interface, what will the hal ACPI addon do in this case?
Abort hald's launch?
Use the socket provided by acpid to monitor the events.
I guess you misunderstood me, sorry if what I said was confusing. The
case I was referring to is when /usr/sbin/acpid exists and acpid is not
started. So, what will the hald ACPI addon do when /usr/sbin/acpid
exists and acpid is not started, apart from not directly using the proc
interface? Anyway, it turns out that the answer is that hald will launch
with a non-functional addon-acpi which will retry connecting to
/var/run/acpid.socket every 5 seconds. To clarify the changelog, what
hald does is to check on its launch whether /usr/sbin/acpid exists. If
it does, it will avoid grabing /proc/acpi/event until hald is reloaded.
I'm reopening the bug to reflect that this will need acpid's
collaboration and adjusting severity.
BTW, acpid is 180 kB and has no meaningful dependencies. This is a
moderate size, even compared to hal itself. Is there anything other than
acpid's size that makes you want to avoid depending on it?
Because it's just not needed for hal. It just add extra complexity
Of course, it's not needed *for hal*. I can't see how your solution is
simpler than depending on acpid, but thanks anyway. Wouldn't it be
better for acpid to restart hald when acpid is started, rather than when
acpi is installed? I think that would allow to avoid restarting hald if
acpid is installed but not started (although that seems
unlikely/impossible) and to drop your hald patch. Dropping your hald
patch would avoid a non-functional hald-addon-acpi in the
"/usr/sbin/acpid exists and acpid is not started" case discussed above.
However, if you don't want to drop your patch, one way to complete it
and make it useful would be to patch acpi_get_event_fp_acpid (void) to
make sure that acpid is started if the connection to the socket fails
and acpid is installed, then retry connecting.
