Source: spglib
Version: 2.5.0-1
Severity: critical
User: debian-r...@lists.debian.org
Usertags: ruby3.3

Dear maintainer,

There is an autopkgtest failure which is blocking the current ruby3.3-default transition:

https://ci.debian.net/packages/s/spglib/testing/amd64/56969334/

I am attaching a patch that would fix this failure. Please, consider it to unblock the ongoing transition.

For your convenience, I submitted this patch as a merge request here:

https://salsa.debian.org/science-team/spglib/-/merge_requests/3

TIA!

--
Lucas Kanashiro
From 936633c3e4350c9e01e63139843e905310e3987a Mon Sep 17 00:00:00 2001
From: Lucas Kanashiro <kanash...@debian.org>
Date: Mon, 27 Jan 2025 08:21:27 -0300
Subject: [PATCH] d/p/0003-Fix-autopkgtest-regression.patch: unblock ruby3.3
 transition

---
 .../0003-Fix-autopkgtest-regression.patch     | 36 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 37 insertions(+)
 create mode 100644 debian/patches/0003-Fix-autopkgtest-regression.patch

diff --git a/debian/patches/0003-Fix-autopkgtest-regression.patch b/debian/patches/0003-Fix-autopkgtest-regression.patch
new file mode 100644
index 0000000..989c34c
--- /dev/null
+++ b/debian/patches/0003-Fix-autopkgtest-regression.patch
@@ -0,0 +1,36 @@
+From: Lucas Kanashiro <kanash...@debian.org>
+Date: Mon, 27 Jan 2025 07:54:18 -0300
+Subject: Fix autopkgtest regression
+
+We are getting the following failure:
+
+321s autopkgtest [08:19:10]: test command1: RUBYLIB=ruby ruby ruby/symPoscar.rb test/functional/python/data/hexagonal/POSCAR-168 | fgrep --silent 'P6 (168) / 6 / P 6 (462) /'
+321s autopkgtest [08:19:10]: test command1: [-----------------------
+321s /tmp/autopkgtest.DJT60Q/build.c82/src/ruby/poscar.rb:286:in `parse': undefined method `=~' for false:FalseClass (NoMethodError)
+321s 	from /tmp/autopkgtest.DJT60Q/build.c82/src/ruby/poscar.rb:212:in `initialize'
+321s 	from ruby/symPoscar.rb:257:in `new'
+321s 	from ruby/symPoscar.rb:257:in `<main>'
+322s autopkgtest [08:19:11]: test command1: -----------------------]
+322s autopkgtest [08:19:11]: test command1:  - - - - - - - - - - results - - - - - - - - - -
+322s command1             FAIL non-zero exit status 1
+
+Applying this patch fixes the issue.
+
+Forwarded: no
+---
+ ruby/poscar.rb | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ruby/poscar.rb b/ruby/poscar.rb
+index 45c4168..e8172ef 100644
+--- a/ruby/poscar.rb
++++ b/ruby/poscar.rb
+@@ -283,7 +283,7 @@ module Vasp
+         @selectiveDynamics = true
+         temp = @input.readline           # when this situation, reading one more line is nessesarry
+       end
+-      if (! temp =~ /^\s*d/i)
++      if ! (temp =~ /^\s*d/i)
+         # allow only 'Direct' now
+         warn "#{filename}: line 7 or 8"
+         warn "poscar.rb can handle only direct coordinates."
diff --git a/debian/patches/series b/debian/patches/series
index d7f6273..ae46d9e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 pyproject.toml.patch
 ruby-paths.patch
 #no-Python-tests.patch
+0003-Fix-autopkgtest-regression.patch
-- 
2.45.2

Reply via email to