Your message dated Sun, 26 Jan 2025 15:00:42 +0000
with message-id <e1tc47u-00avxe...@fasolo.debian.org>
and subject line Bug#1092745: fixed in opensysusers 0.7.3-4.1
has caused the Debian Bug report #1092745,
regarding opensysusers: DEP17 diversions may delete systemd's systemd-sysuser
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1092745: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092745
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: opensysusers
Version: 0.7.3-4
Severity: serious
Justification: loss of systemd files
Tags: patch
User: helm...@debian.org
Usertags: dep17
Hi,
I'm sorry to tell you that I got the DEP17 mitigation for opensysusers
wrong. The details are at
https://lists.debian.org/debian-devel/2025/01/msg00125.html.
opensysusers is affected, because it has a code path that uses --rename
for aliased diversions.
While looking into it and trying to fix it, I noticed that systemd and
systemd-standalone-sysusers now both declare Conflicts: opensysusers and
Conflicts: systemd-sysusers respectively. The latter is being provided
by all sysusers implementations including opensysusers. In trixie and
later, sysusers implementations are no longer coinstallable but mutually
exclusive. This simplifies the story a lot. I propose mirroring the
conflict and declaring "Conflicts: systemd-sysusers". As a result, we
may do away with all of the diversions (and the file loss problem).
At the time of writing my earlier patch, systemd did not yet declare
Conflicts with opensysusers. Hence, I tried to support coinstallation
there. The present simplification is a result of changes in systemd.
Please find my patch and test cases attached.
Helmut
diff --minimal -Nru opensysusers-0.7.3/debian/changelog
opensysusers-0.7.3/debian/changelog
--- opensysusers-0.7.3/debian/changelog 2024-09-17 19:38:59.000000000 +0200
+++ opensysusers-0.7.3/debian/changelog 2025-01-10 15:34:02.000000000 +0100
@@ -1,3 +1,10 @@
+opensysusers (0.7.3-4.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Declare Conflicts: systemd-sysusers and remove diversions. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de> Fri, 10 Jan 2025 15:34:02 +0100
+
opensysusers (0.7.3-4) unstable; urgency=medium
* d/changelog: correct closed bug for previous entry
diff --minimal -Nru opensysusers-0.7.3/debian/control
opensysusers-0.7.3/debian/control
--- opensysusers-0.7.3/debian/control 2024-09-17 19:38:59.000000000 +0200
+++ opensysusers-0.7.3/debian/control 2025-01-10 15:34:02.000000000 +0100
@@ -17,6 +17,8 @@
Package: opensysusers
Provides:
systemd-sysusers,
+Conflicts:
+ systemd-sysusers,
Architecture: all
Depends:
passwd,
diff --minimal -Nru opensysusers-0.7.3/debian/opensysusers.postinst
opensysusers-0.7.3/debian/opensysusers.postinst
--- opensysusers-0.7.3/debian/opensysusers.postinst 1970-01-01
01:00:00.000000000 +0100
+++ opensysusers-0.7.3/debian/opensysusers.postinst 2025-01-10
15:34:02.000000000 +0100
@@ -0,0 +1,16 @@
+#!/bin/sh
+
+set -e
+
+if [ configure = "$1" ] && [ -n "$2" ] && dpkg --compare-versions "$2" lt
0.7.3-4.1~; then
+ # We are upgrading from an earlier version that used to divert
+ # systemd-sysusers. Since this version Conflicts: systemd-sysusers, there
+ # should not be any divertees left during postinst and we may safely remove
+ # all remaining diversions. If anything is left behind, --rename will fail.
+ dpkg-divert --remove --rename /usr/bin/systemd-sysusers
+ dpkg-divert --remove --rename /bin/systemd-sysusers
+fi
+
+#DEBHELPER#
+
+exit 0
diff --minimal -Nru opensysusers-0.7.3/debian/opensysusers.postrm
opensysusers-0.7.3/debian/opensysusers.postrm
--- opensysusers-0.7.3/debian/opensysusers.postrm 2024-09-17
19:38:59.000000000 +0200
+++ opensysusers-0.7.3/debian/opensysusers.postrm 1970-01-01
01:00:00.000000000 +0100
@@ -1,32 +0,0 @@
-#!/bin/sh
-
-set -e
-
-if [ "$1" = "remove" ] || [ "$1" = "abort-install" ] || [ "$1" = "disappear" ]
; then
- dpkg-divert --package opensysusers --remove --no-rename \
- --divert /bin/systemd-sysusers.real /bin/systemd-sysusers
- dpkg-divert --package opensysusers --remove --no-rename \
- --divert /usr/bin/systemd-sysusers.real /usr/bin/systemd-sysusers
-fi
-
-if [ "abort-upgrade" = "$1" ] && dpkg --compare-versions "$2" lt 0.6-1; then
- dpkg-divert --package opensysusers --remove --no-rename \
- --divert /bin/systemd-sysusers.real /bin/systemd-sysusers
-fi
-
-if [ "$1" = abort-upgrade ] && dpkg --compare-versions "$2" lt 0.7.3-2.1~; then
- dpkg-divert --package opensysusers --remove --no-rename \
- --divert /usr/bin/systemd-sysusers.real /usr/bin/systemd-sysusers
-fi
-
-if [ "$1" = "remove" ] || [ "$1" = "abort-install" ] || [ "$1" = "disappear" ]
; then
- for f in /usr/bin/systemd-sysusers /bin/systemd-sysusers; do
- if [ -e "$DPKG_ROOT$f.real" ] && ! [ -e "$DPKG_ROOT$f" ]; then
- mv "$DPKG_ROOT$f.real" "$DPKG_ROOT$f"
- fi
- done
-fi
-
-#DEBHELPER#
-
-exit 0
diff --minimal -Nru opensysusers-0.7.3/debian/opensysusers.preinst
opensysusers-0.7.3/debian/opensysusers.preinst
--- opensysusers-0.7.3/debian/opensysusers.preinst 2024-09-17
19:38:59.000000000 +0200
+++ opensysusers-0.7.3/debian/opensysusers.preinst 2025-01-10
15:34:02.000000000 +0100
@@ -6,24 +6,6 @@
update-alternatives --remove-all sysusers
fi
-if [ upgrade != "$1" ] || dpkg --compare-versions "$2" lt 0.6-1; then
- dpkg-divert --package opensysusers --add --no-rename \
- --divert /bin/systemd-sysusers.real /bin/systemd-sysusers
-fi
-
-if [ upgrade != "$1" ] || dpkg --compare-versions "$2" lt 0.7.3-2.1~; then
- dpkg-divert --package opensysusers --add --no-rename \
- --divert /usr/bin/systemd-sysusers.real /usr/bin/systemd-sysusers
-fi
-
-if [ upgrade != "$1" ]; then
- for f in /usr/bin/systemd-sysusers /bin/systemd-sysusers; do
- if [ -e "$DPKG_ROOT$f" ] && ! [ -e "$DPKG_ROOT$f.real" ]; then
- mv "$DPKG_ROOT$f" "$DPKG_ROOT$f.real"
- fi
- done
-fi
-
#DEBHELPER#
exit 0
test.sh
Description: Bourne shell script
--- End Message ---
--- Begin Message ---
Source: opensysusers
Source-Version: 0.7.3-4.1
Done: Helmut Grohne <hel...@subdivi.de>
We believe that the bug you reported is fixed in the latest version of
opensysusers, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1092...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Helmut Grohne <hel...@subdivi.de> (supplier of updated opensysusers package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 26 Jan 2025 13:41:22 +0100
Source: opensysusers
Architecture: source
Version: 0.7.3-4.1
Distribution: unstable
Urgency: medium
Maintainer: Andrea Pappacoda <and...@pappacoda.it>
Changed-By: Helmut Grohne <hel...@subdivi.de>
Closes: 1092745
Changes:
opensysusers (0.7.3-4.1) unstable; urgency=medium
.
[ Helmut Grohne ]
* Non-maintainer upload.
* Declare Conflicts: systemd-sysusers and remove diversions.
(Closes: #1092745)
.
[ Michael Biebl ]
* Run autopkgtest without installing
Checksums-Sha1:
bb113fcf6d374148c6750e1dc5d9a573eda8d4c8 2087 opensysusers_0.7.3-4.1.dsc
875f765cbc90a93446b48b923076b83036f151ae 5992
opensysusers_0.7.3-4.1.debian.tar.xz
Checksums-Sha256:
6f2e201ebfc148be6bde09d7d846da419e3fd5072e184ada56f342a630b2b79c 2087
opensysusers_0.7.3-4.1.dsc
ff3f906519e58e65ef8d77338ec38bb4329c7b04ff94e8d5d97f710f83438497 5992
opensysusers_0.7.3-4.1.debian.tar.xz
Files:
77097d67840ae57f50f49b3c58478e88 2087 admin optional opensysusers_0.7.3-4.1.dsc
026894c4d16876d908e2587a57b20e72 5992 admin optional
opensysusers_0.7.3-4.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEETMLS2QqNFlTb+HOqLRqqzyREREIFAmeWPLsACgkQLRqqzyRE
REKWYg//V/WpepXw1CcryBj+1w8uCmrznWoLuaojPqLUWfO5K4+pKJt7JzDkZdE3
OlpPBeRlYbeh3DorOa3gaGp+tOIPnV+5CBYysqO1M676b3v5ztaBHRYFGwIjbuUl
k5kssmpBsX+5nIbWhFF5MFLQvoxfx3O4tubLKjza832bqxE4jaOpkfoPT9Nms70E
QoYSo1koDV7ipuekoR23QM06EETu0lNw8bu/DSGukN1/OFu4KGxyeRogZEmGVzBW
5J8Sd3/lrvgRquwmVr0XkshJUww11MO9R+fvZey7VJ3aYuf9NFbdROlexop/2gAm
7fU1Qn7TjgneL96LwjS52YAB69v5UyO8f5ZE3MxtVyXb5WH26yJ24pNkTW6PvtvT
3rGZr7blaeG05qw+UIH58Bs8fz5vb4sLy9e9ryHUouVUMfFmV7T4gvZgxlWr+RCt
l0D2hSw3Kzq21bg5W9TQ42PTyi8JYoyz/SPs2W3H6gaZvMW/uszR7TbApFkC0pF0
gmITn+sjbYS7sITv+fw/2X2LG+yYK3WKsRZsHwgKdLHQPh0d5km0T3f3MhLxCPJZ
fDJlTop5A4vmG0c0PzhVDG2GvyZizkkfD/HOyxkDV9UsFScFR/NhOiyx+3iltEQ3
L8VoYOyjpch7N5lXqiBw7J+nCqqhwmzWT8X7XDIVCMLImCfY8sw=
=Vl+9
-----END PGP SIGNATURE-----
pgpKaOkpZwqOH.pgp
Description: PGP signature
--- End Message ---
