On Tue, 03 Dec 2024 at 17:19:03 -0500, Jeremy Bícha wrote: > On Tue, Dec 3, 2024 at 4:48 PM Rebecca N. Palmer > <rebecca_pal...@zoho.com> wrote: > > This applies the above upstream patch to Debian brasero; it builds, but > > that's all the testing it's had. > > > > https://salsa.debian.org/rnpalmer-guest/brasero > > The Debian GNOME team uses git formatted patches since they apply more > cleanly with our git-buildpackage (gbp pq) workflow, so I'll probably > reformat this patch myself unless you want to try to redo it.
Normally we keep the patch's upstream authorship when applying patches, which is something that works really well when using the gbp pq dialect of patch metadata. Rebecca: please take a look at https://salsa.debian.org/gnome-team/brasero/-/merge_requests/4 (which I'm now test-building) and you'll hopefully see what I mean. In the version I pushed, you're credited in the git history of the packaging branch and in the changelog, but not in the patch itself (because it looked like you've taken the patch directly from upstream rather than writing any code yourself). > Brasero is kept around in case some people find it useful, but it's > not actively tested or anything. I have a USB optical drive and some media, so I can at least do a smoke-test on it to get this RC bug fixed, assuming my blank media haven't completely delaminated by now. Jeremy, do you think we should be minimizing other packages' dependencies on brasero? At the moment it's required by: - rhythmbox (GNOME team, key package until recently; for an optional plugin) - sound-juicer (GNOME team package; seems to be mandatory) - goobox (orphaned; seems to be mandatory) - gthumb (orphaned; for an optional feature) If we are concerned that brasero is undermaintained, we could consider preemptively dropping the CD-burning plugins from rhythmbox and optionally gthumb, in order to minimize the blast radius if brasero needs to be removed for some future problem. (My partner will be unhappy if we lose rhythmbox but is unlikely to care whether it can burn CDs :-) > > (Not a real merge request because the above repository was created with > > 'git push' and hence isn't officially a fork.) Rebecca, if you don't have any other contributions pending for brasero, I'd suggest deleting your not-a-fork after the fix for this bug gets released, and re-creating it as an actual fork if you want to contribute other things in future. That makes the merge request workflow go a lot more gracefully. (Or, if you have a particular interest in GNOME team packages, you could join the team and that will let you push proposed branches without creating a fork, similar to the wip/bug1074854 branch that I've created to test your contribution.) Thanks, smcv
