Your message dated Fri, 10 Jan 2025 08:34:30 +0000
with message-id <e1twato-00g97v...@fasolo.debian.org>
and subject line Bug#1088292: fixed in ffproxy 1.6-12.2
has caused the Debian Bug report #1088292,
regarding ffproxy: Segfaults due to wrong type fixes
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1088292: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088292
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: ffproxy
Version: 1.6-12.1
Severity: serious
Tags: patch
X-Debbugs-Cc: Chris Hofstaedtler <z...@debian.org>
Hi!
We just noticed segfaults while running ffproxy on our lab systems,
when we have DNS resolve issues (say a bogus entry from
/etc/resolv.conf). While debugging this I realized the original fix
for the type change was wrong, so my fix was subsequently also wrong.
The attached patch against the unpacked source should fix the type
mismatch and fixes the segfaults for us.
Thanks,
Guillem
diff --git c/debian/patches/08_fix_variables_declaration_conflicts i/debian/patches/08_fix_variables_declaration_conflicts
index c179c56..93b7bfc 100644
--- c/debian/patches/08_fix_variables_declaration_conflicts
+++ i/debian/patches/08_fix_variables_declaration_conflicts
@@ -1,8 +1,10 @@
Description: Fix conflicting declarations of some variables
-Author: Emmanuel Bouthenot <kol...@debian.org>
+Author: Guillem Jover <gjo...@sipwise.com>
Bug-Debian: https://bugs.debian.org/688462
+Bug-Debian: https://bugs.debian.org/1074954
+Origin: vendor
Forwarded: no
-Last-Update: 2019-02-18
+Last-Update: 2024-11-26
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/dbs.h
@@ -17,9 +19,36 @@ This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
-extern char *e_post;
-extern char *e_fil;
-extern char *e_nic;
-+extern struct msg *e_inv;
-+extern struct msg *e_res;
-+extern struct msg *e_con;
-+extern struct msg *e_post;
-+extern struct msg *e_fil;
-+extern struct msg *e_nic;
++extern struct msg e_inv;
++extern struct msg e_res;
++extern struct msg e_con;
++extern struct msg e_post;
++extern struct msg e_fil;
++extern struct msg e_nic;
+--- a/msg.c
++++ b/msg.c
+@@ -46,19 +46,19 @@ err_msg(int s, struct req * r, int m)
+
+ switch (m) {
+ case E_INV:
+- p = e_inv;
++ p = e_inv.c;
+ break;
+ case E_RES:
+- p = e_res;
++ p = e_res.c;
+ break;
+ case E_CON:
+- p = e_con;
++ p = e_con.c;
+ break;
+ case E_POST:
+- p = e_post;
++ p = e_post.c;
+ break;
+ case E_FIL:
+- p = e_fil;
++ p = e_fil.c;
+ break;
+ }
+
diff --git c/debian/patches/fix-incompat-ptr-types.patch i/debian/patches/fix-incompat-ptr-types.patch
deleted file mode 100644
index 42f3f48..0000000
--- c/debian/patches/fix-incompat-ptr-types.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-Author: Guillem Jover <gjo...@sipwise.com>
-Description: Fix incompatible pointer type asssignment
- We cannot assign a struct into a char *, even if the first member is a char *.
- Instead assign that member into the variable.
-Origin: vendor
-Bug-Debian: https://bugs.debian.org/1074954
-Forwarded: no
-Last-Update: 2024-09-16
-
----
- msg.c | 10 +++++-----
- 1 file changed, 5 insertions(+), 5 deletions(-)
-
---- a/msg.c
-+++ b/msg.c
-@@ -46,19 +46,19 @@ err_msg(int s, struct req * r, int m)
-
- switch (m) {
- case E_INV:
-- p = e_inv;
-+ p = e_inv->c;
- break;
- case E_RES:
-- p = e_res;
-+ p = e_res->c;
- break;
- case E_CON:
-- p = e_con;
-+ p = e_con->c;
- break;
- case E_POST:
-- p = e_post;
-+ p = e_post->c;
- break;
- case E_FIL:
-- p = e_fil;
-+ p = e_fil->c;
- break;
- }
-
diff --git c/debian/patches/series i/debian/patches/series
index 983d3b6..1da3530 100644
--- c/debian/patches/series
+++ i/debian/patches/series
@@ -7,4 +7,3 @@
06_handle-multibytes-headers
07_fix_segfault_syslog_logrequests
08_fix_variables_declaration_conflicts
-fix-incompat-ptr-types.patch
--- End Message ---
--- Begin Message ---
Source: ffproxy
Source-Version: 1.6-12.2
Done: Michael Prokop <m...@debian.org>
We believe that the bug you reported is fixed in the latest version of
ffproxy, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1088...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Prokop <m...@debian.org> (supplier of updated ffproxy package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 09 Jan 2025 16:16:34 +0100
Source: ffproxy
Architecture: source
Version: 1.6-12.2
Distribution: unstable
Urgency: medium
Maintainer: Emmanuel Bouthenot <kol...@debian.org>
Changed-By: Michael Prokop <m...@debian.org>
Closes: 1088292
Changes:
ffproxy (1.6-12.2) unstable; urgency=medium
.
[ Guillem Jover ]
* Non-maintainer upload.
* Fix segfaults due to wrong type fixes (Closes: #1088292)
Checksums-Sha1:
5a11de657bd5464427ddceca56688a3cb641c866 1803 ffproxy_1.6-12.2.dsc
ef66354e8982f48376f6414efce4e2738fb1643e 13896 ffproxy_1.6-12.2.debian.tar.xz
695842ef836ee94af4c21d32e686b9294cf000cd 5972 ffproxy_1.6-12.2_amd64.buildinfo
Checksums-Sha256:
e581ff7317bd5688cf37b8b56fbc232c68c5a9f66fda0e00903a5b6dbf983c32 1803
ffproxy_1.6-12.2.dsc
46b63839ab4fd61b7daa54d24106fe39f9f49174feffb45b122c42bb3896c4a0 13896
ffproxy_1.6-12.2.debian.tar.xz
10cd0c22777277126d4771ed8448667faa467a3f92f588bd2bad4a40b16667b8 5972
ffproxy_1.6-12.2_amd64.buildinfo
Files:
5026831773c15832654f93266269d820 1803 net optional ffproxy_1.6-12.2.dsc
b4a9409fb10c53a2c438f6a6fbbb1e7f 13896 net optional
ffproxy_1.6-12.2.debian.tar.xz
3780140c357d9cbe5cf8acb6b2141622 5972 net optional
ffproxy_1.6-12.2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEM8yxNkAa/shDo4djlqh4crfqNzcFAmd/7lgACgkQlqh4crfq
NzckKA/+IaxKa7HVaQ/cPQnrOeBuT9SMQOIpYpFUO7YOgwvfFCaJyIHj07YTM+Lo
Ee6TLdJViTBIcwOqC7Q6XDzdr/2gFDVAvyOFwSfGkwapmxdePS/wbLk3Epx8Pu4G
HeaAyQT0Vlm7wrsujlvLKqQaGu8N+es9UYkpTd0Nc7qMhM2R6Db8Hj8dCvGZuB22
H/1m72VZ7G52Vjk9145i3R6J5MCB5A5GGZZgjFNVaG2k5gKbBRacJ8Idl5Np7LP5
14bSK3rgdslO6WCJ4lOjri0IMcyaPTOSnxH8rimU2dSR6WWvsLhs5M39WqYDbyD2
MXQ9fQtdw8ayiPd2MOx50L+23t2FWD37aFJdvPxOZAShXfHsRzGyOfvB7VwtcjYV
aWLiaxvwl/kCF6KVxaKZ/KrjYL78MOxWEZ/8YC0PEO7Ns1vwW7c3UHvuJ8Xakewq
s+LYna4SWNas6BJZigmebqCP85jk5p/x0fWQZen+40HfEKROWDnI+4h/kZnwZGK6
ukOoUA+UtXicUZ3i7EJ1K4GW7jJjMqu1PsFd6F1CxrIB1VGSDRUqXSA/q5PIebAl
NCD7Pv2/ll9yJfeO7og4TUwUy8ViuSp9pq/8LprKkPW6D2D7/e4/3K1bbyrsR66Q
Mz6VNiiG28zG+ZGLK0/0wLzUjMtu+Uuwr3CmRga3q5Cpn5f0gSU=
=OpVK
-----END PGP SIGNATURE-----
pgpeg4OsaQ7Nh.pgp
Description: PGP signature
--- End Message ---
