Your message dated Mon, 06 Jan 2025 21:34:48 +0000
with message-id <e1tuukk-00gzew...@fasolo.debian.org>
and subject line Bug#1086581: fixed in stringencoders 3.10.3+git20180306-1.2
has caused the Debian Bug report #1086581,
regarding stringencoders: FTBFS on riscv64 due to undefined signed integer
overflow
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1086581: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086581
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: stringencoders
Version: 3.10.3+git20180306-1.1
Severity: serious
Tags: ftbfs patch upstream
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: debian-ri...@lists.debian.org
User: debian-ri...@lists.debian.org
Usertags: riscv64
Dear maintainer,
stringencoders fails to build on riscv64:
| =================================================
| stringencoders v3.10.3: test/test-suite.log
| =================================================
|
| # TOTAL: 16
| # PASS: 15
| # SKIP: 0
| # XFAIL: 0
| # FAIL: 1
| # XPASS: 0
| # ERROR: 0
|
| .. contents:: :depth: 2
|
| FAIL: modp_numtoa_test
| ======================
|
| modp_numtoa_test.c ........ASSERTION FAILED: modp_numtoa_test.c:408
-2147483648 != -0./,),(-*,(
| FAIL modp_numtoa_test (exit status: 1)
|
| ============================================================================
| Testsuite summary for stringencoders v3.10.3
| ============================================================================
| # TOTAL: 16
| # PASS: 15
| # SKIP: 0
| # XFAIL: 0
| # FAIL: 1
| # XPASS: 0
| # ERROR: 0
| ============================================================================
| See test/test-suite.log
| Please report to nickg -at- client9 -dot- com
| ============================================================================
| make[4]: *** [Makefile:1246: test-suite.log] Error 1
| make[4]: Leaving directory '/<<PKGBUILDDIR>>/test'
| make[3]: *** [Makefile:1354: check-TESTS] Error 2
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/test'
| make[2]: *** [Makefile:1532: check-am] Error 2
| make[2]: Leaving directory '/<<PKGBUILDDIR>>/test'
| make[1]: *** [Makefile:403: check-recursive] Error 1
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| dh_auto_test: error: make -j4 check "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1
returned exit code 2
| make: *** [debian/rules:8: build-arch] Error 25
| dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit
status 2
The full build log is available there:
https://buildd.debian.org/status/fetch.php?pkg=stringencoders&arch=riscv64&ver=3.10.3%2Bgit20180306-1.1%2Bb2&stamp=1730377520&raw=0
The issue happens to be due to an undefined behaviour due to signed
integer overflow, triggered by the switch from GCC 13 to GCC 14. This
can be reproduced on amd64 by compiling the library with
-fsanitize=signed-integer-overflow and then running the test by hand.
The patch belows fixes the issue:
--- stringencoders-3.10.3+git20180306.orig/src/modp_numtoa.c
+++ stringencoders-3.10.3+git20180306/src/modp_numtoa.c
@@ -35,7 +35,7 @@ size_t modp_itoa10(int32_t value, char*
{
char* wstr = str;
/* Take care of sign */
- uint32_t uvalue = (value < 0) ? (uint32_t)(-value) : (uint32_t)(value);
+ uint32_t uvalue = (value < 0) ? -((uint32_t)value) : (uint32_t)(value);
/* Conversion. Number is reversed. */
do
*wstr++ = (char)(48 + (uvalue % 10));
@@ -65,7 +65,7 @@ size_t modp_uitoa10(uint32_t value, char
size_t modp_litoa10(int64_t value, char* str)
{
char* wstr = str;
- uint64_t uvalue = (value < 0) ? (uint64_t)(-value) : (uint64_t)(value);
+ uint64_t uvalue = (value < 0) ? -((uint64_t)value) : (uint64_t)(value);
/* Conversion. Number is reversed. */
do
Regards
Aurelien
--- End Message ---
--- Begin Message ---
Source: stringencoders
Source-Version: 3.10.3+git20180306-1.2
Done: Jonathan Wiltshire <j...@debian.org>
We believe that the bug you reported is fixed in the latest version of
stringencoders, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1086...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jonathan Wiltshire <j...@debian.org> (supplier of updated stringencoders
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 30 Dec 2024 19:53:36 +0000
Source: stringencoders
Architecture: source
Version: 3.10.3+git20180306-1.2
Distribution: unstable
Urgency: medium
Maintainer: Lennart Weller <l...@ring0.de>
Changed-By: Jonathan Wiltshire <j...@debian.org>
Closes: 1086581
Changes:
stringencoders (3.10.3+git20180306-1.2) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patches/0005-numtoa-signing.patch:
fix FTBFS on riscv64 due to undefined signed integer overflow
Closes: #1086581
Checksums-Sha1:
7128b5148286dd27f06a40da3b71d663755cacc1 1525
stringencoders_3.10.3+git20180306-1.2.dsc
e309d663666144600215c35a3c0e286391841aab 6400
stringencoders_3.10.3+git20180306-1.2.debian.tar.xz
1f35d76231aab228429164cd649500de496a1aa0 5631
stringencoders_3.10.3+git20180306-1.2_source.buildinfo
Checksums-Sha256:
0d8d8a266bec8bdaf5193de751cab4e4b030f19276389264534710228d5d80f3 1525
stringencoders_3.10.3+git20180306-1.2.dsc
eb65cc1f9938e4ae1adc762d038f488146a59f34d4e2956b34331104ad71404d 6400
stringencoders_3.10.3+git20180306-1.2.debian.tar.xz
1bdbcd9316cec805eaee07c8660a96e1697591177590807e8d7b44955342d568 5631
stringencoders_3.10.3+git20180306-1.2_source.buildinfo
Files:
e410812271c0d785cecfe4e76f16ff21 1525 libs optional
stringencoders_3.10.3+git20180306-1.2.dsc
6f8e4e02c0dfe552b6634a18f9b47bcc 6400 libs optional
stringencoders_3.10.3+git20180306-1.2.debian.tar.xz
a5e86bcac1489922533e5f7a37bec2f6 5631 libs optional
stringencoders_3.10.3+git20180306-1.2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iIUEARYKAC0WIQTdFzjfLGn8URFmteMDXuYJgEtROQUCZ3MDbQ8cam13QGRlYmlh
bi5vcmcACgkQA17mCYBLUTl3EgD+PyVBVcFjfpsH2IKlHMajFXSGubjKFTL2lih8
dXcaHDoBAKnuNmsYgYtJG68zwJy115g58R5CC5kQgTHictryjbUO
=4LfU
-----END PGP SIGNATURE-----
pgpSF6tjTw4TY.pgp
Description: PGP signature
--- End Message ---
