Hi Colin!

On Thu, Jan 02, 2025 at 10:41:43PM +0000, Colin Watson wrote:
> I came up with the following patch for this, but then I noticed
> https://github.com/sphinx-doc/sphinx/pull/13203 from Dmitry which seems
> at least sort of overlapping even though it doesn't really seem to be
> the same thing.  Dmitry, what do you think?  If it seems reasonable then
> I'll send an upstream PR.

The error seems to come from this code:

https://github.com/sphinx-doc/sphinx/blob/v8.1.3/sphinx/config.py#L637-L665

which replaces the current year in copyright with year from SOURCE_DATE_EPOCH,
but only if source_date_epoch_year < current_year.

Because the test-copyright-multiline/conf.py file hardcodes 2025 and does not
have any dynamic content, to make the test pass I can just make a no-change
upload with 2025 in debian/changelog.

Even in a year, when it's 2026, it will still pass, because of the condition
I mentioned above (provided the code does not change).

Does this plan sound good to you?

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to