Source: pytorch
Version: 2.5.1+dfsg-1
Severity: serious
Justification: policy section 4.6

debian/rules has a recurring pattern:

    cd $SOMEWHERE ;\
        ln -sfv $SOMETARGET $SOMELINK \;
        $MORE_LN_SFV \;
    true

If any the cd fails, the links end up in the wrong directory. If cd or
ln fails, the command is still considered a success due to the chaining
with a semicolon and the trailing true. This is an anti-pattern and
violates Debian policy section 4.6.

Please chain the commands using && instead of ; or prefix the chain with
set -e.

Helmut

Reply via email to