Control: tags 1075615 patch

Dear maintainer,

I have developed a fix for this failure to build from source with gcc-14
for the forthcoming trixie release and would be grateful if you would
consider merging it, please!

The merge request is available at:
<https://salsa.debian.org/kkamagui/vbetool/-/merge_requests/2>

The first commit fixes the failure to build from source. The second,
optional, commit deals with some further warnings that were not treated
as errors, resulting in a clean compilation on i386.

On Wed, Jul 03, 2024 at 12:47:18PM +0000, Matthias Klose wrote:
[abridged quoting]

> [This bug is targeted to the upcoming trixie release]

> The package fails to build in a test rebuild on at least amd64 with
> gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
> severity of this report will be raised before the trixie release.

Fixed by first commit:
> vbetool.c:120:32: error: passing argument 1 of ‘munmap’ makes pointer from 
> integer without a cast [-Wint-conversion]
> vbetool.c:121:35: error: passing argument 1 of ‘mmap’ makes pointer from 
> integer without a cast [-Wint-conversion]

Fixed by second commit:
> vbetool.c:117:31: warning: variable ‘rc’ set but not used 
> [-Wunused-but-set-variable]
> vbetool.c:332:61: warning: format ‘%x’ expects argument of type ‘unsigned 
> int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
> vbetool.c:359:17: warning: variable ‘num_written’ set but not used 
> [-Wunused-but-set-variable]

Not fixed (affects amd64 builds):
> vbetool.c:257:16: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]
> vbetool.c:258:17: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]
> vbetool.c:339:16: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]
> vbetool.c:340:17: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]
> vbetool.c:528:28: warning: cast from pointer to integer of different size 
> [-Wpointer-to-int-cast]

I hope this helps!

Thanks,

Andrew

Attachment: signature.asc
Description: PGP signature

Reply via email to