Your message dated Tue, 03 Dec 2024 22:19:10 +0000
with message-id <e1tibec-007xiu...@fasolo.debian.org>
and subject line Bug#1086345: fixed in desmume 0.9.13-2
has caused the Debian Bug report #1086345,
regarding desmume:FTBFS:build failure (error: ‘AT_HWCAP’ undeclared )
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1086345: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086345
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: desmume
Version:  0.9.13-1
Severity: serious
Tags: FTBFS, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org

Dear desmume Maintainer,
The package desmume build failed on all architectures except ARM.The
crucial buildd log below:
```

FAILED: libdesmume.a.p/.._.._libretro-common_features_features_cpu.c.o
cc -Ilibdesmume.a.p -I. -I../desmume/src/frontend/posix
-I../desmume/src -I../desmume/src/libretro-common/include
-I../desmume/src/frontend -I/usr/include/glib-2.0
-I/usr/lib/riscv64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
-I/usr/include/SDL2 -I/usr/include/dbus-1.0
-I/usr/lib/riscv64-linux-gnu/dbus-1.0/include -I/usr/include/AL
-I/usr/include/soundtouch -fdiagnostics-color=always
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11
-DHAVE_LIBSOUNDTOUCH -g -O2 -Werror=implicit-function-declaration
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wno-implicit-function-declaration
-Wno-int-conversion -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread
-D_REENTRANT -MD -MQ
libdesmume.a.p/.._.._libretro-common_features_features_cpu.c.o -MF
libdesmume.a.p/.._.._libretro-common_features_features_cpu.c.o.d -o
libdesmume.a.p/.._.._libretro-common_features_features_cpu.c.o -c
../desmume/src/libretro-common/features/features_cpu.c
../desmume/src/libretro-common/features/features_cpu.c: In function
‘check_arm_cpu_feature’:
../desmume/src/libretro-common/features/features_cpu.c:321:31: error:
‘AT_HWCAP’ undeclared (first use in this function)
  321 |    uint64_t hwcap = getauxval(AT_HWCAP);
      |                               ^~~~~~~~
../desmume/src/libretro-common/features/features_cpu.c:321:31: note:
each undeclared identifier is reported only once for each function it
appears in
../desmume/src/libretro-common/features/features_cpu.c:323:23: error:
‘HWCAP_ARM_NEON’ undeclared (first use in this function)
  323 |       return (hwcap & HWCAP_ARM_NEON) != 0;
      |                       ^~~~~~~~~~~~~~
../desmume/src/libretro-common/features/features_cpu.c:325:23: error:
‘HWCAP_ARM_VFPv3’ undeclared (first use in this function)
  325 |       return (hwcap & HWCAP_ARM_VFPv3) != 0;
      |                       ^~~~~~~~~~~~~~~
../desmume/src/libretro-common/features/features_cpu.c:327:23: error:
‘HWCAP_ARM_VFPv4’ undeclared (first use in this function)
  327 |       return (hwcap & HWCAP_ARM_VFPv4) != 0;
      |                       ^~~~~~~~~~~~~~~
[97/116] c++ -Ilibdesmume.a.p -I. -I../desmume/src/frontend/posix
-I../desmume/src -I../desmume/src/libretro-common/include
-I../desmume/src/frontend -I/usr/include/glib-2.0
-I/usr/lib/riscv64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
-I/usr/include/SDL2 -I/usr/include/dbus-1.0
-I/usr/lib/riscv64-linux-gnu/dbus-1.0/include -I/usr/include/AL
-I/usr/include/soundtouch -fdiagnostics-color=always
-D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
-std=c++14 -DHAVE_LIBSOUNDTOUCH -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wno-format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -D_REENTRANT -MD -MQ
libdesmume.a.p/.._.._filter_hq3x.cpp.o -MF
libdesmume.a.p/.._.._filter_hq3x.cpp.o.d -o
libdesmume.a.p/.._.._filter_hq3x.cpp.o -c
../desmume/src/filter/hq3x.cpp
[98/116] c++ -Ilibdesmume.a.p -I. -I../desmume/src/frontend/posix
-I../desmume/src -I../desmume/src/libretro-common/include
-I../desmume/src/frontend -I/usr/include/glib-2.0
-I/usr/lib/riscv64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
-I/usr/include/SDL2 -I/usr/include/dbus-1.0
-I/usr/lib/riscv64-linux-gnu/dbus-1.0/include -I/usr/include/AL
-I/usr/include/soundtouch -fdiagnostics-color=always
-D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
-std=c++14 -DHAVE_LIBSOUNDTOUCH -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wno-format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -D_REENTRANT -MD -MQ
libdesmume.a.p/.._.._filter_xbrz.cpp.o -MF
libdesmume.a.p/.._.._filter_xbrz.cpp.o.d -o
libdesmume.a.p/.._.._filter_xbrz.cpp.o -c
../desmume/src/filter/xbrz.cpp
[99/116] c++ -Ilibdesmume.a.p -I. -I../desmume/src/frontend/posix
-I../desmume/src -I../desmume/src/libretro-common/include
-I../desmume/src/frontend -I/usr/include/glib-2.0
-I/usr/lib/riscv64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
-I/usr/include/SDL2 -I/usr/include/dbus-1.0
-I/usr/lib/riscv64-linux-gnu/dbus-1.0/include -I/usr/include/AL
-I/usr/include/soundtouch -fdiagnostics-color=always
-D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
-std=c++14 -DHAVE_LIBSOUNDTOUCH -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wno-format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -D_REENTRANT -MD -MQ
libdesmume.a.p/.._.._filter_hq4x.cpp.o -MF
libdesmume.a.p/.._.._filter_hq4x.cpp.o.d -o
libdesmume.a.p/.._.._filter_hq4x.cpp.o -c
../desmume/src/filter/hq4x.cpp
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-riscv64-linux-gnu && LC_ALL=C.UTF-8 ninja
-j4 -v returned exit code 1
make: *** [debian/rules:9: binary-arch] Error 25
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned
exit status 2

```
The full buildad log is here:
https://buildd.debian.org/status/fetch.php?pkg=desmume&arch=riscv64&ver=0.9.13-1&stamp=1727522830&raw=0
My solution to this issue:
 The check_arm_cpu_feature function is used to check CPU features on ARM
architecture. Since __ARM_ARCH is specific to ARM and these features are
not present on RISC-V, this code needs to be ignored in non-ARM
environments. A conditional check can be added to ensure that this ARM
feature detection code is not compiled on non-ARM architectures.I have
tested this solution locally,and it works well.The debpatch is in the
attachment.Please let me know whether this solution can be accepted.

Attachment: fix_desmume_build_failure_on_riscv.patch
Description: Binary data


--- End Message ---
--- Begin Message ---
Source: desmume
Source-Version: 0.9.13-2
Done: Alexandre Detiste <tc...@debian.org>

We believe that the bug you reported is fixed in the latest version of
desmume, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1086...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Detiste <tc...@debian.org> (supplier of updated desmume package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 03 Dec 2024 22:06:14 +0100
Source: desmume
Architecture: source
Version: 0.9.13-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Alexandre Detiste <tc...@debian.org>
Closes: 1086345
Changes:
 desmume (0.9.13-2) unstable; urgency=medium
 .
   * Team upload
 .
   [ Gui-Yue ]
   * Fix undeclared on riscv64 (Closes: #1086345)
Checksums-Sha1:
 de213e1c9d69f21a7110aebf2b9f0fc22f3da30d 2004 desmume_0.9.13-2.dsc
 b13520c3f8f32853daaeff3b76f6db5fc73ee560 9412 desmume_0.9.13-2.debian.tar.xz
 0a10f04e429368f0424ec6463e2b698e23842eb7 13213 
desmume_0.9.13-2_source.buildinfo
Checksums-Sha256:
 467f2d38e56964837460d41e7da792e89ebd542269cbc9b07ce704410df835ea 2004 
desmume_0.9.13-2.dsc
 40060e1ffffc01a7d8cbc5c830322157bbcd8af048148224102bc3373f8dc797 9412 
desmume_0.9.13-2.debian.tar.xz
 1b212b71d11034e2d38522cea8eb6f8c7b7055ef35771845617a9288cd0202cd 13213 
desmume_0.9.13-2_source.buildinfo
Files:
 bd0331eedcb5a875406494765af2ff0f 2004 games optional desmume_0.9.13-2.dsc
 23217ada175c6b7aa7b9d5fa490fcbb6 9412 games optional 
desmume_0.9.13-2.debian.tar.xz
 da823ff0e74f7dc7ca157c7c226e85d1 13213 games optional 
desmume_0.9.13-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmdPfbARHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBrryBAAih41kJQet8E7OvuvOI0pP5Omw1S5TB4g
TaWgi9HbOMqTNv0rm+Fshdn//AoFT+e4dLubfaHnWSjdhI6YzMKz50/xlLt4OBo1
sNP8kBfZ6iiIc6FskzKsWPAF2dDYmDVQ8rXFfeUq3i4xCcczBDi2KwptYxEnLjAi
MuCsf7MIP5XQeiMwTnkWwzRt/P6FfnOVQdwqBi1XwNoFJu8gTqAO1CkpnsqFJo6q
ZkWcDXbVFbxmRF2bmAU8sviphviacHl4Oo3lnTq8qyBIFqruEEYIw+GcPm6VyJjZ
nLfUiXdqXkQAjVfVgZjH+mzcxTDOxJRr+XLlZ4zxq7JjiFOOl9HYATUECDnoQLzs
E3GQprdirugFgAKKX2SjGKejpjEmhxzs4DZhRvJmmO58MplCA8zqqP9a7cnErSwE
up8vwc2Hv3175XB5ZnXH3Y1JJJXKJXOTHdK7+z1yMc0E0g1bTkRvTtL9tj/70lGQ
A8rkEgt9/eShKhTI/OMUBz7sqbiiypFTvJ9veEgSfCiPjHxjgHOc6R7Y7u7/Jrv5
oXl/HQ3CWwTfmn867rTpWJOrnZ+bNW9gggQECI4pfcXXBXVkoSmZ8vxPZR3sAIat
5LmqbJZaD2yvBlSplaujNYnFxpFWAjJI+tLZXEw6jULWidR3RXkT9mBXzz6yGW2T
VjawY74zx0M=
=DCZP
-----END PGP SIGNATURE-----

Attachment: pgp7mms644Es5.pgp
Description: PGP signature


--- End Message ---

Reply via email to