Control: tags -1 + patch

Hi,

I got a build going through on armhf with the below workaround,
in which I used indications from ArchitectureSpecificsMemo[1]
to reroute the code to safe fallbacks on armhf as well as armel,
without affecting arm64:

-------8<--------------8<--------------8<--------------8<-------
--- libgrokj2k-10.0.5.orig/src/lib/core/highway/hwy/ops/arm_neon-inl.h
+++ libgrokj2k-10.0.5/src/lib/core/highway/hwy/ops/arm_neon-inl.h
@@ -3074,7 +3074,7 @@
   return Vec128<int64_t, N>(vget_low_s64(vmovl_s32(v.raw)));
 }
 
-#if __ARM_FP & 2
+#if __ARM_FP & 2 && !(__arm__ && __ARM_EABI__ && __ARM_PCS_VFP)
 
 HWY_API Vec128<float> PromoteTo(Full128<float> /* tag */,
                                 const Vec128<float16_t, 4> v) {
@@ -3203,7 +3203,7 @@
   return Vec128<int8_t, N>(vqmovn_s16(vcombine_s16(v.raw, v.raw)));
 }
 
-#if __ARM_FP & 2
+#if __ARM_FP & 2 && !(__arm__ && __ARM_EABI__ && __ARM_PCS_VFP)
 
 HWY_API Vec128<float16_t, 4> DemoteTo(Full64<float16_t> /* tag */,
                                       const Vec128<float> v) {
-------8<--------------8<--------------8<--------------8<-------

Then I learned about #1068872, so I stopped whatever testing I
had planned (interference of the patch on other archs, maybe
installing the package to make sure it has no obvious defects,
that sort of things).  The patch is available in case one wants
to take over from here.

[1]: https://wiki.debian.org/ArchitectureSpecificsMemo

In hope this helps,
-- 
  .''`.  Étienne Mollier <emoll...@debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/3, please excuse my verbosity
   `-    on air: Space Debris - Journey Back To The Moon

Attachment: signature.asc
Description: PGP signature

Reply via email to