Hi, On Tue, Oct 15, 2024 at 2:28 PM Stéphane Glondu <glo...@debian.org> wrote: > > Hi Bo, > > Le 15/10/2024 à 04:35, Bo YU a écrit : > > Given upstream's help, the package can be built on my local build now, > > see: > > https://github.com/jrh13/hol-light/issues/101#issuecomment-2411453740 > > Great to hear! > > > But there are two issues blocks me to upload: > > > > 1. there is no doc which hits how to exclude files likes this[0] > > descripted > > > > [0]: https://salsa.debian.org/ocaml-team/hol-light/-/blob/master/debian/ > > hol-light-source.exclude?ref_type=heads > > I don't understand your question... > hmm, sorry for the unclear words. Reading this again, I am worried I have some misunderstanding about this.
This is the first time I see xx.exclude file to exclude some in Debian packaging. What I guess its functionality was the same with debian/not-installed? In my previous email I thought it was used when repacking to exclude some. But obviously, we did not have to need repack it. Another good news[0] is that upstream released new version with tag, so we can use `gbp import-orig .. --uscan` to import new tarball. [0]: https://github.com/jrh13/hol-light/issues/101#issuecomment-2412870397 I will try this work on my side and push the repo, okay? > > 2. we will have to modify the d/rules to pass the build and this will > > change the results of built: > > > > ``` > > --- a/debian/rules > > +++ b/debian/rules > > @@ -29,8 +29,8 @@ override_dh_auto_clean: > > > > .PHONY: override_dh_auto_build > > override_dh_auto_build: > > - dh_auto_build > > - ocamlfind ocamlmktop -verbose -package compiler-libs -package > > camlp-streams -linkpkg -o ocaml > > + $(MAKE) > > + #ocamlfind ocamlmktop -verbose -package compiler-libs -package > > camlp-streams -linkpkg -o ocaml > > > > @@ -41,7 +41,7 @@ override_dh_auto_install: > > chmod -x $(INSTDIR)/usr/share/hol-light/*.ml > > chmod -x $(INSTDIR)/usr/share/hol-light/*/*.ml > > install -d $(INSTDIR)/usr/bin > > - install ocaml $(INSTDIR)/usr/share/hol-light > > + #install ocaml $(INSTDIR)/usr/share/hol-light > > install debian/hol-light.sh $(INSTDIR)/usr/bin/hol-light > > ``` > > > > Obviously this may affect the functionality of the package. > > Why? > I meant it will lost some share file in this way.:) > Given the way hol-light works (last time I looked), I think an > autopkgtest would be ideal. > Ack, I will let you to review this part I think. > Also, please do not leave commented lines if they are not meant to come > back. > Yeah, This is just in my local repo and are not ready to push them yet, I will clear them once done. Thanks for help. BR, Bo > > Cheers, > > -- > Stéphane
