Hi Paul et al, On Thu, Oct 03, 2024 at 01:30:31PM +0200, Paul Gevers wrote: > Hi Julian, > > On 30-09-2024 08:53, Julian Gilbey wrote: > > I've done a lot of cleaning of the source package, and fixed a lot of > > lintian issues (though I haven't pushed anything to salsa yet). > > Thanks for doing this work. Could you maybe push a branch (such that others > can follow and (who knows) maybe help? > > Also, I'm seeing your discussing upstream (without much immediate success). > > Seems like emscripten is a bit of a bad fit for Debian, especially as it's > in the key package set.
Sorry for the delay. I've just pushed my changes to debian/latest on salsa. Besides the fact that the autopkgtest suite still fails, as discussed, here are some more minor issues that could be addressed: (1) DFSG-issues: * source-is-missing [third_party/socket.io.js] This file seems to be a concatenation of several different JS files: there are about 15 (mostly identical) copyright notices in it; it also embeds SWFObject in its minified form. Sorting this out might be a pain. * The two files in site/source/_themes/emscripten_sphinx_rtd_theme/static/css/ are both minified with no indication of their source. Perhaps they are just taken from the original sphinx_rtd_theme? Since I've migrated away from this bespoke theme to the standard RTD theme, these files could just be excluded. (2) Upstream version number: lintian complains about "~dfsg" instead of "+dfsg"; I've changed d/watch and d/rules so that the next version can use "+dfsg" instead. (3) Compatibility issues: As discussed, the version of emscripten is closely tied to the versions of LLVM and binaryen, and not necessarily in a reliable way. I suggest that we add some sort of script in debian/, that is called from both uscan (so referenced in the d/watch file) and from an early step in d/rules (eg execute_after_dh_testdir) that looks at the upstream version number and checks that it's compatible with the versions of LLVM and binaryen listed in d/control. So we would hard-code into this script that emscripten 3.1.62, say, is compatible with llvm-19 and binaryen 122; if the upstream version isn't listed, then it will exit with a warning message and error, pointing to the GitHub discussions. This will help to ensure that future developers don't unknowingly update the package without checking for compatibility. Best wishes, Julian
