Your message dated Sat, 28 Sep 2024 08:35:20 +0000 with message-id <e1susva-0018wv...@fasolo.debian.org> and subject line Bug#1014547: fixed in mlucas 20.1.1-1.1 has caused the Debian Bug report #1014547, regarding mlucas: FTBFS on arm* because of wrong fopen() to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1014547: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014547 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: mlucas Version: 20.1.1-1 Severity: serious Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu kinetic ubuntu-patch Hi Alex, The new version of mlucas in unstable is failing to build on arm* architectures where it previously built, because upstream has introduced some wrong architecture-specific cpu-checking code: [...] make check-TESTS make[2]: Entering directory '/<<PKGBUILDDIR>>' Mlucas 20.1.1 http://www.mersenneforum.org/mayer/README.html System total RAM = 11954, free RAM = 8417 ERROR: at line 1913 of file upstream/src/util.c Assertion failed: /proc/cpuinfo file not found! [...] (https://buildd.debian.org/status/fetch.php?pkg=mlucas&arch=arm64&ver=20.1.1-1&stamp=1641070740&raw=0) The problem is that upstream/src/util.c is calling mlucas_fopen(), which mangles the argument to prefix it with $HOME/.mlucas.d/. So first of all, '$HOME' should never appear in the argument to the openat() syscall; this fopen wrapper function is failing to do variable interpolation for the home directory. And secondly, /proc/cpuinfo should never be relative to the mlucas directory - this is a system path. I've uploaded the attached patch to Ubuntu, fixing the build regression there. Please consider including in Debian as well. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.orgdiff -Nru mlucas-20.1.1/debian/patches/fopen-on-arm.patch mlucas-20.1.1/debian/patches/fopen-on-arm.patch --- mlucas-20.1.1/debian/patches/fopen-on-arm.patch 1969-12-31 16:00:00.000000000 -0800 +++ mlucas-20.1.1/debian/patches/fopen-on-arm.patch 2022-07-07 09:40:44.000000000 -0700 @@ -0,0 +1,22 @@ +Description: don't use mlucas_fopen() for system files + mlucas_fopen() is a wrapper around fopen() that rewrites the path in + various cases. It is not an appropriate interface for opening system + files like /proc/cpuinfo, and causes the mlucas binary to be completely + broken on ARM architectures. +Author: Steve Langasek <steve.langa...@ubuntu.com> +Forwarded: no +Last-Update: 2022-07-07 + +Index: mlucas-20.1.1/upstream/src/util.c +=================================================================== +--- mlucas-20.1.1.orig/upstream/src/util.c ++++ mlucas-20.1.1/upstream/src/util.c +@@ -1909,7 +1909,7 @@ + int has_asimd(void) + { + char in_line[STR_MAX_LEN]; +- FILE*fp = mlucas_fopen("/proc/cpuinfo", "r"); ++ FILE*fp = fopen("/proc/cpuinfo", "r"); + ASSERT(HERE, fp != 0x0, "/proc/cpuinfo file not found!"); + while(fgets(in_line, STR_MAX_LEN, fp) != 0x0) { + if(strstr(in_line, "asimd") != 0) diff -Nru mlucas-20.1.1/debian/patches/series mlucas-20.1.1/debian/patches/series --- mlucas-20.1.1/debian/patches/series 1969-12-31 16:00:00.000000000 -0800 +++ mlucas-20.1.1/debian/patches/series 2022-07-07 09:39:00.000000000 -0700 @@ -0,0 +1 @@ +fopen-on-arm.patch
--- End Message ---
--- Begin Message ---Source: mlucas Source-Version: 20.1.1-1.1 Done: Bill Allombert <ballo...@debian.org> We believe that the bug you reported is fixed in the latest version of mlucas, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1014...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Bill Allombert <ballo...@debian.org> (supplier of updated mlucas package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 27 Sep 2024 22:27:58 +0200 Source: mlucas Architecture: source Version: 20.1.1-1.1 Distribution: unstable Urgency: medium Maintainer: Alex Vong <alexvong.k8...@simplelogin.com> Changed-By: Bill Allombert <ballo...@debian.org> Closes: 1013910 1014547 1027776 1080048 1081082 Changes: mlucas (20.1.1-1.1) unstable; urgency=medium . * Non-maintainer upload. (Closes: #1080048) Mlucas author, Mr Ernst Mayer, sadly passed away in 2023, see <https://www.mersenneforum.org/node/22279?t=28890> He will be missed. Consider this package as a tribute to him. * New patch fopen-on-arm.patch from Steve Langasek (Closes: #1014547) * debian/control: - Fix maintainer address. (Closes: #1013910) * debian/rules: - Apply patch from Steve Langasek (Closes: #1027776) - build with -Wno-incompatible-pointer-types (Closes: #1081082) Checksums-Sha1: 1e829c92496fc278fc3c3d212b9fe0614157ec67 2282 mlucas_20.1.1-1.1.dsc 08248b406f142f43a23d225f0e3f43fcca6f13bf 19568 mlucas_20.1.1-1.1.debian.tar.xz 4b191ba3cd487237f26b60eb37f3242c6b162cc2 5766 mlucas_20.1.1-1.1_source.buildinfo Checksums-Sha256: 65f7ebfb48269a6d9262b771eb590439fee5275f0f2d076689a1535d998c0e66 2282 mlucas_20.1.1-1.1.dsc 27c7e3426e8c34a455f21fe6c1d6dbb86b1026df90957f26446af485390b6a57 19568 mlucas_20.1.1-1.1.debian.tar.xz 231ffbc349a84e68b981b9517927317acc3e6ee1a04e8e3acf14db0996f271ed 5766 mlucas_20.1.1-1.1_source.buildinfo Files: bc35fd9a1d61aa090d0f0949c3560a07 2282 math optional mlucas_20.1.1-1.1.dsc 472a61fe4d7bc3758c88c5debf8d1de9 19568 math optional mlucas_20.1.1-1.1.debian.tar.xz bcccc4bbcb564b0fb08209a7b0f9779e 5766 math optional mlucas_20.1.1-1.1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEQgKOpASi6dgKxFMUjw58K0Ui44cFAmb3ui0ACgkQjw58K0Ui 44fYgBAAtwfYOHfISTbD/2i395fYMJJEQzAygnquUgplWPZqjyomuG1jtduZVH2j v6cnYEXZQxwK7CTRZ+aXMzIxVwip3/7x6TMhCyY8H07K0JcbXa15xIE1sTmgjCCW 6WhyivQQ14ZODBVsS6zr27kqEBhBK8UsLrzw9a073iim5PYop3cvmWyfekfNU08b IpAiRhF9OYFXQTS3J/ZbsOvwlPFfMM/O9sUTucIn0GNsuR5QuMQ11YkPVZCBpF4D WsdDNfiHeC5IztcKLHuVGcUYgT4s2e3KnjSqlQlNnL5ntZ+e/54btR2FkHxYtDJV quyIgCngv8bvn1jEqLjwt3MaHBxpII/p+GBXB34kEWHEPOpaDo1wuSAhY0M2SnDf yWyOh4o22dvIlhf01LUukEkub68W8/67ZQ5OgOPAJyunfCUd+UIbHXnDKClYj83s zVllisrcWzBGZ7jkEFRqC+YCn4zxs3PgankMdY0R33dOKL6jZzzjymW9gJUornIg UHEBs3h/ua3F+Cy7dYa3cV1ijgErOUU+j9nPOF9SSvJbD+EOrFKrIn2a90G0R2q4 2W7Qm4d4dbhEL5DW7/JbPftjkEuRcpeAI3wAWLQs3rBJNGy3EZ5RCXgmni63/Rsr b9l3ZKeQkIiPcX/iwCMZ+pStZKeSqn/kVvoapILkifsJRSi3c7I= =i1oz -----END PGP SIGNATURE-----
pgphuP0fQi_Fr.pgp
Description: PGP signature
--- End Message ---
