Hi, On Wed, 14 Aug 2024, at 09:16, Helmut Grohne wrote: > Chris and others indicated that failing preinst would be too strong. > After all, the system will continue to run and boot. Just other pieces > like proprietary software also installed may fall apart. As a > compromise, a critical debconf prompt was suggested. I've implemented > that approach and attach an updated patch. > > I think the trade-off is fairly reasonable now. In the common case > (where /bin/sh -> dash), debconf isn't used at all and dash's own > diversion is deleted. In the rare event of there being a different > diversion without a matching /usr/bin/sh diversion, a critical debconf > error is raised and displayed to the user for confirmation. Before > continuing, they may duplicate the diversion. When > DEBIAN_FRONTEND=noninteractive (such as during mmdebstrap), the message > is still displayed, but does not require confirmation. With that, I > think we will get the message to most affected users and in particular > to users where /bin/sh points to mksh or bash.
Thanks. I’ve reworded the messages to be slightly more user-friendly, what do you think? This update to dash moves /bin/sh to /usr/bin/sh, but your system has a local diversion of /bin/sh. Since there is no new diversion of the new location /usr/bin/sh, this local diversion will no longer work, making dash the default shell. . To prevent this message from appearing again, remove the local diversion of /bin/sh. To continue using the alternative default shell of your choice, create another diversion for /usr/bin/sh. -- Cheers, Andrej
