Your message dated Mon, 29 Jul 2024 08:35:21 +0200
with message-id <zqc4ky8mevy8t...@grub.nussbaum.fr>
and subject line Re: Bug#1077355: gretl: FTBFS: ../lib/src/interact.c:2131:19:
error: implicit declaration of function 'try_http'
[-Wimplicit-function-declaration]
has caused the Debian Bug report #1077355,
regarding gretl: FTBFS: ../lib/src/interact.c:2131:19: error: implicit
declaration of function 'try_http' [-Wimplicit-function-declaration]
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1077355: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1077355
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: gretl
Version: 2024b-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240727 ftbfs-trixie
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> ../libtool --mode=compile gcc -fopenmp -c -g -O2
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -D_REENTRANT -I.. -I.. -I../lib/src
> -I/usr/include/libxml2 -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
> -pthread -I/usr/share/R/include
> -I/usr/lib/x86_64-linux-gnu/openmpi/include -DHAVE_CONFIG_H
> -DLIBDIR=\"/usr/lib\" -o interact.lo ../lib/src/interact.c
> libtool: compile: gcc -fopenmp -c -g -O2
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -D_REENTRANT -I.. -I.. -I../lib/src
> -I/usr/include/libxml2 -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6
> -pthread -I/usr/share/R/include -I/usr/lib/x86_64-linux-gnu/openmpi/include
> -DHAVE_CONFIG_H -DLIBDIR=\"/usr/lib\" ../lib/src/interact.c -fPIC -DPIC -o
> .libs/interact.o
> ../lib/src/interact.c: In function 'open_append_stage_1':
> ../lib/src/interact.c:2131:19: error: implicit declaration of function
> 'try_http' [-Wimplicit-function-declaration]
> 2131 | err = try_http(cmd->param, op->fname, NULL);
> | ^~~~~~~~
> make[2]: *** [Makefile:327: interact.lo] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/07/27/gretl_2024b-1_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240727;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240727&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
--- End Message ---
--- Begin Message ---
On 28/07/24 at 21:48 -0500, Dirk Eddelbuettel wrote:
>
> On 28 July 2024 at 20:52, Cottrell, Allin wrote:
> | On Sun, Jul 28, 2024 at 3:33 PM Dirk Eddelbuettel <e...@debian.org> wrote:
> | >
> | >
> | > On 28 July 2024 at 15:11, Cottrell, Allin wrote:
> | > | On Sun, Jul 28, 2024 at 1:29 PM Dirk Eddelbuettel <e...@debian.org>
> wrote:
> | [...]
> | > | > | > ../lib/src/interact.c: In function 'open_append_stage_1':
> | > | > | > ../lib/src/interact.c:2131:19: error: implicit declaration of
> function 'try_http' [-Wimplicit-function-declaration]
> | > | > | > 2131 | err = try_http(cmd->param, op->fname, NULL);
> | > | > | > | ^~~~~~~~
> | > | > | > make[2]: *** [Makefile:327: interact.lo] Error 1
> | > | >
> | > | > That looks like one of the simple issues where the newer compiler
> (and I
> | > | > checked that this was gcc-14) is pickier about includes.
> | > | >
> | > | > Allin: Have you seen this already upstream, and better still, fixed
> already?
> | > |
> | > | Hmm, try_http() is declared in lib/src/gretl_www.h, which is included
> | > | in interact.c provided that USE_CURL is defined. And in a full build
> | > | of gretl I'd expect USE_CURL to be defined; without that we drop all
> | > | internet interaction. I guess it's a bug that the call to try_http()
> | > | in interact.c is not itself guarded by USE_CURL, and that's now done
> | > | in git. If that doesn't solve the problem, the question that arises is
> | > | why USE_CURL is (apparently) not getting defined.
> | >
> | > Good catch, and analysis.
> | >
> | > We always turn curl on in the Debian builds. I have a build-depends on
> | > libcurl4-gnutls-dev | libcurl4-dev
> | > and the libgretl package depends on
> | > libcurl3t64-gnutls (>= 7.56.1)
> | > (where thr t64 suffix is for a Debian-internal transition we did to become
> | > 'year 2038' resistant by switching to 'bigger' time types).
> | >
> | > So that sounds like you spot on that maybe the file in question did not
> have
> | > #define guards, the older compiler was tolerant but gcc-14 nags?
> |
> | Actually, no. I checked with gcc version 14.1.1 20240720 on Arch and
> | got no error or warning, while the build log at
> |
> | http://qa-logs.debian.net/2024/07/27/gretl_2024b-1_unstable.log
> |
> | shows, among other output from the configure script:
> |
> | checking for CURL... no
> |
> | So it was the actual bug (now fixed in git) where USE_CURL was not
> | defined but try_http() was referenced, not a virtual/potential bug
> | whereby the compiler somehow detected that try_http() _could_ in
> | principle be referenced without USE_CURL being defined. So why did the
> | CURL check fail? Well, in configure.ac the check is:
> |
> | PKG_CHECK_MODULES(CURL, libcurl >= 7.13.0, have_curl="yes", have_curl="no")
> |
> | Do you have an idea why this could now be failing when it didn't before?
>
> Hm. Checking my last local build here (where I have a decade+ of local build
> logs) for the most recent 2024b-1 build:
>
> checking for FFTW... yes
> checking for CURL... yes
> checking for GLIB... yes
>
> So not sure why I would have it, but Lucas in his bulk rebuild does not?
>
> checking for FFTW... yes
> checking for CURL... no
> checking for GLIB... yes
>
> Lucas, any idea?
Hi Dirk,
curl was temporarily broken (fixed in 8.9.0-3 I think). I confirm that gretl
builds
fine now.
Lucas
--- End Message ---
