Control: tags -1 patch

Dear Maintainer,

On Wed, 03 Jul 2024 12:33:17 +0000 Matthias Klose <d...@debian.org> wrote:
> Package: src:libgdchart-gd2
> Version: 0.11.5-12
> Severity: important
> Tags: sid trixie
> User: debian-...@lists.debian.org
> Usertags: ftbfs-gcc-14
>
> [This bug is targeted to the upcoming trixie release]
>
> Please keep this issue open in the bug tracker for the package it
> was filed for. If a fix in another package is required, please
> file a bug for the other package (or clone), and add a block in this
> package. Please keep the issue open until the package can be built in
> a follow-up test rebuild.
>
> The package fails to build in a test rebuild on at least amd64 with
> gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
> severity of this report will be raised before the trixie release.
>
> The full build log can be found at:
> http://qa-logs.debian.net/2024/07/01/libgdchart-gd2_0.11.5-12_unstable_gccexp.log
> The last lines of the build log are at the end of this report.
>
> To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
> or install the gcc, g++, gfortran, ... packages from experimental.
>
> apt-get -t=experimental install g++
>
> Common build failures are new warnings resulting in build failures with
> -Werror turned on, or new/dropped symbols in Debian symbols files.
> For other C/C++ related build failures see the porting guide at
> http://gcc.gnu.org/gcc-14/porting_to.html
>
> [...]
> APT_CONFIG=/var/lib/sbuild/apt.conf
> HOME=/sbuild-nonexistent
> LANG=C.UTF-8
> LC_ALL=C.UTF-8
> LOGNAME=user42
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
> SCHROOT_ALIAS_NAME=unstable
> SCHROOT_CHROOT_NAME=sid-amd64-sbuild
> SCHROOT_COMMAND=env
> SCHROOT_GID=1001
> SCHROOT_GROUP=user42
> SCHROOT_SESSION_ID=sid-amd64-sbuild-b08d883a-0162-46e2-b2eb-b6ac47798835
> SCHROOT_UID=1001
> SCHROOT_USER=user42
> SHELL=/bin/sh
> USER=user42
>
> dpkg-buildpackage
> -----------------
>
> Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot
> dpkg-buildpackage: info: source package libgdchart-gd2
> dpkg-buildpackage: info: source version 0.11.5-12
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Michael R. Crusoe <cru...@debian.org>
> dpkg-source --before-build .

I fixed this bug, and I have just uploaded it to DELAYED/5 (see source debdiff enclosed).
I would happily delay it longer or cancel it upon request from you.

Best wishes,

--
Pierre
diff -Nru libgdchart-gd2-0.11.5/debian/changelog libgdchart-gd2-0.11.5/debian/changelog
--- libgdchart-gd2-0.11.5/debian/changelog	2024-03-21 13:02:15.000000000 +0100
+++ libgdchart-gd2-0.11.5/debian/changelog	2024-07-27 14:30:47.000000000 +0200
@@ -1,3 +1,10 @@
+libgdchart-gd2 (0.11.5-12.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fixing build with GCC-14 (Closes: #1075170)
+
+ -- Pierre Gruet <p...@debian.org>  Sat, 27 Jul 2024 14:30:47 +0200
+
 libgdchart-gd2 (0.11.5-12) unstable; urgency=medium
 
   * Team upload.
diff -Nru libgdchart-gd2-0.11.5/debian/patches/gcc14.patch libgdchart-gd2-0.11.5/debian/patches/gcc14.patch
--- libgdchart-gd2-0.11.5/debian/patches/gcc14.patch	1970-01-01 01:00:00.000000000 +0100
+++ libgdchart-gd2-0.11.5/debian/patches/gcc14.patch	2024-07-27 14:30:47.000000000 +0200
@@ -0,0 +1,32 @@
+Description: adding an intermediate function with suitable type and casting to
+ build against GCC-14
+Author: Pierre Gruet <p...@debian.org>
+Bug-Debian: https://bugs.debian.org/1075170
+Forwarded: no
+Last-Update: 2024-07-27
+
+--- a/gdc_pie.c
++++ b/gdc_pie.c
+@@ -103,6 +103,13 @@
+ 	return 0;
+ }
+ 
++static int
++ocmpr_void(const void *a,
++	   const void *b )
++{
++    return ocmpr((struct tmp_slice_t *)(a), (struct tmp_slice_t *)(b));
++}
++
+ /* ======================================================= *\ 
+  * PIE
+  * 
+@@ -476,7 +483,7 @@
+ 					}
+ 				}
+ 
+-		qsort( tmp_slice, num_slice_angles, sizeof(struct tmp_slice_t), ocmpr );
++		qsort( tmp_slice, num_slice_angles, sizeof(struct tmp_slice_t), ocmpr_void );
+ 		for( t=0; t<num_slice_angles; ++t )
+ 			{
+ 			gdPoint	gdp[4];
diff -Nru libgdchart-gd2-0.11.5/debian/patches/series libgdchart-gd2-0.11.5/debian/patches/series
--- libgdchart-gd2-0.11.5/debian/patches/series	2024-03-19 16:02:29.000000000 +0100
+++ libgdchart-gd2-0.11.5/debian/patches/series	2024-07-27 14:28:45.000000000 +0200
@@ -1,3 +1,4 @@
 1001_sane_makefile.patch
 1002_saner_makefile.patch
 1003_missing_include_and_def.patch
+gcc14.patch

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to