test_migration.py::TestMigration::test_migrate_user_model)

Debian Bug Tracking System Tue, 23 Jul 2024 23:21:17 -0700

Your message dated Wed, 24 Jul 2024 06:19:39 +0000
with message-id <e1swvlf-0088ur...@fasolo.debian.org>
and subject line Bug#1076820: fixed in onboard 1.4.1-9
has caused the Debian Bug report #1076820,
regarding onboard: FTBFS on riscv64: FAILED 
Onboard/test/test_migration.py::TestMigration::test_migrate_user_model
to be marked as done.


This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1076820: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076820
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

--- Begin Message ---

Source: onboard
Version: 1.4.1-8
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: debian-ri...@lists.debian.org
User: debian-ri...@lists.debian.org
Usertags: riscv64

Dear maintainer,

onboard fails to build with a testsuite error on riscv64 since it has
been enabled in version 1.4.1-6:

| I: pybuild base:311: cd 
/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build; python3.12 -m pytest 
| task-0: ============================= test session starts 
==============================
| task-0: platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0
| task-0: rootdir: /<<PKGBUILDDIR>>
| task-0: collected 7 items
| task-0: 
| task-0: Onboard/test/test_LayoutLoaderSVG.py ....                             
   [ 57%]
| task-0: Onboard/test/test_migration.py F.                                     
   [ 85%]
| task-0: Onboard/test/test_translations.py .                                   
   [100%]
| task-0: 
| task-0: =================================== FAILURES 
===================================
| task-0: ____________________ TestMigration.test_migrate_user_model 
_____________________
| task-0: 
| task-0: self = <Onboard.test.test_migration.TestMigration 
testMethod=test_migrate_user_model>
| task-0: 
| task-0:     def test_migrate_user_model(self):
| task-0:         tests = [
| task-0:             [
| task-0:                 # old user.lm becomes new model of system language
| task-0:                 [
| task-0:                     ['user.lm', 1],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['en_US.lm', 1],
| task-0:                 ]
| task-0:             ],
| task-0:             [
| task-0:                 # a backup model is renamed too
| task-0:                 [
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['en_US.lm', 1],
| task-0:                     ['en_US.lm.bak', 2],
| task-0:                 ]
| task-0:             ],
| task-0:             [
| task-0:                 # a backup alone is ignored
| task-0:                 [
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ]
| task-0:             ],
| task-0:             [
| task-0:                 # must not overwrite existing files
| task-0:                 [
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                     ['en_US.lm', 3],
| task-0:                     ['en_US.lm.bak', 4],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['en_US.lm', 3],
| task-0:                     ['en_US.lm.bak', 4],
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ]
| task-0:             ],
| task-0:             [
| task-0:                 # must not overwrite existing backup model
| task-0:                 [
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                     ['en_US.lm.bak', 4],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['en_US.lm', 1],
| task-0:                     ['en_US.lm.bak', 4],
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ]
| task-0:             ],
| task-0:             [
| task-0:                 # must not overwrite existing model
| task-0:                 [
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                     ['en_US.lm', 3],
| task-0:                 ],
| task-0:                 [
| task-0:                     ['en_US.lm', 3],
| task-0:                     ['user.lm', 1],
| task-0:                     ['user.lm.bak', 2],
| task-0:                 ]
| task-0:             ],
| task-0:         ]
| task-0:     
| task-0:         os.mkdir(self._user_dir)    # foil user dir migration
| task-0:         os.mkdir(self._model_dir)
| task-0:     
| task-0:         for i, (_input, _output) in enumerate(tests):
| task-0:             for fn, size in _input:
| task-0:                 self._touch(os.path.join(self._model_dir, fn), size)
| task-0:     
| task-0:             with self._run_onboard() as p:
| task-0: >               self.assertEqual(_output,
| task-0:                                  self._get_model_files(), "test " + 
str(i))
| task-0: E               AssertionError: Lists differ: [['en_US.lm', 1]] != 
[['user.lm', 1]]
| task-0: E               
| task-0: E               First differing element 0:
| task-0: E               ['en_US.lm', 1]
| task-0: E               ['user.lm', 1]
| task-0: E               
| task-0: E               - [['en_US.lm', 1]]
| task-0: E               ?     ^^^^
| task-0: E               
| task-0: E               + [['user.lm', 1]]
| task-0: E               ?    ++ ^
| task-0: E                : test 0
| task-0: 
| task-0: Onboard/test/test_migration.py:125: AssertionError
| task-0: =============================== warnings summary 
===============================
| task-0: 
../../../../../../usr/lib/python3/dist-packages/gi/overrides/Gio.py:239
| task-0:   /usr/lib/python3/dist-packages/gi/overrides/Gio.py:239: 
DeprecationWarning: Gio.Settings.list_keys is deprecated
| task-0:     return key in self.list_keys()
| task-0: 
| task-0: -- Docs: 
https://docs.pytest.org/en/stable/how-to/capture-warnings.html
| task-0: =========================== short test summary info 
============================
| task-0: FAILED 
Onboard/test/test_migration.py::TestMigration::test_migrate_user_model
| task-0: ==================== 1 failed, 6 passed, 1 warning in 6.35s 
====================
| E: pybuild pybuild:389: test: plugin distutils failed with: exit code=1: cd 
/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onboard/build; python3.12 -m pytest 

A full build log is available here:
https://buildd.debian.org/status/fetch.php?pkg=onboard&arch=riscv64&ver=1.4.1-8&stamp=1721643296&raw=0

I have debugged the issue and it appears to be a timing issue. onboard
is killed after running for 1 second, which is not enough for it to act
on the riscv64 buildds. Increasing this timeout to 3 second like in the
patch below fixes the issue:

--- onboard-1.4.1.orig/Onboard/test/test_migration.py
+++ onboard-1.4.1/Onboard/test/test_migration.py
@@ -141,7 +141,7 @@ class TestMigration(unittest.TestCase):
             env["LANG"] = "en_US.UTF-8"
 
             p = subprocess.Popen(["./onboard"], env=env)
-            time.sleep(1)
+            time.sleep(3)
             yield p
 
         finally:

Regards
Aurelien

--- End Message ---

--- Begin Message ---

Source: onboard
Source-Version: 1.4.1-9
Done: Mike Gabriel <sunwea...@debian.org>

We believe that the bug you reported is fixed in the latest version of
onboard, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1076...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Gabriel <sunwea...@debian.org> (supplier of updated onboard package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 24 Jul 2024 07:54:48 +0200
Source: onboard
Architecture: source
Version: 1.4.1-9
Distribution: unstable
Urgency: medium
Maintainer: Debian+Ubuntu MATE Packaging Team <debian-m...@lists.debian.org>
Changed-By: Mike Gabriel <sunwea...@debian.org>
Closes: 1076820
Changes:
 onboard (1.4.1-9) unstable; urgency=medium
 .
   * debian/patches:
     + Add 1013_slow-down-tests-for-riscv64.patch. Give the unit test / onboard
       startup more time before killing onboard again. Fixes unit tests on 
slower
       architectures such as RISCV64. (Closes: #1076820). Thanks to Aurelien
       Jarno for debugging this and for providing a patch.
Checksums-Sha1:
 d4a725f9c232f91ad8cde488dd5f1d550547762c 2885 onboard_1.4.1-9.dsc
 e395919f1238cb25bed1b3cf40dec05d5b8cdc41 32340 onboard_1.4.1-9.debian.tar.xz
 d241478f5c3fb43907a17cf3e67b643d8a2db509 18509 onboard_1.4.1-9_source.buildinfo
Checksums-Sha256:
 1811c1972aee8b28a11a9e87ceff28815f41c9b96996730d51b3c9d75fdd1506 2885 
onboard_1.4.1-9.dsc
 14993d872b8b047444a542b1113834a06fb6214e2ecd783a6df2bf9252f4797e 32340 
onboard_1.4.1-9.debian.tar.xz
 a27a0ea4a880b0c33a3b3f94ea11112f8abb77c5e53c9e13346f0d5c1c2a5648 18509 
onboard_1.4.1-9_source.buildinfo
Files:
 847f8fd303158465cd48536fa80e5dec 2885 gnome optional onboard_1.4.1-9.dsc
 3a1e9287d2ca0d63874528978a281c00 32340 gnome optional 
onboard_1.4.1-9.debian.tar.xz
 83dd2f4acb74e98de8d5e1cf22104e34 18509 gnome optional 
onboard_1.4.1-9_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmagl/kVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxKwIP/16Z3bZlsHRj5NLdNUNkzE/OEBk1
a1RP5Edzaux3OmzdcUWSSLnlgP8qFjW/kjxjoO4X9anPHq5bFqgXNq4NpuWQEBdX
Rsr8qLcp4k/YRxQfczJkzx0zaeSJ5uwLYoWSs8qYvBhKTrLRr3T5DyH+BpDA1tq7
n+Y+0s4nxrpQ6K9gBGZWGVLBkml3c/+IoMTHgyZzgKV14NoRfOIX+n9Oz6fpNUxs
KEfrpbfXOqVP8VTPXAsYeSyqRFjI3h8uAXJl0qMFzMitPVtTs+X1Unbb5BTUmfAC
OkfsR2AEWGXjtEej2EmOGE8BhDl1MS6IAs/ABt4CXLRNuv8R6D7fmG2ccqxSZc9T
hicm6Ra8apYogIJKdgjIgqDB+iDGFmHCxqWcu0cXZd1mR+1uxtaipCyCVeoZ6tsV
mvV0zpwc2bfvreblEVQyco0Z2t+zc/tG8X+f9arTAG5tDfgxKqnEdutUFWGGG43B
k86MK2izBfJtL9u9cR6c1fI37tQbCgSQs2eOXcZ5UElh9MWrO2zgWgjLXo9HY5U5
ZQTROJKnvBDgxEFSTyuA6vrtZyTXhw7QFfQpR/om5AkBF0hOaZ53HHNNNP10L2IC
0CbhwBIK5DpXH3FzlzM2f4Gu4kg+SEsNEwPdcDgiZonFNZ7H6+o2nDqVXUDjoZlC
Yr0hFdJKoKB9d3JF
=dw2E
-----END PGP SIGNATURE-----

pgpB_xOjKMeqW.pgp
Description: PGP signature

--- End Message ---

Bug#1076820: marked as done (onboard: FTBFS on riscv64: FAILED Onboard/test/test_migration.py::TestMigration::test_migrate_user_model)

Reply via email to