Your message dated Mon, 24 Jun 2024 10:04:47 +0000
with message-id <e1slgz5-00fssc...@fasolo.debian.org>
and subject line Bug#1073996: fixed in twisted 24.3.0-2
has caused the Debian Bug report #1073996,
regarding twisted: autopkgtest fails on test_flatten: "builtins.KeyError:
'root'"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1073996: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1073996
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: twisted
Version: 24.3.0-1
Severity: serious
Tags: patch
Justification: 6a
X-Debbugs-Cc: florent.jacq...@canonical.com
Hello there,
Following some removal from Python itself, the following started to appear in
autopkgtest:
2993s --- <exception caught here> ---
2993s File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line
1999, in _inlineCallbacks
2993s result = context.run(
2993s File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line
519, in throwExceptionIntoGenerator
2993s return g.throw(self.value.with_traceback(self.tb))
2993s File "/usr/lib/python3/dist-packages/twisted/web/_flatten.py", line
435, in _flattenTree
2993s roots.append(frame.f_locals["root"])
2993s builtins.KeyError: 'root'
This is fixed upstream in https://github.com/twisted/twisted/pull/12213
I've cherry-picked the needed changes in a patch. I'll send a debdiff with
everything shortly.
-- System Information:
Debian Release: trixie/sid
APT prefers oracular
APT policy: (500, 'oracular'), (400, 'oracular-proposed'), (200,
'noble-updates'), (200, 'noble'), (200, 'jammy-updates'), (200, 'jammy')
Architecture: amd64 (x86_64)
Kernel: Linux 6.8.0-31-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
From: Florent 'Skia' Jacquet <florent.jacq...@canonical.com>
Date: Fri, 21 Jun 2024 12:06:48 +0200
Subject: Test: Fix twisted.web.test.test_flatten
Following some removal from Python itself, the following started to appear in
autopkgtest:
2993s --- <exception caught here> ---
2993s File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line
1999, in _inlineCallbacks
2993s result = context.run(
2993s File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line
519, in throwExceptionIntoGenerator
2993s return g.throw(self.value.with_traceback(self.tb))
2993s File "/usr/lib/python3/dist-packages/twisted/web/_flatten.py", line
435, in _flattenTree
2993s roots.append(frame.f_locals["root"])
2993s builtins.KeyError: 'root'
This is fixed upstream in https://github.com/twisted/twisted/pull/12213
This patch is a cherry-pick of the needed changes, and can probably be dropped
next release.
--- a/src/twisted/web/_flatten.py
+++ b/src/twisted/web/_flatten.py
@@ -428,11 +427,11 @@
except StopIteration:
stack.pop()
except Exception as e:
- stack.pop()
roots = []
for generator in stack:
- roots.append(generator.gi_frame.f_locals["root"])
- roots.append(frame.f_locals["root"])
+ if generator.gi_frame is not None:
+ roots.append(generator.gi_frame.f_locals["root"])
+ stack.pop()
raise FlattenerError(e, roots, extract_tb(exc_info()[2]))
else:
stack.append(element)
--- End Message ---
--- Begin Message ---
Source: twisted
Source-Version: 24.3.0-2
Done: Florent 'Skia' Jacquet <florent.jacq...@canonical.com>
We believe that the bug you reported is fixed in the latest version of
twisted, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1073...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Florent 'Skia' Jacquet <florent.jacq...@canonical.com> (supplier of updated
twisted package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 24 Jun 2024 10:50:35 +0100
Source: twisted
Architecture: source
Version: 24.3.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <team+pyt...@tracker.debian.org>
Changed-By: Florent 'Skia' Jacquet <florent.jacq...@canonical.com>
Closes: 1073996
Changes:
twisted (24.3.0-2) unstable; urgency=medium
.
* Team upload.
* Patch: fix test_flatten in autopkgtest. (Closes: #1073996)
This patch can probably be dropped after next upstream release.
Checksums-Sha1:
2bbef5f37fbfa356863f983dff2278dc9cb1d407 2617 twisted_24.3.0-2.dsc
f3bbd932a34784bc2041e9256855ed4961c87a96 36492 twisted_24.3.0-2.debian.tar.xz
Checksums-Sha256:
fa02dee1b8226ec19b3f3e578e7133b570469c895bfc0ebf516ff71035cbb0c1 2617
twisted_24.3.0-2.dsc
787841db5e62c90472b17bc60fbba1ded82fa0ae8dbc2645dd2483d0f9d191d7 36492
twisted_24.3.0-2.debian.tar.xz
Files:
e325a55cff448f91b3221c8fd0a10952 2617 python optional twisted_24.3.0-2.dsc
39b4f1f8ec38f248d5e2cc56eb644e64 36492 python optional
twisted_24.3.0-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAmZ5QbsACgkQOTWH2X2G
UAuI4A//cH2TCJEZq1ZPQq2WZqj80hoAdCkzTkTNvB/3FI1SzFWEnluUVqNbPAD7
omwd/ptvajwzlcX0iAOQ27uQDdImw4sqTbuoU0NqctJHEFzmo9Jw9bnF617KSf8h
t8qBfXeiiGoncDprN0JLZ59sk0A090EJx5WgGs0GW0QYJlFcR38KWmniym9d5ug/
cAEDv1RTGogIqfdkN1iylU832dBWAZzO8/TEbgjc+/lA9vjnmqgKtBeGGiPn89VB
xfD1+rXuU9Uf/xGQNh44EK7qdKN4R3sFgZBpI7jmFXzVHy55Q1CR4ys5uXyqvwrQ
JB61F2Fj/mmS+XSxBn8asCTuaLYImrVYbcrogNCCF+Q9UXxSZFTdtn0v4XsmpS/T
ha45kSrHjvfBSdKgMuyxGjkrkHs1hboNRGhYSFWmMay/pRJM38Hp/Jox58Z+FdeR
cGNV1wAAtVWGDINeuQMqnNgg5kxnC1jH7Farx4CKa/fqQB8UBv7+KFQKFDynHA6t
STp5fcA9IQ3LoTEdh5Chbowam1A282WwlreKuVnSKPf4YHHAcdvM6+De2/h8Phhu
mXgBeEI6drR6eHis5HiGa2+GTn4/iI86yKOb/RHQQNK8rXFSNwja5lEp25NGR474
l92+gFE81dcSrrtgANgm2wMbVAynGz9ojh/fh4Zj1JsZyTVRkcU=
=BHjb
-----END PGP SIGNATURE-----
pgpGakqoXvDkL.pgp
Description: PGP signature
--- End Message ---
