Your message dated Sat, 01 Jun 2024 08:34:05 +0000
with message-id <e1sdkbh-00ctam...@fasolo.debian.org>
and subject line Bug#1069859: fixed in atop 2.10.0-3
has caused the Debian Bug report #1069859,
regarding atop: Fix atop for 64-bit time_t on arm
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1069859: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069859
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: atop
Version: 2.10.0-2
Severity: grave
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Hi Marc,
Although atop currently builds successfully on armhf and armel, it is broken
at runtime because it tries to use a time_t in a format string which now no
longer uses the correct size for the data. This was found in Ubuntu via
autopkgtests (unfortunately, Debian does not run autopkgtests for binNMUs):
358s /tmp/autopkgtest.Nzaczp/build.Xps/src/debian/tests/01-numcpus: line 15:
1136 Segmentation fault (core dumped) atop -P cpu 5 1 1>&2
Please see attached a patch that fixes this issue. It has been uploaded to
Ubuntu.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru atop-2.10.0/debian/patches/64-bit-time-t-compat.patch
atop-2.10.0/debian/patches/64-bit-time-t-compat.patch
--- atop-2.10.0/debian/patches/64-bit-time-t-compat.patch 1969-12-31
16:00:00.000000000 -0800
+++ atop-2.10.0/debian/patches/64-bit-time-t-compat.patch 2024-03-22
11:11:06.000000000 -0700
@@ -0,0 +1,22 @@
+Description: compatibility with 64-bit time_t
+Author: Steve Langasek <steve.langa...@canonical.com>
+Forwarded: no
+Last-Update: 2024-03-22
+
+Index: atop-2.10.0/parseable.c
+===================================================================
+--- atop-2.10.0.orig/parseable.c
++++ atop-2.10.0/parseable.c
+@@ -214,10 +214,10 @@
+ convdate(curtime, datestr);
+ convtime(curtime, timestr);
+
+- snprintf(header, sizeof header, "%s %s %ld %s %s %d",
++ snprintf(header, sizeof header, "%s %s %lld %s %s %d",
+ labeldef[i].label,
+ utsname.nodename,
+- curtime,
++ (long long)curtime,
+ datestr, timestr, numsecs);
+
+ /*
diff -Nru atop-2.10.0/debian/patches/series atop-2.10.0/debian/patches/series
--- atop-2.10.0/debian/patches/series 2024-01-14 12:18:53.000000000 -0800
+++ atop-2.10.0/debian/patches/series 2024-03-22 11:10:13.000000000 -0700
@@ -15,3 +15,4 @@
no-atopgpud
handle-default-file
default
+64-bit-time-t-compat.patch
--- End Message ---
--- Begin Message ---
Source: atop
Source-Version: 2.10.0-3
Done: Marc Haber <mh+debian-packa...@zugschlus.de>
We believe that the bug you reported is fixed in the latest version of
atop, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1069...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Marc Haber <mh+debian-packa...@zugschlus.de> (supplier of updated atop package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 31 May 2024 13:42:28 +0200
Source: atop
Architecture: source
Version: 2.10.0-3
Distribution: unstable
Urgency: medium
Maintainer: Marc Haber <a...@packages.debian.org>
Changed-By: Marc Haber <mh+debian-packa...@zugschlus.de>
Closes: 1063698 1069859
Changes:
atop (2.10.0-3) unstable; urgency=medium
.
* the #gpn22 upload
* fix crash on 64bit time_t.
Thanks to Steve Langasek (Closes: #1069859)
* proper use of pkg-config to allow cross build.
Thanks to Helmut Grohne (Closes: #1063698)
Checksums-Sha1:
fc044d489bf3a03c7f967e2b9721db6b6e7751d5 1935 atop_2.10.0-3.dsc
0d3a3c46e590cbc41319a13cf9be37c1f3530289 16876 atop_2.10.0-3.debian.tar.xz
bd808dc9e0aa6556ea754e684abf72288fd60f9b 6928 atop_2.10.0-3_source.buildinfo
Checksums-Sha256:
eac1cb6f89863d21e5b77dfba19b98f1f25e03c232c935bf76b082eb6c42cdf0 1935
atop_2.10.0-3.dsc
db154f52cb370b562e4e47618f3f495ae5ea4bd8a862d89be378af15cea6fb38 16876
atop_2.10.0-3.debian.tar.xz
3cb3099af09935691792865816ae4f837f5541bda89e19209dfc4ed005476c69 6928
atop_2.10.0-3_source.buildinfo
Files:
bb312549fb3fbce7b68c1bff15d4c350 1935 admin optional atop_2.10.0-3.dsc
a729b9497202beaee8716f7027d53934 16876 admin optional
atop_2.10.0-3.debian.tar.xz
ea57d3aaed8e63bc337b2af759930fdc 6928 admin optional
atop_2.10.0-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE6QL5UJ/L0pcuNEbjj3cgEwEyBEIFAmZatjwACgkQj3cgEwEy
BEKSAhAAgk5hBUkFsc8GLdg1J6u3wHIDHntDr/8wxUdT7X0CYZ0A5N70nPGyhFLb
tgeOvhuZWcyyluCPtUaCIlpBQKU3zCSHWarWZJjZ5jpfPruJmL+FLRfzJvM1L9xl
M2xM2xCrEeh0Dpv4CZLybz0dFsl8K4+tlDiteOdgujUlw0e1sQvRGgZvXmo/8DOO
PKnjs2Z/LAeidVDKGtY6aP+o+u4QsXL6BNnvC+eFJqONkCVWyOLUKMrctCCoOTr0
hakM3mfL/zl8/rkfpZF6gKyK1QISYINP7UXVCYgUXwb+9YqOarW3iXLfpg1kuQ1Z
mvN2/xU/oTg+r4gG/MFgBesYpyu/iKh7mvjNxOdaXe7G1Wsaifd7MjK69d4eidBG
o6rNptMemSUo6jNYSj/N+eV50sQmHfFiH/TdCYrG4nSmv+7iYSXoy4vfEA5hF568
fMYfEp3JoD4hN5H7M7HnrAW9f/PYvSzbZZxkvKGn5K3Qqh6EONmPnsMa1Gk/99WZ
/3YzpAcRtB8AHMePZmdw9JK3Yltxbr+CE9D1Onn7uj708zQv0AID131T4OC5cVHI
bWiUhNwe7/UXqtd/XSnvTzPdJBrxU3t144lh9oOVvzvdviG9VKOhQ4Y57dqMl+HZ
CsdJAn3tyqmTmcxX4zy/eDoLz+Towg9l6grrT8dhslFtBAPv7oM=
=NMSF
-----END PGP SIGNATURE-----
pgpmKRcb016T3.pgp
Description: PGP signature
--- End Message ---
