Your message dated Wed, 29 May 2024 17:52:35 +0000 with message-id <e1scntx-00h9vg...@fasolo.debian.org> and subject line Bug#1072102: fixed in samba 2:4.20.1+dfsg-4 has caused the Debian Bug report #1072102, regarding samba-ad-dc: ineffective replaces due to /usr-move (DEP17) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1072102: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072102 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: samba-ad-dc Version: 2:4.20.1+dfsg-3 Severity: serious Tags: patch User: helm...@debian.org Usertags: dep17p1 Control: affects -1 + samba Hi, /lib/systemd/system/samba-ad-dc.service is part of the samba package in the following versions: * 2:4.13.13+dfsg-1~deb11u5: bullseye * 2:4.13.13+dfsg-1~deb11u6: bullseye-security|bullseye-proposed-updates * 2:4.17.12+dfsg-0+deb12u1: bookworm|bookworm-security * 2:4.17.12+dfsg-0+deb12u1~bpo11+1: bullseye-backports * 2:4.17.9+dfsg-0+deb12u3: bookworm-updates * 2:4.19.6+dfsg-3~bpo12+1: bookworm-backports /usr/lib/systemd/system/samba-ad-dc.service is now part of samba-ad-dc. Since these actually refer to the same file via different paths (due to /usr-move), we produce a DEP17 P1 problem and the declared Replaces are ineffective leading to file loss in an upgrade scenario (what the file move moratorium meant to prevent). This needs to be mitigated and I am attaching the necessary patch. Helmutdiff -Nru samba-4.20.1+dfsg/debian/changelog samba-4.20.1+dfsg/debian/changelog --- samba-4.20.1+dfsg/debian/changelog 2024-05-26 17:48:17.000000000 +0200 +++ samba-4.20.1+dfsg/debian/changelog 2024-05-28 13:37:34.000000000 +0200 @@ -1,3 +1,10 @@ +samba (2:4.20.1+dfsg-3.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Mitigate ineffective replaces due to /usr-move (DEP17 P1). (Closes: #-1) + + -- Helmut Grohne <hel...@subdivi.de> Tue, 28 May 2024 13:37:34 +0200 + samba (2:4.20.1+dfsg-3) unstable; urgency=medium * d/rules: move samba-common install to d/samba-common.install diff -Nru samba-4.20.1+dfsg/debian/control samba-4.20.1+dfsg/debian/control --- samba-4.20.1+dfsg/debian/control 2024-05-26 14:33:25.000000000 +0200 +++ samba-4.20.1+dfsg/debian/control 2024-05-28 12:36:04.000000000 +0200 @@ -203,8 +203,10 @@ Enhances: bind9, ntp Breaks: samba-ad-provision (<< ${source:Upstream-Version}), # files moved from samba & samba-common-bin in 4.20.1-2: - samba (<< 2:4.20.1+dfsg-2~), samba-common-bin (<< 2:4.20.1+dfsg-2~), -Replaces: samba (<< 2:4.20.1+dfsg-2~), samba-common-bin (<< 2:4.20.1+dfsg-2~), + samba-common-bin (<< 2:4.20.1+dfsg-2~), +Replaces: samba-common-bin (<< 2:4.20.1+dfsg-2~), +# Breaks+Replaces upgraded to Conflicts for DEP17 + /usr-move +Conflicts: samba (<< 2:4.20.1+dfsg-2~), Description: Samba control files to run AD Domain Controller Samba is an implementation of the SMB/CIFS protocol for Unix systems, providing support for cross-platform file and printer sharing with diff -Nru samba-4.20.1+dfsg/debian/samba-ad-dc.lintian-overrides samba-4.20.1+dfsg/debian/samba-ad-dc.lintian-overrides --- samba-4.20.1+dfsg/debian/samba-ad-dc.lintian-overrides 1970-01-01 01:00:00.000000000 +0100 +++ samba-4.20.1+dfsg/debian/samba-ad-dc.lintian-overrides 2024-05-28 13:37:34.000000000 +0200 @@ -0,0 +1,3 @@ +# begin-remove-after: trixie +diversion-for-unknown-file lib/systemd/system/samba-ad-dc.service [preinst:*] +# end-remove-after diff -Nru samba-4.20.1+dfsg/debian/samba-ad-dc.postinst samba-4.20.1+dfsg/debian/samba-ad-dc.postinst --- samba-4.20.1+dfsg/debian/samba-ad-dc.postinst 1970-01-01 01:00:00.000000000 +0100 +++ samba-4.20.1+dfsg/debian/samba-ad-dc.postinst 2024-05-28 13:37:30.000000000 +0200 @@ -0,0 +1,15 @@ +#!/bin/sh + +# begin-remove-after: released:trixie +# protective diversion of files moved from / to /usr, to avoid file loss. +# Only for upgrades. +if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ]; then + dpkg-divert --package #PACKAGE# --no-rename \ + --divert /lib/systemd/system/samba-ad-dc.service.usr-is-merged \ + --remove /lib/systemd/system/samba-ad-dc.service +fi +# end-remove-after + +#DEBHELPER# + +exit 0 diff -Nru samba-4.20.1+dfsg/debian/samba-ad-dc.preinst samba-4.20.1+dfsg/debian/samba-ad-dc.preinst --- samba-4.20.1+dfsg/debian/samba-ad-dc.preinst 1970-01-01 01:00:00.000000000 +0100 +++ samba-4.20.1+dfsg/debian/samba-ad-dc.preinst 2024-05-28 13:36:29.000000000 +0200 @@ -0,0 +1,15 @@ +#!/bin/sh + +# begin-remove-after: released:trixie +# protective diversion of files moved from / to /usr, to avoid file loss. +# Only for upgrades. +if [ "$1" = "upgrade" ] || [ "$1" = "install" ]; then + dpkg-divert --package #PACKAGE# --no-rename \ + --divert /lib/systemd/system/samba-ad-dc.service.usr-is-merged \ + --add /lib/systemd/system/samba-ad-dc.service +fi +# end-remove-after + +#DEBHELPER# + +exit 0
--- End Message ---
--- Begin Message ---Source: samba Source-Version: 2:4.20.1+dfsg-4 Done: Michael Tokarev <m...@tls.msk.ru> We believe that the bug you reported is fixed in the latest version of samba, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1072...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Michael Tokarev <m...@tls.msk.ru> (supplier of updated samba package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Wed, 29 May 2024 20:31:41 +0300 Source: samba Architecture: source Version: 2:4.20.1+dfsg-4 Distribution: unstable Urgency: medium Maintainer: Debian Samba Maintainers <pkg-samba-ma...@lists.alioth.debian.org> Changed-By: Michael Tokarev <m...@tls.msk.ru> Closes: 1072102 Changes: samba (2:4.20.1+dfsg-4) unstable; urgency=medium . [ Helmut Grohne ] * Mitigate ineffective replaces due to /usr-move (DEP17 P1) (Closes: #1072102) . [ Michael Tokarev ] * d/control: mark libkeyutils-dev as linux-only [linux-any] * d/control: drop old versions of versioned dependencies Checksums-Sha1: 2031c903b983dff9547c583bf8ef51e16b1c0e53 4585 samba_4.20.1+dfsg-4.dsc 19b8c00998b56560313bf22e439ac0c297e260f6 176160 samba_4.20.1+dfsg-4.debian.tar.xz fa3a13bfa27e64749effef157b85167d0eb77482 6367 samba_4.20.1+dfsg-4_source.buildinfo Checksums-Sha256: 4f185b64abbb9311ae2de5587e2a874d8a46a711101e719204a3aa4262ab6d63 4585 samba_4.20.1+dfsg-4.dsc 2c7b06ac3f3b0cadd9388787942cee109dae39c76c61013b959b928e5d20b3a4 176160 samba_4.20.1+dfsg-4.debian.tar.xz d8aefed303420231a407fc02e70e050b4048ac9d179fc419b992755a7241cd2c 6367 samba_4.20.1+dfsg-4_source.buildinfo Files: ef74f7749782735d92479829a927abb6 4585 net optional samba_4.20.1+dfsg-4.dsc d06aeab6418e61e36d8f42f31cce1e49 176160 net optional samba_4.20.1+dfsg-4.debian.tar.xz 34a08d5b1f2a57f5a4d186c62985235e 6367 net optional samba_4.20.1+dfsg-4_source.buildinfo -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmZXZpcPHG1qdEB0bHMu bXNrLnJ1AAoJEHAbT2saaT5ZavIH/1IaQvntCQr/4c5O3+YeMQm0PaIjyiVBfDo3 a1379uyDJDZRN2oBDMq/dJ/ClG7UR565gsQDVgLREFUYnnAxSGPt+F2MQmnTXT80 vT+tOSkPVQrpC92gVMf9kk/sT5qqylVdkbanYZhbgaN9RPIAEOjp1u1M1yyYwWEz zMyIOZ2px2RY+6oHaUkDanK3V/ObXJLb89pAKzP81UdKxT+tgrtVMuzg9nVP2hHr cKdmESnFbnfJ70Nk7uce1KpINStqVrI/QNH/sBVm09pBp+U9DcTo753LIba7xZdm eBAGp6QFYJBowvmNNycAi9mmZb+C3NdJfVYR2WjATUe+19LKUFo= =qq4e -----END PGP SIGNATURE-----
pgpbYi8Qrulqu.pgp
Description: PGP signature
--- End Message ---
