Bug#1025096: marked as done (nanoc: FTBFS in bullseye, and will also FTBFS in bookworm next year)

[Debian Bug Tracking System]

Your message dated Sun, 7 Apr 2024 17:32:26 +0200
with message-id <4389d8a1-b816-4466-83f6-a6b2416d0...@debian.org>
and subject line Re: nanoc: FTBFS in bullseye, and will also FTBFS in bookworm 
next year
has caused the Debian Bug report #1025096,
regarding nanoc: FTBFS in bullseye, and will also FTBFS in bookworm next year
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1025096: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025096
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

--- Begin Message ---

Package: src:nanoc
Version: 4.11.23-1
Severity: serious
Tags: ftbfs, patch

Dear maintainer:



  1) Nanoc::Core has up-to-date version information



       Diff:
       @@ -1,2 +1,3 @@
       -/–2022 /
       +Nanoc 4.11.23 © 2007–2021 Denis Defreyne.





I include a trivial patch to disable the test in bullseye.



Thanks.


--- a/nanoc-core/spec/nanoc/core_spec.rb
+++ b/nanoc-core/spec/nanoc/core_spec.rb
@@ -3,8 +3,8 @@
 require 'nanoc/version'
 
 describe Nanoc::Core do
-  it 'has up-to-date version information' do
-    current_year = Date.today.year
-    expect(described_class.version_information).to match(/–#{current_year} /)
-  end
+#  it 'has up-to-date version information' do
+#    current_year = Date.today.year
+#    expect(described_class.version_information).to match(/–#{current_year} /)
+#  end
 end

--- a/nanoc-core/spec/nanoc/core_spec.rb
+++ b/nanoc-core/spec/nanoc/core_spec.rb
@@ -4,7 +4,7 @@ require 'nanoc/version'
 
 describe Nanoc::Core do
   it 'has up-to-date version information' do
-    current_year = Date.today.year
+    current_year = 2023
     expect(described_class.version_information).to match(/–#{current_year} /)
   end
 end

During a rebuild of all packages in bullseye I noticed that this package does not build from source anymore: Failure/Error: expect(described_class.version_information).to match(/–#{current_year} /) expected "Nanoc 4.11.23 © 2007–2021 Denis Defreyne.\nRunning ruby 2.7.4 (2021-07-07) on x86_64-linux-gnu with RubyGems 3.2.5.\n" to match /–2022 / +Running ruby 2.7.4 (2021-07-07) on x86_64-linux-gnu with RubyGems 3.2.5. This happens because there is a test which expects the current year to be equal to 2021, which naturally fails now that we are in 2022, and will fail forever from now on. Note also that the current version in testing/unstable also has the bug in "latent state", as it will fail from 2023 onwards. To check this, try building the package after setting current_year to 2023 as in poc.diff.txt and you will see what happens next year. [ p.s. I'm having a dejavu. Didn't I report something like this a few years ago? ]
--- End Message ---

--- Begin Message ---

Hi,

On Tue, 27 Dec 2022 20:36:08 +0100 Santiago Vila <sanv...@debian.org> wrote:

reopen 1025096
found 1025096 4.11.23-1
fixed 1025096 4.12.14-1
thanks

Please consider fixing this in stable as well.

Paul

Please don't reopen bugs that are correctly closed in unstable. The BTS knows how to do proper tracking in other suites if you feed it the "found" versions. But the bug *is* fixed in unstable and hence can be closed. PS: you know I'm in favor of fixing FTBFS in stable and oldstable, so this isn't in any way saying this bug isn't valid.

OpenPGP_signature.asc
Description: OpenPGP digital signature

--- End Message ---