Your message dated Thu, 04 Apr 2024 23:05:52 +0000
with message-id <e1rsw9y-00c0zo...@fasolo.debian.org>
and subject line Bug#1066866: fixed in railway-gtk 2.4.0-2
has caused the Debian Bug report #1066866,
regarding railway-gtk: FTBFS on i386 "type annotations needed"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1066866: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066866
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: railway-gtk
Version: 2.4.0-1
Severity: serious
railway-gtk FTBFS on i386 (and will probablly FTBFS on other
32-bit architectures but builds on those architectures are
currently blocked by the time64 transition).
error[E0283]: type annotations needed for `std::option::Option<U>`
--> src/backend/journeys_result.rs:207:17
|
207 | let index = list
| ^^^^^
...
215 | if position <= index && index < position + n_items {
| -- type must be known at this point
|
= note: multiple `impl`s satisfying `u32: PartialOrd<_>` found in the
following crates: `core`, `glib`:
- impl PartialOrd for u32;
- impl PartialOrd<ULong> for u32;
help: consider giving `index` an explicit type, where the placeholders `_` are
specified
|
207 | let index: std::option::Option<U> = list
| ++++++++++++++++++++++++
Looking at the code, I'm pretty confident that the intended type was
Option<u32>. The attached debdiff adds the annotation. I have tested
that railway-gtk builds succesfully with this patch on both i386
and amd64.
diff -Nru railway-gtk-2.4.0/debian/changelog railway-gtk-2.4.0/debian/changelog
--- railway-gtk-2.4.0/debian/changelog 2024-03-04 13:13:51.000000000 +0000
+++ railway-gtk-2.4.0/debian/changelog 2024-03-14 16:10:58.000000000 +0000
@@ -1,3 +1,10 @@
+railway-gtk (2.4.0-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTBFS with "type annotation needed" error on i386.
+
+ -- Peter Michael Green <plugw...@debian.org> Thu, 14 Mar 2024 16:10:58 +0000
+
railway-gtk (2.4.0-1) unstable; urgency=medium
* New upstream release
diff -Nru railway-gtk-2.4.0/debian/patches/add-type-annotation.patch
railway-gtk-2.4.0/debian/patches/add-type-annotation.patch
--- railway-gtk-2.4.0/debian/patches/add-type-annotation.patch 1970-01-01
00:00:00.000000000 +0000
+++ railway-gtk-2.4.0/debian/patches/add-type-annotation.patch 2024-03-14
16:10:58.000000000 +0000
@@ -0,0 +1,13 @@
+Index: railway-gtk-2.4.0/src/backend/journeys_result.rs
+===================================================================
+--- railway-gtk-2.4.0.orig/src/backend/journeys_result.rs
++++ railway-gtk-2.4.0/src/backend/journeys_result.rs
+@@ -204,7 +204,7 @@ mod imp {
+ let list = self.journeys.borrow();
+ let selection = self.selected.borrow();
+
+- let index = list
++ let index: Option<u32> = list
+ .iter()
+ .position(|j| {
+ j.refresh_token() == selection.as_ref().and_then(|j|
j.refresh_token())
diff -Nru railway-gtk-2.4.0/debian/patches/series
railway-gtk-2.4.0/debian/patches/series
--- railway-gtk-2.4.0/debian/patches/series 2024-03-04 13:13:51.000000000
+0000
+++ railway-gtk-2.4.0/debian/patches/series 2024-03-14 16:10:14.000000000
+0000
@@ -1,3 +1,4 @@
relax-deps.diff
disable-cargo-home-meson-build.diff
build-set-project-name-to-railway-gtk.patch
+add-type-annotation.patch
--- End Message ---
--- Begin Message ---
Source: railway-gtk
Source-Version: 2.4.0-2
Done: Jeremy Bícha <jbi...@ubuntu.com>
We believe that the bug you reported is fixed in the latest version of
railway-gtk, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1066...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jeremy Bícha <jbi...@ubuntu.com> (supplier of updated railway-gtk package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 04 Apr 2024 18:53:47 -0400
Source: railway-gtk
Built-For-Profiles: noudeb
Architecture: source
Version: 2.4.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<pkg-gnome-maintain...@lists.alioth.debian.org>
Changed-By: Jeremy Bícha <jbi...@ubuntu.com>
Closes: 1066866
Changes:
railway-gtk (2.4.0-2) unstable; urgency=medium
.
* Team upload
* Cherry-pick patch to fix 32-bit build (Closes: #1066866)
Checksums-Sha1:
236b1e34f483ddb9f277a5bbff5656afb3cc6001 3098 railway-gtk_2.4.0-2.dsc
8499b771e7fe48a31e35dd93ae36e1eb9ef3375b 10436
railway-gtk_2.4.0-2.debian.tar.xz
d4b131e8704d721fd88a193d4112d27ed2a6a7a3 9277
railway-gtk_2.4.0-2_source.buildinfo
Checksums-Sha256:
ae9270f65d9d6d4a56d8d9535c049bac572d80546048ca9bc99606c1f36cea52 3098
railway-gtk_2.4.0-2.dsc
d6024309b01e5a2e960d190299720022e16b0c9462d58993de7505031457fb19 10436
railway-gtk_2.4.0-2.debian.tar.xz
167434320e8ea357046a944f8c5b4e8a9c53b77b3dace49b677db8bb3be30684 9277
railway-gtk_2.4.0-2_source.buildinfo
Files:
a63133f7092483c1f5d090de906f31b2 3098 gnome optional railway-gtk_2.4.0-2.dsc
2df247bacc4c2f70e59aee693b20cf17 10436 gnome optional
railway-gtk_2.4.0-2.debian.tar.xz
a990c8cb31be46054a2f38cdd2f209da 9277 gnome optional
railway-gtk_2.4.0-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEETQvhLw5HdtiqzpaW5mx3Wuv+bH0FAmYPL54ACgkQ5mx3Wuv+
bH23qA/9GjLYZTn8l4NMhMbAPQDXBes6wXJKhOl3PLQiFguLRkcJB0mrHGkFgG0u
xfd0AeAqoT4WiEUHNO6q8jEDPBYFzJ+YjTPanv9LeOKqvp4TULcokzvlZCtbsQb0
gFi6blxeinSk+m8LisNDxi3fYOXuNU+6d8Ky3QBR6EEraRYE0iEintxlqknBUpBu
bglol+ZIasUxt/aN/bOfORS7/gNmA39pmVVjGR4Kalktan1kHFLhvmfW8KIbfJa8
sXJ3PfAY++lU1jh/AcBnE6eo7kUTQ2Qjyp+MAWNNqPcMUqTeKAqC0B6fn+U8oXZZ
qH8F0ifUXsI+THAGuisOVtll9KTtQwYH/SBfRs/r2gz635OGKLrHqBUlxAoJs9Za
x8kNW4jbL5SxY2bR7VgbbWbz2ufhjIxhqLkxDi7SZqwVsGYsiga5ASYxZL4810Ho
kR8TV9MWhgd6IwcdNnE4Gv6B7SUkN7lBPDlMQ4adlJMeR+gHJhu3FAJyUedqeICQ
qW+GgxUstmxIJrHnVnB/8+A4kXkShjTX2WbmofzFIMA9s/s9wEYxUISMx1dpa/i3
jc8NGiRpw3a92fZyCxOloazELZcH8/lWGt+QQa5VpN0Y0slGn+axYKUsRp1WahaQ
37d6vlJ5woQu8GdmCdgyBwd9uHO8mMUxPCc097ftdPow6kej72k=
=5z0w
-----END PGP SIGNATURE-----
pgpbFOwMBLVSy.pgp
Description: PGP signature
--- End Message ---
